)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2562e32cdacd4472508b4903d5fee844df5aafd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47081f41_eefb3086","updated":"2021-10-26 00:20:57.000000000","message":"This is a pretty great idea. I\u0027m wholeheartedly in favor.\n\nWhy not generate different sample files for each distro? The only thing that seems weird is shipping a pre-split config file. \n\nThese are nits though, and my opinions on implementation are not strong so just take it as general advice/feedback. The idea in general is great, and the more we can document this knowledge that\u0027s required to run Ironic, in the place where people are going to most readily look, the better the deployer experience will be.","commit_id":"151cd700e22c0ff5b51ca54b83b432f019521ccc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6c65b2f9a1e6d609379528d6d6796c0cfcaf9e59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"114189db_87c2e326","in_reply_to":"47081f41_eefb3086","updated":"2021-10-26 00:46:20.000000000","message":"The problem with a generated sample file for each distro is that the oslo-config-generator generates values which are commented out, so it looks like its a default value but its not.","commit_id":"151cd700e22c0ff5b51ca54b83b432f019521ccc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"450c07f450aec0d807c200893423541ac140141d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7323997d_86efd090","updated":"2021-11-02 00:07:34.000000000","message":"It looks like backslashes should not be used, hopefully some kind of multiline is possible:\n\n0027172580 ironic-conductor[106579]: DEBUG oslo_service.service [-] pxe.loader_file_paths          \u003d {\u0027snponly.efi\u0027: \u0027/usr/lib/ipxe/ipxe.efi\u0027, \u0027\\\\\\nundionly.kpxe\u0027: \u0027/usr/lib/ipxe/undionly.kpxe\u0027, \u0027\\\\\\nipxe.lkrn\u0027: \u0027/usr/lib/ipxe/ipxe.pxe\u0027, \u0027\\\\\\nbootx86.efi\u0027: \u0027/usr/lib/shim/shimx64.efi.signed\u0027, \u0027\\\\\\ngrubx86.efi\u0027: \u0027/usr/lib/grub/x86_64-efi-signed/grubnetx64.efi.signed\u0027} {{(pid\u003d106579) log_opt_values /usr/local/lib/python3.8/dist-packages/oslo_config/cfg.py:2609}}\n\nNov 01 04:49:21.874791 ubuntu-focal-rax-dfw-","commit_id":"6249c6ca1f4647e8689218488cedb8989734c274"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5d7e5d681893ca7007107ab7161d8073c7112270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d9cbf741_cc53db28","updated":"2021-11-04 01:02:28.000000000","message":"recheck","commit_id":"edc4193cf61de1c38a0e844b371bba4b0f7ff78d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9ee30fa32bb6af3bdf6a730b461b0432f2d49e19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e7b29105_9c94984c","updated":"2021-11-22 20:39:57.000000000","message":"recheck","commit_id":"edc4193cf61de1c38a0e844b371bba4b0f7ff78d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2e820de8c31a521e94bc7ce0df37b595046e621f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d5022c72_bf691960","updated":"2021-12-09 15:59:03.000000000","message":"recheck","commit_id":"3f767e2445f30833afb8f59265462da5d1b0bc81"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34050951b9e182cc35bcfccedf9b09997fb10173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"865c1f12_0b09e503","updated":"2021-12-14 02:30:19.000000000","message":"recheck","commit_id":"3732bc979690ef9bc16e71d23ef65faeb79f2071"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"60e1e0554fb1b6f1dc38103beda16d100726e0eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"eeb3a8dc_6c469377","updated":"2025-11-22 15:08:46.000000000","message":"if you want to do something like this still I think it would work with /etc/ironic/ironic.conf.d/ being the documented path where this gets copied into.","commit_id":"fa54bc64e0faa104d202dca045dd76c1994fbb29"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7a779c7351e8bc1d998e14c7b9d988d8391dc53b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"551490c9_29324e53","updated":"2022-01-12 22:53:54.000000000","message":"recheck","commit_id":"fa54bc64e0faa104d202dca045dd76c1994fbb29"}],"devstack/lib/ironic":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b871936f5901d1095577dbb70cd0998954c142fc","unresolved":true,"context_lines":[{"line_number":737,"context_line":"    if is_ubuntu; then"},{"line_number":738,"context_line":"        # NOTE(TheJulia): This *should* be snponly.efi, however"},{"line_number":739,"context_line":"        # ubuntu only started shipping it in hirtuse."},{"line_number":740,"context_line":"        echo /usr/lib/ipxe/ipxe.efi"},{"line_number":741,"context_line":"    elif is_fedora; then"},{"line_number":742,"context_line":"        echo /usr/share/ipxe/ipxe-snponly-x86_64.efi"},{"line_number":743,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1c2e751c_024bf7d2","side":"PARENT","line":740,"updated":"2021-11-01 00:32:44.000000000","message":"I think this means debian and ubuntu dist files need to diverge, at least until CI moves to hirsute or later","commit_id":"9ac35cfb427dfc696773cc076e1d0d728d58aeba"}],"etc/ironic/ironic-dist-centos.conf":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5cdda6c88d0e134c2f757ececf4089589cabbce1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#   ipxe-bootimgs"},{"line_number":4,"context_line":"#   shim"},{"line_number":5,"context_line":"#   grub2-efi"},{"line_number":6,"context_line":"loader_file_paths \u003d snponly.efi:/usr/share/ipxe/ipxe-snponly-x86_64.efi,"},{"line_number":7,"context_line":"    undionly.kpxe:/usr/share/ipxe/undionly.kpxe,"},{"line_number":8,"context_line":"    ipxe.lkrn:/usr/share/ipxe/ipxe.lkrn,"},{"line_number":9,"context_line":"    bootx64.efi:/boot/efi/EFI/centos/shimx64.efi,"}],"source_content_type":"text/plain","patch_set":12,"id":"e1a62422_e5acb7d9","line":6,"updated":"2021-11-24 20:49:58.000000000","message":"I think we\u0027ll have to give up on multiline. It breaks reading the value for devstack, sed based shell scripts, and ansible ini lookup.","commit_id":"186dd5559c2243da0c5b705041507492ee6ef4da"}],"etc/ironic/ironic-dist-deb-family.conf":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b871936f5901d1095577dbb70cd0998954c142fc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#   ipxe"},{"line_number":4,"context_line":"#   shim-signed"},{"line_number":5,"context_line":"#   grub-efi-amd64-signed"},{"line_number":6,"context_line":"loader_file_paths \u003d snponly.efi:/usr/lib/ipxe/ipxe-snponly-x86_64.efi, \\"},{"line_number":7,"context_line":"    undionly.kpxe:/usr/share/ipxe/undionly.kpxe, \\"},{"line_number":8,"context_line":"    ipxe.lkrn:/usr/lib/ipxe/ipxe.pxe, \\"},{"line_number":9,"context_line":"    bootx86.efi:/usr/lib/shim/shimx64.efi.signed, \\"}],"source_content_type":"text/plain","patch_set":5,"id":"f28454e1_d0a0a9e4","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":69},"updated":"2021-11-01 00:32:44.000000000","message":"debian stable has /usr/lib/ipxe/snponly.efi, but ubuntu only packages it from hirsute onwards, lets split them for now","commit_id":"8393b14f8967cc5c761f67da270168983b46bf78"}]}