)]}'
{"ironic/conductor/base_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed2eb04673bed9c4de5e1652b6c499e574da0e0a","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        self.dbapi.clear_node_target_power_state(self.host)"},{"line_number":113,"context_line":"        # clear all locks held by this conductor before registering"},{"line_number":114,"context_line":"        self.dbapi.clear_node_reservations_for_conductor(self.host)"},{"line_number":115,"context_line":"        pxe_utils.place_common_config()"},{"line_number":116,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":117,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.deploy.http_root)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def init_host(self, admin_context\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Initialize the conductor host."}],"source_content_type":"text/x-python","patch_set":6,"id":"6819b5ba_19839147","line":117,"range":{"start_line":115,"start_character":3,"end_line":117,"end_character":63},"updated":"2021-11-26 09:06:02.000000000","message":"Let\u0027s stop sticking PXE-specific code into the generic conductor. We have situation where PXE is completely disabled.","commit_id":"2f2af33236aabde94eb85e63126374853bc0b4a7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6665cbd0baa850c431473ae287208c106064aa4c","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        self.dbapi.clear_node_target_power_state(self.host)"},{"line_number":113,"context_line":"        # clear all locks held by this conductor before registering"},{"line_number":114,"context_line":"        self.dbapi.clear_node_reservations_for_conductor(self.host)"},{"line_number":115,"context_line":"        pxe_utils.place_common_config()"},{"line_number":116,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":117,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.deploy.http_root)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def init_host(self, admin_context\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Initialize the conductor host."}],"source_content_type":"text/x-python","patch_set":6,"id":"6f9b9106_7ade8b31","line":117,"range":{"start_line":115,"start_character":3,"end_line":117,"end_character":63},"in_reply_to":"6819b5ba_19839147","updated":"2021-11-29 03:04:10.000000000","message":"To make this suggestion actionable, I\u0027d suggest the BootInterface get a new prepare_host method, and these calls get moved to the pxe and ipxe boot drivers. Then here we call prepare_host on each driver in enabled_boot_interfaces.","commit_id":"2f2af33236aabde94eb85e63126374853bc0b4a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a900ff1bcb07d6b5a512cfe9529cf88523d80e8f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        self.dbapi.clear_node_target_power_state(self.host)"},{"line_number":113,"context_line":"        # clear all locks held by this conductor before registering"},{"line_number":114,"context_line":"        self.dbapi.clear_node_reservations_for_conductor(self.host)"},{"line_number":115,"context_line":"        pxe_utils.place_common_config()"},{"line_number":116,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":117,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.deploy.http_root)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def init_host(self, admin_context\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Initialize the conductor host."}],"source_content_type":"text/x-python","patch_set":6,"id":"876ecb0c_1f0b0a6b","line":117,"range":{"start_line":115,"start_character":3,"end_line":117,"end_character":63},"in_reply_to":"6f9b9106_7ade8b31","updated":"2021-11-29 08:38:42.000000000","message":"We already have __init__ where we create boot.ipxe, why not there?","commit_id":"2f2af33236aabde94eb85e63126374853bc0b4a7"}],"ironic/conf/pxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40d0f390bbaece4c0aa5e13acaa042ff9b7b1adb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                   \u0027for bootloaders. Use example: \u0027"},{"line_number":205,"context_line":"                   \u0027ipxe.efi:/usr/share/ipxe/ipxe-snponly-x86_64.efi,\u0027"},{"line_number":206,"context_line":"                   \u0027undionly.kpxe:/usr/share/ipxe/undionly.kpxe\u0027)),"},{"line_number":207,"context_line":"    cfg.StrOpt(\u0027master_grub_template\u0027,"},{"line_number":208,"context_line":"               default\u003dos.path.join("},{"line_number":209,"context_line":"                   \u0027$pybasedir\u0027, \u0027drivers/modules/master_grub_cfg.template\u0027),"},{"line_number":210,"context_line":"               help\u003d_(\u0027On ironic-conductor node, the path to the master grub\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"dbf775df_5c5c6ac3","line":207,"updated":"2021-12-07 18:44:45.000000000","message":"nit: I wonder if we should avoid the word \"master\" given the latest developments.","commit_id":"61bcf1814890b284d39be97fb310bf4833517f10"}]}