)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"541b66be98e89ba2bdeabafdbb63fe6fc44ad8df","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RedfishManagement.get_mac_addresses has two problems:"},{"line_number":10,"context_line":"* It returns a dict while the base class documents returning a list"},{"line_number":11,"context_line":"* The dict\u0027s values are Redfish-specific values"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes this function to return a list and significantly"},{"line_number":14,"context_line":"simplifies the related create_ports_if_not_exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7255f092_531ca3da","line":11,"updated":"2021-11-08 16:39:28.000000000","message":"I\u0027m not sure if I missed it -- Are dict\u0027s values MAC addresses? I didn\u0027t see anything that xlates redfish values to something else.","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a92050dc47b20210e5ea6d152b13fbd99cbe91f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RedfishManagement.get_mac_addresses has two problems:"},{"line_number":10,"context_line":"* It returns a dict while the base class documents returning a list"},{"line_number":11,"context_line":"* The dict\u0027s values are Redfish-specific values"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes this function to return a list and significantly"},{"line_number":14,"context_line":"simplifies the related create_ports_if_not_exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"128052ed_cd4388ef","line":11,"in_reply_to":"7255f092_531ca3da","updated":"2021-11-09 16:57:21.000000000","message":"Currently it\u0027s MAC -\u003e Redfish status","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a92050dc47b20210e5ea6d152b13fbd99cbe91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f46fa86_e0d0a9e8","updated":"2021-11-09 16:57:21.000000000","message":"\u003e Does it need a release note? Seems like inspection would fail if using redfish (I\u0027m not totally sure though)\n\nNo, it\u0027s only refactoring at this point (although it makes the redfish implementation future-proof against sushy changes)","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"541b66be98e89ba2bdeabafdbb63fe6fc44ad8df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db62fbec_ac30ad3c","updated":"2021-11-08 16:39:28.000000000","message":"Thanks! Does it need a release note? Seems like inspection would fail if using redfish (I\u0027m not totally sure though).","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1eb412395c0e548d47807f1ebc5ec938a51ec036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"624d9c19_278733a5","updated":"2021-11-10 10:32:59.000000000","message":"thanks for the patch, looks OK, one question inline.","commit_id":"815705bc7deb877c2efaee750bbfaabcd3e635ff"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"541b66be98e89ba2bdeabafdbb63fe6fc44ad8df","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        \"\"\"Get a list of MAC addresses"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param task: a TaskManager instance."},{"line_number":79,"context_line":"        :returns: Returns list of MAC addresses."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":82,"context_line":"        # Get dictionary of ethernet interfaces"}],"source_content_type":"text/x-python","patch_set":1,"id":"2545cf70_23ab0984","line":79,"updated":"2021-11-08 16:39:28.000000000","message":"something odd with this too; looks like it is returning a dict. Might just need to update this. And rename the method. Ok, not going there :)","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a92050dc47b20210e5ea6d152b13fbd99cbe91f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \"\"\"Get a list of MAC addresses"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param task: a TaskManager instance."},{"line_number":79,"context_line":"        :returns: Returns list of MAC addresses."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":82,"context_line":"        # Get dictionary of ethernet interfaces"}],"source_content_type":"text/x-python","patch_set":1,"id":"87c48654_c3455331","line":79,"in_reply_to":"2545cf70_23ab0984","updated":"2021-11-09 16:57:21.000000000","message":"It\u0027s actually a good call.","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"541b66be98e89ba2bdeabafdbb63fe6fc44ad8df","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"        try:"},{"line_number":1120,"context_line":"            system \u003d redfish_utils.get_system(task.node)"},{"line_number":1121,"context_line":"            return list(redfish_utils.get_enabled_macs(task, system) or ())"},{"line_number":1122,"context_line":"        except sushy.exceptions.SushyError as exc:"},{"line_number":1123,"context_line":"            msg \u003d (_(\u0027Failed to get network interface information on node \u0027"},{"line_number":1124,"context_line":"                     \u0027%(node)s: %(exc)s\u0027)"},{"line_number":1125,"context_line":"                   % {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":1,"id":"567bcca5_b01d31ac","line":1122,"updated":"2021-11-08 16:39:28.000000000","message":"i\u0027m surprised that redfish_utils.get_enabled_macs() doesn\u0027t return an empty dict.","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a92050dc47b20210e5ea6d152b13fbd99cbe91f","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        try:"},{"line_number":1120,"context_line":"            system \u003d redfish_utils.get_system(task.node)"},{"line_number":1121,"context_line":"            return list(redfish_utils.get_enabled_macs(task, system) or ())"},{"line_number":1122,"context_line":"        except sushy.exceptions.SushyError as exc:"},{"line_number":1123,"context_line":"            msg \u003d (_(\u0027Failed to get network interface information on node \u0027"},{"line_number":1124,"context_line":"                     \u0027%(node)s: %(exc)s\u0027)"},{"line_number":1125,"context_line":"                   % {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":1,"id":"f22d7cc2_afb49f1e","line":1122,"in_reply_to":"567bcca5_b01d31ac","updated":"2021-11-09 16:57:21.000000000","message":"Done","commit_id":"c24d2f5bd763f3ccc8c085a2564563afae7d6f3d"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1eb412395c0e548d47807f1ebc5ec938a51ec036","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":382,"context_line":"    :param system: a Redfish System object"},{"line_number":383,"context_line":"    :returns: a dictionary containing MAC addresses of enabled interfaces"},{"line_number":384,"context_line":"        in a {\u0027mac\u0027: \u003cstate\u003e} format, where \u003cstate\u003e is a sushy constant"},{"line_number":385,"context_line":"    \"\"\""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    enabled_macs \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9f17e18_92501a18","line":384,"range":{"start_line":384,"start_character":7,"end_line":384,"end_character":71},"updated":"2021-11-10 10:32:59.000000000","message":"is this function used anywhere where it is not list()-ed? Could this be changed to return list so don\u0027t have to cast it where it\u0027s used? Also, what are the possible values for state? Isn\u0027t it all STATE_ENABLED for all entries? Method name also suggests that they are all enabled, so maybe no need for dict with \u003cstate\u003e? Or I\u0027m missing smth..","commit_id":"815705bc7deb877c2efaee750bbfaabcd3e635ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1f945e9ef6700e6e62679271c7032db7baeec976","unresolved":true,"context_lines":[{"line_number":381,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":382,"context_line":"    :param system: a Redfish System object"},{"line_number":383,"context_line":"    :returns: a dictionary containing MAC addresses of enabled interfaces"},{"line_number":384,"context_line":"        in a {\u0027mac\u0027: \u003cstate\u003e} format, where \u003cstate\u003e is a sushy constant"},{"line_number":385,"context_line":"    \"\"\""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    enabled_macs \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f7563af_ab8d6898","line":384,"range":{"start_line":384,"start_character":7,"end_line":384,"end_character":71},"in_reply_to":"a9f17e18_92501a18","updated":"2021-11-10 10:48:24.000000000","message":"A good point. I\u0027ll follow-up if this change gets approved (don\u0027t want to lose a +2)","commit_id":"815705bc7deb877c2efaee750bbfaabcd3e635ff"}]}