)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"24041a925ffe36583612a699ebb26cbb4832ac68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66700f2a_01286613","updated":"2022-01-20 08:32:23.000000000","message":"recheck","commit_id":"ef49d8a8532bf359184a263e91ef68a180611184"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5c65fe71e8a5195f7662b761db4646a44b8663a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"90b3fc55_3c3c72c3","updated":"2022-01-20 20:10:10.000000000","message":"recheck","commit_id":"14eb8bf5a6a1707e51772e3958ff2ae51c546659"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b2a12d97_4415eee0","updated":"2022-03-14 10:13:51.000000000","message":"thanks Dmitry!\nmarking WIP again while switching to iso.walk","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d2424490eba59a3c21af8af0309f6639072426bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a7af52ef_dd54bfe3","updated":"2022-03-14 14:13:43.000000000","message":"recheck I blame network","commit_id":"7d1d2da0d17b86b49279389865787bdcfab64c93"}],"ironic/common/images.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8e0d0268f6820565e1eb5fcfc64b909ced2e43a9","unresolved":true,"context_lines":[{"line_number":610,"context_line":"    return is_whole_disk_image"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":614,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    :param deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":4,"id":"4cece62c_5613b744","line":613,"updated":"2022-01-10 21:09:56.000000000","message":"I looked at this function yesterday, a modified version of this function could extract the files out of the iso using pycdlib and populate the supplied directory path. This would require minimal changes to the function call pattern.\n\nRiccardo let me know if you want to do this or if I can try.","commit_id":"395b8ebcf25f5879f923db6d030556dee438e378"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4369e12b9d0d8249b3038238420ea2f95d5c8504","unresolved":true,"context_lines":[{"line_number":610,"context_line":"    return is_whole_disk_image"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":614,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    :param deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8fac506_d6d95297","line":613,"in_reply_to":"1fbddaa8_0f82efde","updated":"2022-01-11 21:49:07.000000000","message":"OK cool, I\u0027ll do it as a separate change so you can finish off the pycdlib conversions in this change","commit_id":"395b8ebcf25f5879f923db6d030556dee438e378"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"885c7e35d77113694e5c3716d472228a37acff28","unresolved":true,"context_lines":[{"line_number":610,"context_line":"    return is_whole_disk_image"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":614,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    :param deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fbddaa8_0f82efde","line":613,"in_reply_to":"4cece62c_5613b744","updated":"2022-01-11 14:12:45.000000000","message":"Hey Steve, I was planning to get back to this patch this week but not sure I can stick to the plan!\nFeel free to go ahead if you already have something, I will find the time to review.","commit_id":"395b8ebcf25f5879f923db6d030556dee438e378"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2aea5f2a3c7945616042381299962711692887bd","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    return is_whole_disk_image"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":614,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    :param deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":4,"id":"73626819_2d791c9b","line":613,"in_reply_to":"a8fac506_d6d95297","updated":"2022-02-23 15:05:03.000000000","message":"Done","commit_id":"395b8ebcf25f5879f923db6d030556dee438e378"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5c65fe71e8a5195f7662b761db4646a44b8663a8","unresolved":true,"context_lines":[{"line_number":636,"context_line":"    grub_rel_path \u003d None"},{"line_number":637,"context_line":"    grub_path \u003d None"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    try:"},{"line_number":640,"context_line":"        utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":641,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":642,"context_line":"        LOG.exception(\"mounting the deploy iso failed.\")"},{"line_number":643,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    try:"},{"line_number":646,"context_line":"        for (dir, subdir, files) in os.walk(mountdir):"},{"line_number":647,"context_line":"            if \u0027efiboot.img\u0027 in files:"},{"line_number":648,"context_line":"                e_img_path \u003d os.path.join(dir, \u0027efiboot.img\u0027)"},{"line_number":649,"context_line":"                e_img_rel_path \u003d os.path.relpath(e_img_path,"},{"line_number":650,"context_line":"                                                 mountdir)"},{"line_number":651,"context_line":"            if \u0027grub.cfg\u0027 in files:"},{"line_number":652,"context_line":"                grub_path \u003d os.path.join(dir, \u0027grub.cfg\u0027)"},{"line_number":653,"context_line":"                grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":654,"context_line":"                                                mountdir)"},{"line_number":655,"context_line":"    except (OSError, IOError) as e:"},{"line_number":656,"context_line":"        LOG.exception(\"examining the deploy iso failed.\")"},{"line_number":657,"context_line":"        _umount_without_raise(mountdir)"}],"source_content_type":"text/x-python","patch_set":7,"id":"53055f35_334e5ce7","line":654,"range":{"start_line":639,"start_character":0,"end_line":654,"end_character":57},"updated":"2022-01-20 20:10:10.000000000","message":"I know I said I\u0027d start converting to this to pycdlib, but I\u0027ve been pulled into image building issues so if you\u0027d like to do it go ahead.","commit_id":"14eb8bf5a6a1707e51772e3958ff2ae51c546659"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f2bd159bb6e1e1b9edc8717714590bb3cda35289","unresolved":true,"context_lines":[{"line_number":636,"context_line":"    grub_rel_path \u003d None"},{"line_number":637,"context_line":"    grub_path \u003d None"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    try:"},{"line_number":640,"context_line":"        utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":641,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":642,"context_line":"        LOG.exception(\"mounting the deploy iso failed.\")"},{"line_number":643,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    try:"},{"line_number":646,"context_line":"        for (dir, subdir, files) in os.walk(mountdir):"},{"line_number":647,"context_line":"            if \u0027efiboot.img\u0027 in files:"},{"line_number":648,"context_line":"                e_img_path \u003d os.path.join(dir, \u0027efiboot.img\u0027)"},{"line_number":649,"context_line":"                e_img_rel_path \u003d os.path.relpath(e_img_path,"},{"line_number":650,"context_line":"                                                 mountdir)"},{"line_number":651,"context_line":"            if \u0027grub.cfg\u0027 in files:"},{"line_number":652,"context_line":"                grub_path \u003d os.path.join(dir, \u0027grub.cfg\u0027)"},{"line_number":653,"context_line":"                grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":654,"context_line":"                                                mountdir)"},{"line_number":655,"context_line":"    except (OSError, IOError) as e:"},{"line_number":656,"context_line":"        LOG.exception(\"examining the deploy iso failed.\")"},{"line_number":657,"context_line":"        _umount_without_raise(mountdir)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f0581fd7_652cb277","line":654,"range":{"start_line":639,"start_character":0,"end_line":654,"end_character":57},"in_reply_to":"53055f35_334e5ce7","updated":"2022-01-21 13:39:43.000000000","message":"no worries Steve!\nI\u0027ll try to get a look at this next week, if downstream work allows\nAlso the pycdlib conversion requires some more work as it\u0027s not as user-friendly as I expected :)","commit_id":"14eb8bf5a6a1707e51772e3958ff2ae51c546659"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2aea5f2a3c7945616042381299962711692887bd","unresolved":false,"context_lines":[{"line_number":636,"context_line":"    grub_rel_path \u003d None"},{"line_number":637,"context_line":"    grub_path \u003d None"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    try:"},{"line_number":640,"context_line":"        utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":641,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":642,"context_line":"        LOG.exception(\"mounting the deploy iso failed.\")"},{"line_number":643,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    try:"},{"line_number":646,"context_line":"        for (dir, subdir, files) in os.walk(mountdir):"},{"line_number":647,"context_line":"            if \u0027efiboot.img\u0027 in files:"},{"line_number":648,"context_line":"                e_img_path \u003d os.path.join(dir, \u0027efiboot.img\u0027)"},{"line_number":649,"context_line":"                e_img_rel_path \u003d os.path.relpath(e_img_path,"},{"line_number":650,"context_line":"                                                 mountdir)"},{"line_number":651,"context_line":"            if \u0027grub.cfg\u0027 in files:"},{"line_number":652,"context_line":"                grub_path \u003d os.path.join(dir, \u0027grub.cfg\u0027)"},{"line_number":653,"context_line":"                grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":654,"context_line":"                                                mountdir)"},{"line_number":655,"context_line":"    except (OSError, IOError) as e:"},{"line_number":656,"context_line":"        LOG.exception(\"examining the deploy iso failed.\")"},{"line_number":657,"context_line":"        _umount_without_raise(mountdir)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f80d264e_f3c8eece","line":654,"range":{"start_line":639,"start_character":0,"end_line":654,"end_character":57},"in_reply_to":"f0581fd7_652cb277","updated":"2022-02-23 15:05:03.000000000","message":"Done","commit_id":"14eb8bf5a6a1707e51772e3958ff2ae51c546659"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    # type (UDF, RR, JOLIET)."},{"line_number":612,"context_line":"    iso \u003d pycdlib.PyCdlib()"},{"line_number":613,"context_line":"    iso.open(extract_iso)"},{"line_number":614,"context_line":"    iso_root \u003d iso.get_record(**{\u0027iso_path\u0027: \u0027/\u0027})"},{"line_number":615,"context_line":"    iso_dirs \u003d collections.deque([iso_root])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    while iso_dirs:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1c691a77_519ea2cb","line":614,"updated":"2022-03-11 10:34:39.000000000","message":"iso.get_record(iso_path\u003d\u0027/\u0027)?","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    # type (UDF, RR, JOLIET)."},{"line_number":612,"context_line":"    iso \u003d pycdlib.PyCdlib()"},{"line_number":613,"context_line":"    iso.open(extract_iso)"},{"line_number":614,"context_line":"    iso_root \u003d iso.get_record(**{\u0027iso_path\u0027: \u0027/\u0027})"},{"line_number":615,"context_line":"    iso_dirs \u003d collections.deque([iso_root])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    while iso_dirs:"}],"source_content_type":"text/x-python","patch_set":14,"id":"4966a69c_01608c0e","line":614,"in_reply_to":"1c691a77_519ea2cb","updated":"2022-03-14 10:13:51.000000000","message":"yes, thanks! this is a residue of a testing where I had more parameters based on the type of the iso (iso9660, udf, rr, joliet)","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    iso_root \u003d iso.get_record(**{\u0027iso_path\u0027: \u0027/\u0027})"},{"line_number":615,"context_line":"    iso_dirs \u003d collections.deque([iso_root])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    while iso_dirs:"},{"line_number":618,"context_line":"        dir_record \u003d iso_dirs.popleft()"},{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3e82b26e_2848c6ae","line":617,"updated":"2022-03-11 10:34:39.000000000","message":"Won\u0027t iso.walk work better? https://clalancette.github.io/pycdlib/example-walking-iso-filesystem.html","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    iso_root \u003d iso.get_record(**{\u0027iso_path\u0027: \u0027/\u0027})"},{"line_number":615,"context_line":"    iso_dirs \u003d collections.deque([iso_root])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    while iso_dirs:"},{"line_number":618,"context_line":"        dir_record \u003d iso_dirs.popleft()"},{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"}],"source_content_type":"text/x-python","patch_set":14,"id":"f24ba6d9_188d22c6","line":617,"in_reply_to":"3e82b26e_2848c6ae","updated":"2022-03-14 10:13:51.000000000","message":"ehm... I think I reimplemented that based on an example I found....\nI will switch to use iso.walk","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    while iso_dirs:"},{"line_number":618,"context_line":"        dir_record \u003d iso_dirs.popleft()"},{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"},{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"}],"source_content_type":"text/x-python","patch_set":14,"id":"366dc3fd_bb8c157d","line":620,"updated":"2022-03-11 10:34:39.000000000","message":"nit: I hope that len(\u0027/\u0027) \u003d\u003d 1 :)","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    while iso_dirs:"},{"line_number":618,"context_line":"        dir_record \u003d iso_dirs.popleft()"},{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"},{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"}],"source_content_type":"text/x-python","patch_set":14,"id":"ccabf1c8_03ae7697","line":620,"in_reply_to":"366dc3fd_bb8c157d","updated":"2022-03-14 10:13:51.000000000","message":"argh! Another test leftover... thanks!","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"},{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"},{"line_number":624,"context_line":"            if dir_rel !\u003d \u0027\u0027:"},{"line_number":625,"context_line":"                os.makedirs(os.path.join(extract_dir, dir_rel))"}],"source_content_type":"text/x-python","patch_set":14,"id":"be4b7bb9_1c71c2cd","line":622,"updated":"2022-03-11 10:34:39.000000000","message":"nit: dir_rel \u003d dir_rel.lstrip(\u0027/\u0027)","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        dir_path \u003d iso.full_path_from_dirrecord(dir_record)"},{"line_number":620,"context_line":"        dir_rel \u003d dir_path[len(\u0027/\u0027)]"},{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"},{"line_number":624,"context_line":"            if dir_rel !\u003d \u0027\u0027:"},{"line_number":625,"context_line":"                os.makedirs(os.path.join(extract_dir, dir_rel))"}],"source_content_type":"text/x-python","patch_set":14,"id":"0b1613f9_07e7b4dd","line":622,"in_reply_to":"be4b7bb9_1c71c2cd","updated":"2022-03-14 10:13:51.000000000","message":"thanks, moar test leftovers","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"},{"line_number":624,"context_line":"            if dir_rel !\u003d \u0027\u0027:"},{"line_number":625,"context_line":"                os.makedirs(os.path.join(extract_dir, dir_rel))"},{"line_number":626,"context_line":"            child_lister \u003d iso.list_children(**{\u0027iso_path\u0027: dir_path})"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"e5f124d5_16598817","line":624,"updated":"2022-03-11 10:34:39.000000000","message":"nit: \"if dir_rel\"","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        if dir_rel and dir_rel[0] \u003d\u003d \u0027/\u0027:"},{"line_number":622,"context_line":"            dir_rel \u003d dir_rel[1:]"},{"line_number":623,"context_line":"        if dir_record.is_dir():"},{"line_number":624,"context_line":"            if dir_rel !\u003d \u0027\u0027:"},{"line_number":625,"context_line":"                os.makedirs(os.path.join(extract_dir, dir_rel))"},{"line_number":626,"context_line":"            child_lister \u003d iso.list_children(**{\u0027iso_path\u0027: dir_path})"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ecfef71f_ed7bb97c","line":624,"in_reply_to":"e5f124d5_16598817","updated":"2022-03-14 10:13:51.000000000","message":"yes, thanks, ditto","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff9d04513e900f31bff75a3cfb2426a7af46af2d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            iso.get_file_from_iso(os.path.join(extract_dir, dir_rel),"},{"line_number":634,"context_line":"                                  **{\u0027iso_path\u0027: dir_path})"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    iso.close()"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"def _get_deploy_iso_files(deploy_iso, mountdir):"}],"source_content_type":"text/x-python","patch_set":14,"id":"0df4719c_3269b1f3","line":636,"updated":"2022-03-11 10:34:39.000000000","message":"nit: I wonder if PyCdlib works with the \"with\" statement to make sure the file is closed","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"eaf13c8b9f8256681b7c76364dedd9882a7d1f79","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            iso.get_file_from_iso(os.path.join(extract_dir, dir_rel),"},{"line_number":634,"context_line":"                                  **{\u0027iso_path\u0027: dir_path})"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    iso.close()"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"def _get_deploy_iso_files(deploy_iso, mountdir):"}],"source_content_type":"text/x-python","patch_set":14,"id":"6e19b8c7_76ce044e","line":636,"in_reply_to":"0df4719c_3269b1f3","updated":"2022-03-14 10:13:51.000000000","message":"probably, I need to test it, never found an example, so not sure","commit_id":"ebdcbd2d3d591a2f04141df1c2abbd6ec17ac72c"}]}