)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cd2082a9648b423322ce8705e9c54e48f3ab18dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f3dc4c4_80beb09e","updated":"2021-12-02 00:55:53.000000000","message":"recheck","commit_id":"97fa623438ed8d89ef9bec2c988a42dc64370356"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5dc21394be609bd3de0bd48cb4a1b3b61588d223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"90bfe618_b24efaf3","updated":"2021-12-07 19:23:24.000000000","message":"While I\u0027m okay with the change, I do *think* we\u0027re loosing out and breaking secure transport use cases of grub since it doesn\u0027t *have* to boot/use/load with tftp alone.\n\nMarking cr-1, hopefully for discussion/visibility purposes. Realistically I\u0027m +1 on the change, but think we need to consider following up for /httpboot with pxe.","commit_id":"22b20c8600f8f4404c1d28bb05083c093dd6ea15"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cb7991531d22b39b352120974ee39b43eaee3d10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4fcb9065_1a023ba7","updated":"2021-12-08 20:52:56.000000000","message":"I\u0027m going to say Dmitry\u0027s +2 still holds, only one line was added","commit_id":"241639a9dbeed05f21867566471d28dfda555a2f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a83cb581c822bf3a16e3ec5f8e7ec35a86f5cbbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15269058_71a169ad","updated":"2021-12-09 09:59:21.000000000","message":"recheck","commit_id":"241639a9dbeed05f21867566471d28dfda555a2f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"419a8391dff11325a08ec00e7af141b7b299c1e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a83d232_7595f299","updated":"2021-12-09 15:58:25.000000000","message":"recheck","commit_id":"241639a9dbeed05f21867566471d28dfda555a2f"}],"ironic/drivers/modules/ipxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8ab4496d04b1e463d9997f3a1e63eda04b1bc964","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":32,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.deploy.http_root)"},{"line_number":33,"context_line":"        # This is required to serve the iPXE binary via tftp"},{"line_number":34,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"}],"source_content_type":"text/x-python","patch_set":6,"id":"66d72aac_f7749633","line":34,"updated":"2021-12-12 16:12:12.000000000","message":"Why not move these to PXEBaseMixin?","commit_id":"45e8adc1df26f2b940603b2f85d54c0ffcfdfa66"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5dc21394be609bd3de0bd48cb4a1b3b61588d223","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    capabilities \u003d [\u0027ramdisk_boot\u0027, \u0027pxe_boot\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self):"},{"line_number":42,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class PXEAnacondaDeploy(agent_base.AgentBaseMixin, agent_base.HeartbeatMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0abae892_55d2715f","line":42,"updated":"2021-12-07 19:23:24.000000000","message":"so, we *should* likely copy to /httpboot as well. It can be used by grub and the last syslinux version.... should anyone load up such templates.","commit_id":"22b20c8600f8f4404c1d28bb05083c093dd6ea15"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dbb14fdb223a7648288bdddcc759d33db6e1bf70","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    capabilities \u003d [\u0027ramdisk_boot\u0027, \u0027pxe_boot\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self):"},{"line_number":42,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class PXEAnacondaDeploy(agent_base.AgentBaseMixin, agent_base.HeartbeatMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"756a2dc2_ae426c51","line":42,"in_reply_to":"0abae892_55d2715f","updated":"2021-12-07 20:20:33.000000000","message":"Done","commit_id":"22b20c8600f8f4404c1d28bb05083c093dd6ea15"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8ab4496d04b1e463d9997f3a1e63eda04b1bc964","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    capabilities \u003d [\u0027ramdisk_boot\u0027, \u0027pxe_boot\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self):"},{"line_number":42,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.deploy.http_root)"},{"line_number":43,"context_line":"        pxe_utils.place_loaders_for_boot(CONF.pxe.tftp_root)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"44f0d2cf_1dec43c2","line":41,"updated":"2021-12-12 16:12:12.000000000","message":"Please call super().__init__(), it\u0027s no-op now, but may be useful in the future","commit_id":"45e8adc1df26f2b940603b2f85d54c0ffcfdfa66"}]}