)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"436cb77aa48255a5343ed9e53c760c7a92b784c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76b419ad_8b9e8351","updated":"2021-12-02 00:15:11.000000000","message":"yeet it","commit_id":"5cf7102c34b517ec1ed2c1439ecc0f6de09dcdd7"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2dd5873bc138536b60e022348c679320b4469968","unresolved":true,"context_lines":[{"line_number":375,"context_line":"                         \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":376,"context_line":"            raise exception.RedfishConnectionError(node\u003dnode.uuid, error\u003de)"},{"line_number":377,"context_line":"        except sushy.exceptions.AccessError as e:"},{"line_number":378,"context_line":"            LOG.warning(\u0027For node %(node)s, we receieved an authentication \u0027"},{"line_number":379,"context_line":"                        \u0027access error from address %(address)s with auth_type \u0027"},{"line_number":380,"context_line":"                        \u0027%(auth_type)s. The client will not be re-used upon \u0027"},{"line_number":381,"context_line":"                        \u0027the next re-attempt. Please ensure your using the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1341196_f188dff0","line":378,"updated":"2021-12-06 16:20:23.000000000","message":"nit: received","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2dd5873bc138536b60e022348c679320b4469968","unresolved":true,"context_lines":[{"line_number":385,"context_line":"                         \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":386,"context_line":"            raise exception.RedfishError(node\u003dnode.uuid, error\u003de)"},{"line_number":387,"context_line":"        except AttributeError as e:"},{"line_number":388,"context_line":"            LOG.warning(\u0027For node %(node)s, we receieved at AttributeError \u0027"},{"line_number":389,"context_line":"                        \u0027when attempting to utilize the client. A new \u0027"},{"line_number":390,"context_line":"                        \u0027client session shall be used upon the next attempt.\u0027"},{"line_number":391,"context_line":"                        \u0027Error: %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f5238d1_1ad3e1fc","line":388,"updated":"2021-12-06 16:20:23.000000000","message":"nit: received","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2dd5873bc138536b60e022348c679320b4469968","unresolved":true,"context_lines":[{"line_number":388,"context_line":"            LOG.warning(\u0027For node %(node)s, we receieved at AttributeError \u0027"},{"line_number":389,"context_line":"                        \u0027when attempting to utilize the client. A new \u0027"},{"line_number":390,"context_line":"                        \u0027client session shall be used upon the next attempt.\u0027"},{"line_number":391,"context_line":"                        \u0027Error: %(error)s\u0027,"},{"line_number":392,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":393,"context_line":"            raise exception.RedfishError(node\u003dnode.uuid, error\u003de)"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"73942cf2_1681d3a4","line":391,"updated":"2021-12-06 16:20:23.000000000","message":"nit: s/Error/Missing attribute/ ?","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"70451bfcef5167c91240a7e7a69c91613c272467","unresolved":true,"context_lines":[{"line_number":388,"context_line":"            LOG.warning(\u0027For node %(node)s, we receieved at AttributeError \u0027"},{"line_number":389,"context_line":"                        \u0027when attempting to utilize the client. A new \u0027"},{"line_number":390,"context_line":"                        \u0027client session shall be used upon the next attempt.\u0027"},{"line_number":391,"context_line":"                        \u0027Error: %(error)s\u0027,"},{"line_number":392,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":393,"context_line":"            raise exception.RedfishError(node\u003dnode.uuid, error\u003de)"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d0dc7504_fa50790b","line":391,"in_reply_to":"73942cf2_1681d3a4","updated":"2021-12-06 18:02:27.000000000","message":"it should log the entire exception output, AIUI... so I think is if fine, it should log the attribute used but it is more of a symptom of another problem I guess. \"oh, something bad happened\" so we at least capture it.","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"}],"ironic/tests/unit/drivers/modules/redfish/test_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cdf8fcd30182120df2dee86de755a2d6e37c43f6","unresolved":true,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        fake_conn \u003d mock.Mock()"},{"line_number":430,"context_line":"        fake_conn.get_system.side_effect \u003d sushy.exceptions.ConnectionError()"},{"line_number":431,"context_line":"        mock_sushy.return_value \u003d fake_conn"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        self.assertRaises(exception.RedfishConnectionError,"},{"line_number":434,"context_line":"                          redfish_utils.get_system, self.node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9235b321_dbea53e5","line":431,"updated":"2021-12-02 20:52:15.000000000","message":"so yeah. This actually silently created an AttributeError which we were catching until I swapped this around.","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cdf8fcd30182120df2dee86de755a2d6e37c43f6","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    @mock.patch.object(sushy, \u0027Sushy\u0027, autospec\u003dTrue)"},{"line_number":523,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.\u0027"},{"line_number":524,"context_line":"                \u0027SessionCache._sessions\u0027, {})"},{"line_number":525,"context_line":"    def test_get_system_resource_attribute_error(self, mock_sushy):"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        fake_conn \u003d mock_sushy.return_value"},{"line_number":528,"context_line":"        fake_system \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"96804bc7_71b11868","line":525,"range":{"start_line":525,"start_character":55,"end_line":525,"end_character":65},"updated":"2021-12-02 20:52:15.000000000","message":"possible idea, we could measure the calls on mock_sushy. Maybe...","commit_id":"1439af27ba2bd31fb85369754c648a45ee9ca14b"}]}