)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dbcccfd1f0285b171916008fc4d38de5539c70e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86c2343a_c1245972","updated":"2021-12-08 11:57:04.000000000","message":"Forgot unit tests","commit_id":"880c5efdba16cf49c48a1d9a2d33229b6e93a3c5"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5d3dc726514fe24184c3ac00cdbfde62b1ff3086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8f8412be_9b753beb","updated":"2021-12-13 09:50:28.000000000","message":"Thanks, Dmitry, this is super-useful, e.g. for testing the IPA or when fast-tracking a subset of nodes within a conductor group.","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5c995504601841af95cdf0490745479dc02027a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"012a20a2_9a77ff7a","updated":"2021-12-15 13:03:26.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70bff7c713406cac5213aed81fa7949727e3d56f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"064249f4_810758e2","updated":"2021-12-14 16:23:20.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0f4ef5942e80a8f12551bff4f86d428089b270ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0aa6b60a_e939552f","updated":"2021-12-14 10:43:10.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61b02d35135ea2af93f8a7fb51eec088dc349600","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"660e07b9_e66e7c26","updated":"2021-12-14 14:45:13.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72d47dea22e33a775440b719e8803f60e819518c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b79e928_7e72b563","updated":"2021-12-14 12:16:13.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3f77b9f3f5e12d18807910d39860a07258ff7288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b804a906_c69bb020","updated":"2021-12-10 07:56:15.000000000","message":"recheck","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"}],"ironic/tests/unit/conductor/test_utils.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5d3dc726514fe24184c3ac00cdbfde62b1ff3086","unresolved":true,"context_lines":[{"line_number":1984,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":1985,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":1986,"context_line":""},{"line_number":1987,"context_line":"    def test_is_fast_track_via_driver_info(self, mock_get_power):"},{"line_number":1988,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"},{"line_number":1989,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":1990,"context_line":"        with task_manager.acquire("},{"line_number":1991,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":1992,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d True"},{"line_number":1993,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def test_is_fast_track_via_driver_info_string(self, mock_get_power):"},{"line_number":1996,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"},{"line_number":1997,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":1998,"context_line":"        with task_manager.acquire("},{"line_number":1999,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2000,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d \u0027yes\u0027"},{"line_number":2001,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    def test_is_fast_track_disabled_in_driver_info(self, mock_get_power):"},{"line_number":2004,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":2005,"context_line":"        with task_manager.acquire("},{"line_number":2006,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2007,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d False"},{"line_number":2008,"context_line":"            self.assertFalse(conductor_utils.is_fast_track(task))"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    def test_is_fast_track_disabled_in_driver_info_string(self,"},{"line_number":2011,"context_line":"                                                          mock_get_power):"},{"line_number":2012,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":2013,"context_line":"        with task_manager.acquire("},{"line_number":2014,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2015,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d \u0027false\u0027"},{"line_number":2016,"context_line":"            self.assertFalse(conductor_utils.is_fast_track(task))"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"    def test_is_fast_track_config_false(self, mock_get_power):"},{"line_number":2019,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"46c9cbde_9a447df7","line":2016,"range":{"start_line":1987,"start_character":0,"end_line":2016,"end_character":65},"updated":"2021-12-13 09:50:28.000000000","message":"Nit: how about adding a test where fast_track is set to sth unexpected, like \u0027Ture\u0027, and then confirm the exception is thrown?","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2bfde06a25c2662d2eab0d23e6e2caa630c8b3a4","unresolved":true,"context_lines":[{"line_number":1984,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":1985,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":1986,"context_line":""},{"line_number":1987,"context_line":"    def test_is_fast_track_via_driver_info(self, mock_get_power):"},{"line_number":1988,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"},{"line_number":1989,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":1990,"context_line":"        with task_manager.acquire("},{"line_number":1991,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":1992,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d True"},{"line_number":1993,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def test_is_fast_track_via_driver_info_string(self, mock_get_power):"},{"line_number":1996,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"},{"line_number":1997,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":1998,"context_line":"        with task_manager.acquire("},{"line_number":1999,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2000,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d \u0027yes\u0027"},{"line_number":2001,"context_line":"            self.assertTrue(conductor_utils.is_fast_track(task))"},{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    def test_is_fast_track_disabled_in_driver_info(self, mock_get_power):"},{"line_number":2004,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":2005,"context_line":"        with task_manager.acquire("},{"line_number":2006,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2007,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d False"},{"line_number":2008,"context_line":"            self.assertFalse(conductor_utils.is_fast_track(task))"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    def test_is_fast_track_disabled_in_driver_info_string(self,"},{"line_number":2011,"context_line":"                                                          mock_get_power):"},{"line_number":2012,"context_line":"        mock_get_power.return_value \u003d states.POWER_ON"},{"line_number":2013,"context_line":"        with task_manager.acquire("},{"line_number":2014,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":2015,"context_line":"            task.node.driver_info[\u0027fast_track\u0027] \u003d \u0027false\u0027"},{"line_number":2016,"context_line":"            self.assertFalse(conductor_utils.is_fast_track(task))"},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"    def test_is_fast_track_config_false(self, mock_get_power):"},{"line_number":2019,"context_line":"        self.config(fast_track\u003dFalse, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c24b18e_9b797e24","line":2016,"range":{"start_line":1987,"start_character":0,"end_line":2016,"end_character":65},"in_reply_to":"46c9cbde_9a447df7","updated":"2021-12-13 11:40:35.000000000","message":"Will do in a new revision or follow-up","commit_id":"2a6cdf4b249a85575017264aea20dd0148564ee3"}]}