)]}'
{"ironic/drivers/modules/ipminative.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"57087afbfd4e9a204de54df57e94e46fa7bb66de","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    info \u003d node.get(\u0027driver_info\u0027, {})"},{"line_number":52,"context_line":"    bmc_info \u003d {}"},{"line_number":53,"context_line":"    bmc_info[\u0027address\u0027] \u003d info.get(\u0027ipmi_address\u0027)"},{"line_number":54,"context_line":"    bmc_info[\u0027username\u0027] \u003d info.get(\u0027ipmi_username\u0027)"},{"line_number":55,"context_line":"    bmc_info[\u0027password\u0027] \u003d info.get(\u0027ipmi_password\u0027)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B4ZE%3D","line":53,"updated":"2014-03-22 01:35:26.000000000","message":"How about writing a helper function that converts unicode to binary and call it right after the dict lookup?","commit_id":"8c9eb91ad8ac6e40b17221d657780e4b3b6c8cbe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b0cdc7f8c16ce35592cfd422906182b61f680ed4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            \" to IPMI driver: %s.\""},{"line_number":63,"context_line":"             ) % missing_info)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # pyghmi requires non-unicode strings"},{"line_number":66,"context_line":"    for key in (\u0027username\u0027, \u0027password\u0027):"},{"line_number":67,"context_line":"        try:"},{"line_number":68,"context_line":"            bmc_info[key] \u003d six.binary_type(bmc_info[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BlYs%3D","line":65,"updated":"2014-03-25 18:37:11.000000000","message":"Hi it looks like a bug in pyghmi and it also introduce a limitation where we can\u0027t use non ASCI, so I think we need a bug ticket linked here with some TODO tag to remove this code once it\u0027s fixed in pyghmi.\n\nThe reason why pyghmi is failing is because it uses HMAC[1] from Crypto, which expects a byte string as parameter.\n\nI talked to jbjohnson and he\u0027s looking at this[2]\n\n[1] https://www.dlitz.net/software/pycrypto/api/current/Crypto.Hash.HMAC-module.html\n\n[2] https://review.openstack.org/82892","commit_id":"8c9eb91ad8ac6e40b17221d657780e4b3b6c8cbe"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"52a53bb83c636eb7e69419f5e46198aa329d445c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"             ) % missing_info)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # pyghmi \u003c\u003d 0.5.9.1 requires non-unicode credentials strings"},{"line_number":66,"context_line":"    # TODO(yuriyz): remove after next pyghmi release"},{"line_number":67,"context_line":"    for key in (\u0027username\u0027, \u0027password\u0027):"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            bmc_info[key] \u003d six.binary_type(bmc_info[key])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BaNA%3D","line":66,"updated":"2014-03-27 00:35:20.000000000","message":"This implies it will break with pyghmi \u003e0.5.9.1 ? If so we need a requirements cap on that.","commit_id":"6c0df8a8767c823c004f6cb453c6c63c90ff1e73"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"52a53bb83c636eb7e69419f5e46198aa329d445c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            bmc_info[key] \u003d six.binary_type(bmc_info[key])"},{"line_number":70,"context_line":"        except UnicodeEncodeError:"},{"line_number":71,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":72,"context_line":"                \"Non-ACSII symbols in %s.\") % key)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # get additional info"},{"line_number":75,"context_line":"    bmc_info[\u0027uuid\u0027] \u003d node.get(\u0027uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BaM4%3D","line":72,"updated":"2014-03-27 00:35:20.000000000","message":"This seems no better than the backtrace in the bug. Surely you want to encode to utf8 rather than doing a naive cast?","commit_id":"6c0df8a8767c823c004f6cb453c6c63c90ff1e73"}]}
