)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a5343a1cf22a89641eaa8adf2d4cc7f837516924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a17a2b0_296d957d","updated":"2022-01-04 15:35:35.000000000","message":"Code looks good, but a couple things\n1) Do we need to backport this?\n2) Regardless of if we need to backport this, this seems like there should be a release note so users understand there has been a fix.\n3) If there are any related bugs in storyboard, we should link to them.","commit_id":"8521e8799c2dfde7b38f4698c528d4e632d27eaa"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"46204cf9ded4529bb2f3788116a3407fdf0168d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0d33df4_d86f5974","updated":"2022-01-03 15:45:12.000000000","message":"recheck","commit_id":"8521e8799c2dfde7b38f4698c528d4e632d27eaa"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5190cd7ab912064b068f995ae35bca5157070347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"888f42be_d83b5428","in_reply_to":"7a17a2b0_296d957d","updated":"2022-01-05 09:58:55.000000000","message":"This patch is necessary for dependent patch [1] for which I haven\u0027t received any feedback yet. I\u0027m not aware if there are any existing steps that are affected by this. Also ipxe does not have same issue. So, \n\n1) Will need to backport, if backporting [1] too \n2) As there are no known released steps failing because of this, didn\u0027t add release note as it would be smth like - \u0027there might be and might not be some steps that fail to boot back to IPA when using Redfish virtual media boot\u0027. Thoughts?\n3) same as for 2)\n\n\n[1] https://review.opendev.org/c/openstack/ironic/+/823312","commit_id":"8521e8799c2dfde7b38f4698c528d4e632d27eaa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac6ff1203cac252369ee004944740a4d8afe49c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b0728d4_3a9763b5","in_reply_to":"888f42be_d83b5428","updated":"2022-02-14 22:35:00.000000000","message":"Ahh, Okay. I guess the person working closely with virutal media usage would be Dmitry, so it would be to run this past him.\n\nI guess desire to backport was the prime concern and wanted to make sure we have things appropriately labeled and a release note if so.","commit_id":"8521e8799c2dfde7b38f4698c528d4e632d27eaa"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b89a96fdfc6206135c1bbec0cc31c567c3f561d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b049738e_6b538447","updated":"2022-01-12 08:55:18.000000000","message":"recheck","commit_id":"a627fb70ea2e38cc25e55140b47f07d2ef1743cc"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d96dab9218714fcd1bc5df9f96f73057ba4a83cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f271ad9_c9a47d0d","updated":"2022-01-13 10:14:36.000000000","message":"recheck","commit_id":"e27c1c1ba2718c711f1e320030043dce4befb5bf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"57535af909ad5b15377348aab3fcc169b386a110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7fe44daa_5e1211ff","updated":"2022-01-13 12:33:24.000000000","message":"recheck","commit_id":"e27c1c1ba2718c711f1e320030043dce4befb5bf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f0f675d34681007ce3ff8937c42422c4b9e13af0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5808fa74_62b83c22","updated":"2022-02-16 16:54:46.000000000","message":"thanks for the reviews.","commit_id":"dd1cb46f2b0146524f0cb4d3579ac5c5b9a6fa45"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41e76035c9f2a18b15c4638627f94df253771ad4","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"            {\u0027node\u0027: node.uuid, \u0027hints\u0027: hints, \u0027source\u0027: source, \u0027error\u0027: e})"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"def need_prepare_ramdisk(node):"},{"line_number":1455,"context_line":"    \"\"\"Check if node needs preparing ramdisk"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"    :param node: Node to check for"}],"source_content_type":"text/x-python","patch_set":4,"id":"456c75ce_a4fac307","line":1454,"updated":"2022-02-15 19:16:04.000000000","message":"bikeshedding time! I think it belongs in drivers.utils rather than here, since it\u0027s not only deploy related.","commit_id":"fa43a785774054130f74392acdded23d6a27762f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f0f675d34681007ce3ff8937c42422c4b9e13af0","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"            {\u0027node\u0027: node.uuid, \u0027hints\u0027: hints, \u0027source\u0027: source, \u0027error\u0027: e})"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"def need_prepare_ramdisk(node):"},{"line_number":1455,"context_line":"    \"\"\"Check if node needs preparing ramdisk"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"    :param node: Node to check for"}],"source_content_type":"text/x-python","patch_set":4,"id":"65e6c451_6879b0d6","line":1454,"in_reply_to":"456c75ce_a4fac307","updated":"2022-02-16 16:54:46.000000000","message":"Done","commit_id":"fa43a785774054130f74392acdded23d6a27762f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41e76035c9f2a18b15c4638627f94df253771ad4","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"    :param node: Node to check for"},{"line_number":1458,"context_line":"    :returns: True if need to prepare ramdisk, otherwise False"},{"line_number":1459,"context_line":"    \"\"\""},{"line_number":1460,"context_line":"    # NOTE(TheJulia): If this method is being called by something"},{"line_number":1461,"context_line":"    # aside from deployment, clean and rescue, such as conductor takeover,"},{"line_number":1462,"context_line":"    # we should treat this as a no-op and move on otherwise we would"},{"line_number":1463,"context_line":"    # modify the state of the node due to virtual media operations."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff930b5_4c78841d","line":1460,"updated":"2022-02-15 19:16:04.000000000","message":"nit: \"this method\" no longer makes sense","commit_id":"fa43a785774054130f74392acdded23d6a27762f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f0f675d34681007ce3ff8937c42422c4b9e13af0","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"    :param node: Node to check for"},{"line_number":1458,"context_line":"    :returns: True if need to prepare ramdisk, otherwise False"},{"line_number":1459,"context_line":"    \"\"\""},{"line_number":1460,"context_line":"    # NOTE(TheJulia): If this method is being called by something"},{"line_number":1461,"context_line":"    # aside from deployment, clean and rescue, such as conductor takeover,"},{"line_number":1462,"context_line":"    # we should treat this as a no-op and move on otherwise we would"},{"line_number":1463,"context_line":"    # modify the state of the node due to virtual media operations."}],"source_content_type":"text/x-python","patch_set":4,"id":"c0d2d2c7_36fb9b81","line":1460,"in_reply_to":"9ff930b5_4c78841d","updated":"2022-02-16 16:54:46.000000000","message":"Done","commit_id":"fa43a785774054130f74392acdded23d6a27762f"}]}