)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"95ca4aed2c0aa6abb5c3e510381c1d1426450fb4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"clean or deploy steps rendering controllers not supporting \u0027Immediate\u0027"},{"line_number":21,"context_line":"apply time and requiring reboot. This fix handles such scenario"},{"line_number":22,"context_line":"instead of failing to create more than 1 virtual disk."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ia2ce34f09695731b0f48798f662006c4904e2223"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a048602c_6a36bb64","line":23,"updated":"2022-02-14 22:30:37.000000000","message":"Is there a storyboard entry for this?\nWill this need to be backported?","commit_id":"4097c8b7cd1a247d9e57dee7e80af569d755b474"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":20,"context_line":"clean or deploy steps rendering controllers not supporting \u0027Immediate\u0027"},{"line_number":21,"context_line":"apply time and requiring reboot. This fix handles such scenario"},{"line_number":22,"context_line":"instead of failing to create more than 1 virtual disk."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ia2ce34f09695731b0f48798f662006c4904e2223"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fb39d900_426461cb","line":23,"in_reply_to":"a048602c_6a36bb64","updated":"2022-02-17 14:18:52.000000000","message":"Added story board for more context. Should backport if anyone needs this in earlier versions.","commit_id":"4097c8b7cd1a247d9e57dee7e80af569d755b474"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"6e59e3c4c0dd9b23e2ddd1a243a3c8211718711a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"368f1b3b_543d6dee","updated":"2022-01-12 08:55:26.000000000","message":"recheck","commit_id":"80ef134c1468776e518fbb989504897746306b6a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"e661bbb7b902656440ec9df9c373fa15f913c933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3dd4c20c_d9d179d7","updated":"2022-01-12 11:33:11.000000000","message":"recheck","commit_id":"80ef134c1468776e518fbb989504897746306b6a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"208dbadb_fa86e9f1","updated":"2022-02-17 14:18:52.000000000","message":"thank you for the reviews.","commit_id":"d7d8f8754b36af4b686ce540e699fc5cb945c10c"}],"ironic/drivers/modules/redfish/raid.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."},{"line_number":713,"context_line":"        :raises: MissingParameterValue, if some parameters are missing."},{"line_number":714,"context_line":"        \"\"\""},{"line_number":715,"context_line":"        super(RedfishRAID, self).validate(task)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def validate_raid_config(self, task, raid_config):"},{"line_number":718,"context_line":"        \"\"\"Validates the given RAID configuration."}],"source_content_type":"text/x-python","patch_set":4,"id":"9666e48a_d0ac5335","line":715,"updated":"2022-02-15 19:30:35.000000000","message":"nit: the method can be removed now","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."},{"line_number":713,"context_line":"        :raises: MissingParameterValue, if some parameters are missing."},{"line_number":714,"context_line":"        \"\"\""},{"line_number":715,"context_line":"        super(RedfishRAID, self).validate(task)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def validate_raid_config(self, task, raid_config):"},{"line_number":718,"context_line":"        \"\"\"Validates the given RAID configuration."}],"source_content_type":"text/x-python","patch_set":4,"id":"74aa2107_f8c87e6a","line":715,"in_reply_to":"9666e48a_d0ac5335","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        if not raid_configs[\u0027task_monitor_uri\u0027]:"},{"line_number":1039,"context_line":"            if raid_configs.get(\u0027pending\u0027):"},{"line_number":1040,"context_line":"                if raid_configs.get(\u0027operation\u0027) \u003d\u003d \u0027create\u0027:"},{"line_number":1041,"context_line":"                    _, reboot_required \u003d self._submit_create_configuration("},{"line_number":1042,"context_line":"                        task, raid_configs.get(\u0027pending\u0027))"},{"line_number":1043,"context_line":"                else:"},{"line_number":1044,"context_line":"                    _, reboot_required \u003d self._submit_delete_configuration("}],"source_content_type":"text/x-python","patch_set":4,"id":"f168845e_20844153","line":1041,"updated":"2022-02-15 19:30:35.000000000","message":"let\u0027s not assign to _, it\u0027s used for i18n. just use [1] in the end","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        if not raid_configs[\u0027task_monitor_uri\u0027]:"},{"line_number":1039,"context_line":"            if raid_configs.get(\u0027pending\u0027):"},{"line_number":1040,"context_line":"                if raid_configs.get(\u0027operation\u0027) \u003d\u003d \u0027create\u0027:"},{"line_number":1041,"context_line":"                    _, reboot_required \u003d self._submit_create_configuration("},{"line_number":1042,"context_line":"                        task, raid_configs.get(\u0027pending\u0027))"},{"line_number":1043,"context_line":"                else:"},{"line_number":1044,"context_line":"                    _, reboot_required \u003d self._submit_delete_configuration("}],"source_content_type":"text/x-python","patch_set":4,"id":"c5f8197e_6172246a","line":1041,"in_reply_to":"f168845e_20844153","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        reboot_required \u003d False"},{"line_number":1069,"context_line":"        raid_configs \u003d {\u0027operation\u0027: \u0027create\u0027, \u0027pending\u0027: {}}"},{"line_number":1070,"context_line":"        for controller, logical_disks in ld_grouped.items():"},{"line_number":1071,"context_line":"            iter_logical_disks \u003d logical_disks.__iter__()"},{"line_number":1072,"context_line":"            for logical_disk in iter_logical_disks:"},{"line_number":1073,"context_line":"                response \u003d create_virtual_disk("},{"line_number":1074,"context_line":"                    task,"}],"source_content_type":"text/x-python","patch_set":4,"id":"69400b9e_e3945f22","line":1071,"updated":"2022-02-15 19:30:35.000000000","message":"nit: iter(logical_disks)","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        reboot_required \u003d False"},{"line_number":1069,"context_line":"        raid_configs \u003d {\u0027operation\u0027: \u0027create\u0027, \u0027pending\u0027: {}}"},{"line_number":1070,"context_line":"        for controller, logical_disks in ld_grouped.items():"},{"line_number":1071,"context_line":"            iter_logical_disks \u003d logical_disks.__iter__()"},{"line_number":1072,"context_line":"            for logical_disk in iter_logical_disks:"},{"line_number":1073,"context_line":"                response \u003d create_virtual_disk("},{"line_number":1074,"context_line":"                    task,"}],"source_content_type":"text/x-python","patch_set":4,"id":"862f25aa_7c039bee","line":1071,"in_reply_to":"69400b9e_e3945f22","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                    if \u0027task_monitor_uri\u0027 not in raid_configs:"},{"line_number":1086,"context_line":"                        raid_configs[\u0027task_monitor_uri\u0027] \u003d []"},{"line_number":1087,"context_line":"                    raid_configs[\u0027task_monitor_uri\u0027].append("},{"line_number":1088,"context_line":"                        response.task_monitor_uri)"},{"line_number":1089,"context_line":"                    reboot_required \u003d True"},{"line_number":1090,"context_line":"                    # Don\u0027t process any on this controller until these"},{"line_number":1091,"context_line":"                    # created to avoid failures where only 1 request"}],"source_content_type":"text/x-python","patch_set":4,"id":"a97d5bbe_9cdf29c5","line":1088,"updated":"2022-02-15 19:30:35.000000000","message":"nit:\n\n raid_configs.setdefault(\u0027task_monitor_uri\u0027, []).append(...)","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                    if \u0027task_monitor_uri\u0027 not in raid_configs:"},{"line_number":1086,"context_line":"                        raid_configs[\u0027task_monitor_uri\u0027] \u003d []"},{"line_number":1087,"context_line":"                    raid_configs[\u0027task_monitor_uri\u0027].append("},{"line_number":1088,"context_line":"                        response.task_monitor_uri)"},{"line_number":1089,"context_line":"                    reboot_required \u003d True"},{"line_number":1090,"context_line":"                    # Don\u0027t process any on this controller until these"},{"line_number":1091,"context_line":"                    # created to avoid failures where only 1 request"}],"source_content_type":"text/x-python","patch_set":4,"id":"2664e666_ca08af40","line":1088,"in_reply_to":"a97d5bbe_9cdf29c5","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            for logical_disk in iter_logical_disks:"},{"line_number":1096,"context_line":"                if controller not in raid_configs[\u0027pending\u0027]:"},{"line_number":1097,"context_line":"                    raid_configs[\u0027pending\u0027][controller] \u003d []"},{"line_number":1098,"context_line":"                raid_configs[\u0027pending\u0027][controller].append(logical_disk)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        node.set_driver_internal_info(\u0027raid_configs\u0027, raid_configs)"},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3d7343a5_cf7e87a3","line":1098,"updated":"2022-02-15 19:30:35.000000000","message":"similarly here","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            for logical_disk in iter_logical_disks:"},{"line_number":1096,"context_line":"                if controller not in raid_configs[\u0027pending\u0027]:"},{"line_number":1097,"context_line":"                    raid_configs[\u0027pending\u0027][controller] \u003d []"},{"line_number":1098,"context_line":"                raid_configs[\u0027pending\u0027][controller].append(logical_disk)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        node.set_driver_internal_info(\u0027raid_configs\u0027, raid_configs)"},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a04be0e_854d1985","line":1098,"in_reply_to":"3d7343a5_cf7e87a3","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                controller_id \u003d None"},{"line_number":1123,"context_line":"                if controller:"},{"line_number":1124,"context_line":"                    controller_id \u003d storage.identity"},{"line_number":1125,"context_line":"                iter_volumes \u003d storage.volumes.get_members().__iter__()"},{"line_number":1126,"context_line":"                for volume in iter_volumes:"},{"line_number":1127,"context_line":"                    if (volume.raid_type or volume.volume_type not in"},{"line_number":1128,"context_line":"                            [None, sushy.VOLUME_TYPE_RAW_DEVICE]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"d904e28d_b30ca3c6","line":1125,"updated":"2022-02-15 19:30:35.000000000","message":"nit: iter(...)","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                controller_id \u003d None"},{"line_number":1123,"context_line":"                if controller:"},{"line_number":1124,"context_line":"                    controller_id \u003d storage.identity"},{"line_number":1125,"context_line":"                iter_volumes \u003d storage.volumes.get_members().__iter__()"},{"line_number":1126,"context_line":"                for volume in iter_volumes:"},{"line_number":1127,"context_line":"                    if (volume.raid_type or volume.volume_type not in"},{"line_number":1128,"context_line":"                            [None, sushy.VOLUME_TYPE_RAW_DEVICE]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"47417dd7_8ed20061","line":1125,"in_reply_to":"d904e28d_b30ca3c6","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ec7472e57f6671259b2c7987bd3e9ce79ff595","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"                    if \u0027task_monitor_uri\u0027 not in raid_configs:"},{"line_number":1159,"context_line":"                        raid_configs[\u0027task_monitor_uri\u0027] \u003d []"},{"line_number":1160,"context_line":"                    raid_configs[\u0027task_monitor_uri\u0027].append("},{"line_number":1161,"context_line":"                        response.task_monitor_uri)"},{"line_number":1162,"context_line":"                    reboot_required \u003d True"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"        node.set_driver_internal_info(\u0027raid_configs\u0027, raid_configs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6c1a5ce8_e5e9a45a","line":1161,"updated":"2022-02-15 19:30:35.000000000","message":"similarly here","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"                    if \u0027task_monitor_uri\u0027 not in raid_configs:"},{"line_number":1159,"context_line":"                        raid_configs[\u0027task_monitor_uri\u0027] \u003d []"},{"line_number":1160,"context_line":"                    raid_configs[\u0027task_monitor_uri\u0027].append("},{"line_number":1161,"context_line":"                        response.task_monitor_uri)"},{"line_number":1162,"context_line":"                    reboot_required \u003d True"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"        node.set_driver_internal_info(\u0027raid_configs\u0027, raid_configs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"83bbd37a_1a28dbc1","line":1161,"in_reply_to":"6c1a5ce8_e5e9a45a","updated":"2022-02-17 14:18:52.000000000","message":"done","commit_id":"4420128ad90ef776fe356e6ffedd5e9c3497e929"}],"releasenotes/notes/fix-redfish-raid-onreset-workflow-bfa44de6b0263a1f.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"95ca4aed2c0aa6abb5c3e510381c1d1426450fb4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes hardware type ``redfish`` RAID interface clean and deploy steps"},{"line_number":5,"context_line":"    when creating more than 1 logical disk on RAID controllers that"},{"line_number":6,"context_line":"    require rebooting and do not allow more than 1 running task per RAID"},{"line_number":7,"context_line":"    controller. Before this fix 2nd logical disk would fail to be created or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0dd5bfb6_496c0c05","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":73},"updated":"2022-02-14 22:30:37.000000000","message":"maybe \"Fixes the ``redfish`` hardware type RAID device creation when creating more than 1 logical disk...\"\n\nUltimately, I think clean and deploy steps are redundant.","commit_id":"4097c8b7cd1a247d9e57dee7e80af569d755b474"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"062ef61f1791427fa0f7237b8254866b7569f0ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes hardware type ``redfish`` RAID interface clean and deploy steps"},{"line_number":5,"context_line":"    when creating more than 1 logical disk on RAID controllers that"},{"line_number":6,"context_line":"    require rebooting and do not allow more than 1 running task per RAID"},{"line_number":7,"context_line":"    controller. Before this fix 2nd logical disk would fail to be created or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4b250168_15e1c6f0","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":73},"in_reply_to":"0dd5bfb6_496c0c05","updated":"2022-02-17 14:18:52.000000000","message":"Done","commit_id":"4097c8b7cd1a247d9e57dee7e80af569d755b474"}]}