)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9067d5859915fa8fe517f9c37c8828be75a466ab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iRMC S5 supports virtual floppy disk till firmware version 1.25P"},{"line_number":15,"context_line":"and dropped support since 1.60P"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit handles above iRMC virtual floppy disk incompatibility."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifc198866d06e404df2cf1a91af7002023869b12a"},{"line_number":20,"context_line":"Story: #2009777"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"90b0ceb2_be285d1c","line":17,"updated":"2023-10-30 10:08:01.000000000","message":"Please provide a more detailed description of what exactly is done. The patch is quite large.","commit_id":"7ef4badf117a2dbac2acb21added83b4bf146983"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"bb13e0f18f4ed9955a682e845010be844b58206f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b9f251c_230d1716","updated":"2022-01-21 12:18:08.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7a41da3a12a44d9e16c66d1bf85ab95b6cfe7a6"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3b6ddae4799c9a251927450ed7a100815adaf7a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6cc89713_5684c589","updated":"2022-01-21 15:02:44.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7a41da3a12a44d9e16c66d1bf85ab95b6cfe7a6"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"28f2bed4af681ca1e93646aaca8d581929465b72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fddaa7cc_22acd92e","updated":"2022-01-21 13:35:21.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7a41da3a12a44d9e16c66d1bf85ab95b6cfe7a6"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7b83c2a7a56c5a63a54392701cf2988f4b96d4a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a8eb18b9_dc1859d1","updated":"2022-01-18 11:17:39.000000000","message":"recheck","commit_id":"c7a41da3a12a44d9e16c66d1bf85ab95b6cfe7a6"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"57105ec7ef34f88ca2c4c0d51462f18a699c9e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11d97502_6b0cdb3b","updated":"2022-01-24 09:03:59.000000000","message":"fujitsu-irmc-recheck","commit_id":"090264d95d4cdf7efc50c76deffa3c1de2636580"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b9892ce7eb00977c65a7eeb70cf1816b40549de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"59e10b90_17f3728b","updated":"2022-03-11 23:43:40.000000000","message":"At a minimum, lets revise the release note. Dmitry does raise a good point,but it is also forward looking aware of the services increased capabilities. Worth discussing if that makes sense to do, but I read the change as just handling a conditional, but even then it shouldn\u0027t be required or expected anymore... at least as long as the hosts being booted no longer require floppy devices to boot.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3203a69e9f8681554efd671b2d7a2c0dd31097b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"08b77282_c7897661","updated":"2022-03-14 13:24:17.000000000","message":"Hi Dmitry \u0026 Julia. Sorry for late reply. I have been interrupted by another task. I\u0027ll rethink and deal with your advice in this week. Thank you.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6054368d8e26cb7667a6eabf4e87e4ae6bb72651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"53bac869_04480577","updated":"2022-03-03 13:55:11.000000000","message":"Thanks for review, Julia and Dmitry.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"f51bae103b65a829a188554a0d2aca2eb586a495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"467f8a70_761c12b2","updated":"2022-03-03 02:18:45.000000000","message":"fujitsu-irmc-recheck","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce09dde49358621dca2082c4134418f33aaf89f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e1a97066_fc59c114","updated":"2023-06-26 14:44:12.000000000","message":"A couple minor quick things, I think.","commit_id":"ec96a36d562588fd3ec6050e080896b2509bcad3"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"4b2a66e19bc91b2ce42b82f2a27333aa4bc9b626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5e30c8b3_9bd134c4","updated":"2023-02-06 05:26:14.000000000","message":"recheck","commit_id":"ec96a36d562588fd3ec6050e080896b2509bcad3"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"04cecaa7f3a60df79884d44907b278780704a2ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c76e8a0f_2cc10cb6","updated":"2023-07-27 17:55:04.000000000","message":"Hey,\n\nI\u0027m removing the hashtag ironic-week-prio as this has actual CI failures; please re-add it once you\u0027ve had a chance to address the errors and it\u0027s ready for review again. Thanks!\n\n-Jay","commit_id":"1fdda699eca5c4360027c94b7d46d27ad9364c99"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3f401ae9a822331287a794f9380e6cdd342baca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4873e795_1a6659fb","updated":"2023-07-24 22:37:10.000000000","message":"Looks like there are some legitimate unit test failures going on:\n\nhttps://6edee3644f30dd35e19e-41e6d6e3469e76a197a78f7d5cb77442.ssl.cf1.rackcdn.com/823790/20/check/openstack-tox-py310/973b334/testr_results.html","commit_id":"1fdda699eca5c4360027c94b7d46d27ad9364c99"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"5ddd79c4dbe7d55e0f02b4cfed4c28836ac673c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b3a683b1_32b8e3bb","updated":"2023-07-31 08:18:17.000000000","message":"Thanks for comment. I apologize for slow response. I\u0027ll fix CI error soon.","commit_id":"1fdda699eca5c4360027c94b7d46d27ad9364c99"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"af879dff52f065b220c5d266fbd415422ad72c07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5f3a8c26_f160857f","updated":"2023-10-15 04:33:45.000000000","message":"recheck","commit_id":"7ef4badf117a2dbac2acb21added83b4bf146983"}],"doc/source/admin/drivers/irmc.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9e37b87e8937a217022f3c57e9041d43a9aaa37d","unresolved":true,"context_lines":[{"line_number":136,"context_line":"       If iRMC running on baremetal node doesn\u0027t support virtual floppy disk,"},{"line_number":137,"context_line":"       this should be a Glance UUID or Image Service URL."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"       - iRMC S4 supports virtual floppy disk till iRMC firmware version 9.21F"},{"line_number":140,"context_line":"         and dropped support from version 9.62F"},{"line_number":141,"context_line":"       - iRMC S5 supports virtual floppy disk till iRMC firmware version 1.25P"},{"line_number":142,"context_line":"         and dropped support from version 1.60P"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  - ``instance info/boot_iso`` property to be either boot iso"},{"line_number":145,"context_line":"    file name, Glance UUID, or Image Service URL. This is optional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"13822479_72756834","line":142,"range":{"start_line":139,"start_character":0,"end_line":142,"end_character":47},"updated":"2022-03-02 21:37:25.000000000","message":"That is an interesting gap. I guess I\u0027d rephrase this, but re-reading it, it makes sense.\n\nHonestly, I\u0027d consider noting that first support is generally deprecated (At least, this is my impression from this change.) And, also note just the version after which it is no longer functional.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6054368d8e26cb7667a6eabf4e87e4ae6bb72651","unresolved":true,"context_lines":[{"line_number":136,"context_line":"       If iRMC running on baremetal node doesn\u0027t support virtual floppy disk,"},{"line_number":137,"context_line":"       this should be a Glance UUID or Image Service URL."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"       - iRMC S4 supports virtual floppy disk till iRMC firmware version 9.21F"},{"line_number":140,"context_line":"         and dropped support from version 9.62F"},{"line_number":141,"context_line":"       - iRMC S5 supports virtual floppy disk till iRMC firmware version 1.25P"},{"line_number":142,"context_line":"         and dropped support from version 1.60P"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  - ``instance info/boot_iso`` property to be either boot iso"},{"line_number":145,"context_line":"    file name, Glance UUID, or Image Service URL. This is optional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1354c04f_3d1b7817","line":142,"range":{"start_line":139,"start_character":0,"end_line":142,"end_character":47},"in_reply_to":"13822479_72756834","updated":"2022-03-03 13:55:11.000000000","message":"Yes, there is strange version gap between the ones supporting virtual floppy disk and the other not supporting. Virtual floppy disk functionality is, in general, deprecated in recent firmware version.\n\nI\u0027ll tell just the iRMC firmware version, virtual floppy disk is deprecated.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"}],"ironic/conf/irmc.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce09dde49358621dca2082c4134418f33aaf89f7","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                      \u0027after creating virtual drives.\u0027)),"},{"line_number":132,"context_line":"    cfg.StrOpt(\u0027kernel_append_params\u0027,"},{"line_number":133,"context_line":"               # TODO(dtantsur): set to the same value as in [pxe] after Xena"},{"line_number":134,"context_line":"               default\u003d\"nofb nomodeset vga\u003dnormal\","},{"line_number":135,"context_line":"               mutable\u003dTrue,"},{"line_number":136,"context_line":"               help\u003d_(\u0027Additional kernel parameters to pass down to the \u0027"},{"line_number":137,"context_line":"                      \u0027instance kernel. These parameters can be consumed by \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"e9e80c2e_d9ea27e9","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":49},"updated":"2023-06-26 14:44:12.000000000","message":"I\u0027d set this to an empty string.\n\nnofb, I believe is long gone in the kernel command line.\nnomodeset, actually causes issues with Aspeed BMCs with the matrox 200 emulated graphics card, so we\u0027re discouraging it from being set.\nvga\u003dnormal is for grub 1.x and lilo in bios mode. Making it redundant to carry since in UEFI mode the graphics are already determined by the hardware/firmware combo before we even get to kernel booting.","commit_id":"ec96a36d562588fd3ec6050e080896b2509bcad3"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"de41912acbe9ce329d78567409567d2329f4f162","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    iso \u003d driver_utils.get_agent_iso(task.node, mode, deprecated_prefix\u003d\u0027irmc\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    if _support_virtual_fd(task.node):"},{"line_number":258,"context_line":"        # NOTE(vanou)"},{"line_number":259,"context_line":"        # If iRMC supports virtual FD, we can just use ISO on"},{"line_number":260,"context_line":"        # remote_image_share_root or fetch specified ISO from Glance."}],"source_content_type":"text/x-python","patch_set":8,"id":"a886ba8c_b01b2e3d","line":257,"updated":"2022-03-03 10:38:55.000000000","message":"I don\u0027t think this is the right change to make. Why cannot an ISO operate without the floppy disk? We use the Redfish driver in this mode quite successfully. Yes, you won\u0027t be able to inject kernel parameters, but they can just as well be pre-configured (Redfish, iDRAC-Redfish and iLO work this way).","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b9892ce7eb00977c65a7eeb70cf1816b40549de","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    iso \u003d driver_utils.get_agent_iso(task.node, mode, deprecated_prefix\u003d\u0027irmc\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    if _support_virtual_fd(task.node):"},{"line_number":258,"context_line":"        # NOTE(vanou)"},{"line_number":259,"context_line":"        # If iRMC supports virtual FD, we can just use ISO on"},{"line_number":260,"context_line":"        # remote_image_share_root or fetch specified ISO from Glance."}],"source_content_type":"text/x-python","patch_set":8,"id":"4969f723_66b3af43","line":257,"in_reply_to":"34c81281_5bf982c9","updated":"2022-03-11 23:43:40.000000000","message":"Continuity of process doesn\u0027t need to be forever moving forward. Especially since support for floppy devices has been rapidly disappearing over the past few years. The community\u0027s other options and enhanced direction are also viable, but it really comes down to what makes sense overall. Truthfully, if we ripped out all of the virtual floppy drive support, I\u0027d personally be okay with it as long as we don\u0027t try to backport that change.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6054368d8e26cb7667a6eabf4e87e4ae6bb72651","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    iso \u003d driver_utils.get_agent_iso(task.node, mode, deprecated_prefix\u003d\u0027irmc\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    if _support_virtual_fd(task.node):"},{"line_number":258,"context_line":"        # NOTE(vanou)"},{"line_number":259,"context_line":"        # If iRMC supports virtual FD, we can just use ISO on"},{"line_number":260,"context_line":"        # remote_image_share_root or fetch specified ISO from Glance."}],"source_content_type":"text/x-python","patch_set":8,"id":"dc80dbf0_172feed6","line":257,"in_reply_to":"a886ba8c_b01b2e3d","updated":"2022-03-03 13:55:11.000000000","message":"\u003e Why cannot an ISO operate without the floppy disk? We use the Redfish driver in this mode quite successfully.\nTo maintain same behavior of iRMC driver against old iRMC firmware version, this patch uses virtual ISO \u0026 virtual floppy image to do virtual media boot when iRMC firmware supports virtual floppy disk.\n\n\u003e Yes, you won\u0027t be able to inject kernel parameters, but they can just as well be pre-configured \nSorry. I\u0027m not sure the point. You mean, it\u0027s better to not use virtual floppy because of community direction around virtual media?","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61ed48f1bed8b4a362d78e0312699ac498ba8c20","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    iso \u003d driver_utils.get_agent_iso(task.node, mode, deprecated_prefix\u003d\u0027irmc\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    if _support_virtual_fd(task.node):"},{"line_number":258,"context_line":"        # NOTE(vanou)"},{"line_number":259,"context_line":"        # If iRMC supports virtual FD, we can just use ISO on"},{"line_number":260,"context_line":"        # remote_image_share_root or fetch specified ISO from Glance."}],"source_content_type":"text/x-python","patch_set":8,"id":"34c81281_5bf982c9","line":257,"in_reply_to":"dc80dbf0_172feed6","updated":"2022-03-04 15:29:22.000000000","message":"The point I\u0027m trying to make: you don\u0027t need a floppy to make a pre-created ISO to work. It looks like right now the driver will create a floppy disk and try to insert it. You\u0027re changing it to creating a new ISO from a kernel/ramdisk. There is the 3rd option: an ISO without a floppy disk. Just the ISO provided via deploy_iso/boot_iso.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce09dde49358621dca2082c4134418f33aaf89f7","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode(task.node)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        # NOTE(vanou)"},{"line_number":379,"context_line":"        # Becauase iRMC driver cannot use functions in"},{"line_number":380,"context_line":"        # drivers/modules/image_utils.py, borrow part of code"},{"line_number":381,"context_line":"        kernel_params \u003d driver_utils.get_kernel_append_params("},{"line_number":382,"context_line":"            task.node, CONF.irmc.kernel_append_params)"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"d09c77b3_0dc4fc2b","line":380,"range":{"start_line":379,"start_character":0,"end_line":380,"end_character":41},"updated":"2023-06-26 14:44:12.000000000","message":"A little more detail would help me here, since I\u0027m honestly wondering why so much of this has been copied when we attempted to keep things generic and still basically cover the  primary case of use that would have been supported by a floppy drive with the prior code.","commit_id":"ec96a36d562588fd3ec6050e080896b2509bcad3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9067d5859915fa8fe517f9c37c8828be75a466ab","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"            if not os.path.isfile(boot_iso):"},{"line_number":309,"context_line":"                msg \u003d (_(\"Boot ISO file, %(boot_iso)s, \""},{"line_number":310,"context_line":"                       \"not found for node: %(node)s.\") %"},{"line_number":311,"context_line":"                       {\u0027boot_iso\u0027: boot_iso, \u0027node\u0027: node.uuid})"},{"line_number":312,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"53ad5c76_f41cbe9c","line":310,"updated":"2023-10-30 10:08:01.000000000","message":"This is not a valid change","commit_id":"7ef4badf117a2dbac2acb21added83b4bf146983"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9067d5859915fa8fe517f9c37c8828be75a466ab","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        # Because iRMC driver uses NFS/CIFS as communication"},{"line_number":380,"context_line":"        # protocol for virtual media functionality, iRMC driver"},{"line_number":381,"context_line":"        # cannot use functions in  drivers/modules/image_utils.py."},{"line_number":382,"context_line":"        # So,I borrow part of code in drivers/modules/image_utils.py"},{"line_number":383,"context_line":"        kernel_params \u003d driver_utils.get_kernel_append_params("},{"line_number":384,"context_line":"            task.node, CONF.irmc.kernel_append_params)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"d0e600e4_cf99b661","line":382,"updated":"2023-10-30 10:08:01.000000000","message":"Absolutely -2 to this. There is a lot of work going on in these modules, nobody is going to update the code here when something changes there. Please find a way to use the common code.","commit_id":"7ef4badf117a2dbac2acb21added83b4bf146983"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9067d5859915fa8fe517f9c37c8828be75a466ab","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        # NOTE(vanou)"},{"line_number":1093,"context_line":"        # Because iRMC driver accepts file name located at iRMC driver shared"},{"line_number":1094,"context_line":"        # filesystem, validate_image_properties function in"},{"line_number":1095,"context_line":"        # drivers/modules/deploy_utils.py doesn\u0027t work"},{"line_number":1096,"context_line":"        _validate_image_properties(task, d_info)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    @METRICS.timer(\u0027IRMCVirtualMediaBoot.prepare_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3efc2def_8a5e068a","line":1095,"updated":"2023-10-30 10:08:01.000000000","message":"This is not a reason to copy the whole code here. At the very least, you\u0027ll miss any potential changes and bug fixes there. It\u0027s also very hard to review without knowing which exactly part you changed.","commit_id":"7ef4badf117a2dbac2acb21added83b4bf146983"}],"releasenotes/notes/deal-with-irmc-virtual-media-incompatibility-25f80957c8463e6d.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9e37b87e8937a217022f3c57e9041d43a9aaa37d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with deprecation of virtual floppy disk feature in specific iRMC"},{"line_number":5,"context_line":"    firmware version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d31dd960_60051b4c","line":5,"range":{"start_line":4,"start_character":5,"end_line":5,"end_character":20},"updated":"2022-03-02 21:37:25.000000000","message":"Perhaps \"Fixes ``irmc`` hardware type support of virtual media boot where iRMC firmware has been deprecated and removed.\"","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b9892ce7eb00977c65a7eeb70cf1816b40549de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with deprecation of virtual floppy disk feature in specific iRMC"},{"line_number":5,"context_line":"    firmware version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"312cddd3_f2ab35eb","line":5,"range":{"start_line":4,"start_character":5,"end_line":5,"end_character":20},"in_reply_to":"b9044902_451be3f0","updated":"2022-03-11 23:43:40.000000000","message":"Ahh yes, I didn\u0027t mention that it was floppy support which has been deprecated and removed. How about finishing what you\u0027ve suggested with this instead: \"... iRMC firmware no longer supports virtual floppy drives.\"","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6054368d8e26cb7667a6eabf4e87e4ae6bb72651","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with deprecation of virtual floppy disk feature in specific iRMC"},{"line_number":5,"context_line":"    firmware version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b9044902_451be3f0","line":5,"range":{"start_line":4,"start_character":5,"end_line":5,"end_character":20},"in_reply_to":"d31dd960_60051b4c","updated":"2022-03-03 13:55:11.000000000","message":"How about \"Fixes ``irmc`` hardware type support of virtual media boot where behavior of recent iRMC firmware is incompatible with.\"\nBecause support of virtual media in iRMC firmware isn\u0027t deprecated or removed but only virtual floppy functionality is deprecated and removed.","commit_id":"7177f0eaa31917e71ea2bcf373237e2d6108217c"}]}