)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0e1c85208a6a2017c8eadf415352203875749ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"709091ce_a83389ac","updated":"2022-01-11 02:14:07.000000000","message":"Thank you, Dmitry, for your quick feedback :-)\n\nPlease find my replies inline. I\u0027ll address you comments but would like to discuss the ideal behavior about prefix string.","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b80dc06a8da75e23073bdd39dc13c89d70b307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3cd64de9_36dba778","updated":"2022-01-26 10:29:42.000000000","message":"There was one comment about the release note which was left. Updated the patch to address that as well.","commit_id":"f9610d65e39feb823bcc1ef24cd792ce7ed1621e"}],"ironic/common/glance_service/image_service.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"49588f862a20daad5d663685d2041c02855fb3d3","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        swift_account_prefix \u003d CONF.glance.swift_account_prefix"},{"line_number":307,"context_line":"        if swift_account_prefix and not swift_account_prefix.endswith(\u0027_\u0027):"},{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c2c58f04_d9a63002","line":308,"updated":"2022-01-10 14:11:02.000000000","message":"I\u0027d say we just take the value literally and don\u0027t try to append _ (what if they use AUTH-?)","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0e1c85208a6a2017c8eadf415352203875749ab","unresolved":true,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        swift_account_prefix \u003d CONF.glance.swift_account_prefix"},{"line_number":307,"context_line":"        if swift_account_prefix and not swift_account_prefix.endswith(\u0027_\u0027):"},{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbd368c8_b2d5f651","line":308,"in_reply_to":"c2c58f04_d9a63002","updated":"2022-01-11 02:14:07.000000000","message":"This follows the implementation in swift[1] and swift enforces the prefix ends with \u0027_\u0027.\n\n[1] https://github.com/openstack/swift/blob/96b798019602054382634b9d08e3bf26de90498d/swift/common/utils.py#L561","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b80dc06a8da75e23073bdd39dc13c89d70b307","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        swift_account_prefix \u003d CONF.glance.swift_account_prefix"},{"line_number":307,"context_line":"        if swift_account_prefix and not swift_account_prefix.endswith(\u0027_\u0027):"},{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ea7d703_5f1ca495","line":308,"in_reply_to":"cbd368c8_b2d5f651","updated":"2022-01-26 10:29:42.000000000","message":"Done","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"49588f862a20daad5d663685d2041c02855fb3d3","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"},{"line_number":312,"context_line":"                              endpoint_url)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        key \u003d CONF.glance.swift_temp_url_key"}],"source_content_type":"text/x-python","patch_set":5,"id":"3096744a_9b580bbb","line":311,"updated":"2022-01-10 14:11:02.000000000","message":"Please add a unit test for a non-default prefix","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0e1c85208a6a2017c8eadf415352203875749ab","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"},{"line_number":312,"context_line":"                              endpoint_url)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        key \u003d CONF.glance.swift_temp_url_key"}],"source_content_type":"text/x-python","patch_set":5,"id":"a7a15d8c_0d54fe16","line":311,"in_reply_to":"3096744a_9b580bbb","updated":"2022-01-11 02:14:07.000000000","message":"Ack. will address this. Removing the resolved flag until I update the patch.","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b80dc06a8da75e23073bdd39dc13c89d70b307","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            swift_account_prefix \u003d \u0027%s_\u0027 % swift_account_prefix"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Strip /v1/AUTH_%(tenant_id)s, if present"},{"line_number":311,"context_line":"        endpoint_url \u003d re.sub(\u0027/v1/%s[^/]+/?$\u0027 % swift_account_prefix, \u0027\u0027,"},{"line_number":312,"context_line":"                              endpoint_url)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        key \u003d CONF.glance.swift_temp_url_key"}],"source_content_type":"text/x-python","patch_set":5,"id":"8eb04ef5_880f28f9","line":311,"in_reply_to":"a7a15d8c_0d54fe16","updated":"2022-01-26 10:29:42.000000000","message":"Done","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"}],"ironic/conf/glance.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"49588f862a20daad5d663685d2041c02855fb3d3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"               \u0027\"endpoint_url/api_version/account/container/object_id\"\u0027)),"},{"line_number":93,"context_line":"    cfg.StrOpt("},{"line_number":94,"context_line":"        \u0027swift_account_prefix\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027AUTH\u0027,"},{"line_number":96,"context_line":"        help\u003d_(\u0027The prefix added to the project uuid to determine the swift \u0027"},{"line_number":97,"context_line":"               \u0027account.\u0027)),"},{"line_number":98,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"dd0d4cd4_80472f16","line":95,"updated":"2022-01-10 14:11:02.000000000","message":"AUTH_","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b80dc06a8da75e23073bdd39dc13c89d70b307","unresolved":false,"context_lines":[{"line_number":92,"context_line":"               \u0027\"endpoint_url/api_version/account/container/object_id\"\u0027)),"},{"line_number":93,"context_line":"    cfg.StrOpt("},{"line_number":94,"context_line":"        \u0027swift_account_prefix\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027AUTH\u0027,"},{"line_number":96,"context_line":"        help\u003d_(\u0027The prefix added to the project uuid to determine the swift \u0027"},{"line_number":97,"context_line":"               \u0027account.\u0027)),"},{"line_number":98,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"e56287b9_8008b4a8","line":95,"in_reply_to":"acdaebe4_2b079bb7","updated":"2022-01-26 10:29:42.000000000","message":"Done","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0e1c85208a6a2017c8eadf415352203875749ab","unresolved":true,"context_lines":[{"line_number":92,"context_line":"               \u0027\"endpoint_url/api_version/account/container/object_id\"\u0027)),"},{"line_number":93,"context_line":"    cfg.StrOpt("},{"line_number":94,"context_line":"        \u0027swift_account_prefix\u0027,"},{"line_number":95,"context_line":"        default\u003d\u0027AUTH\u0027,"},{"line_number":96,"context_line":"        help\u003d_(\u0027The prefix added to the project uuid to determine the swift \u0027"},{"line_number":97,"context_line":"               \u0027account.\u0027)),"},{"line_number":98,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"acdaebe4_2b079bb7","line":95,"in_reply_to":"dd0d4cd4_80472f16","updated":"2022-01-11 02:14:07.000000000","message":"_ is intentionally excluded here to make this parameter consistent with swifts\u0027 resller_prefix. See my comment in image_service.py","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"}],"releasenotes/notes/swift_account_prefix-dbc9e68890bff47c.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"49588f862a20daad5d663685d2041c02855fb3d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``[glance] swift_account_prefix`` parameter has been added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fc57c54_a332965c","line":4,"updated":"2022-01-10 14:11:02.000000000","message":"Please explain why it is used.","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0e1c85208a6a2017c8eadf415352203875749ab","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``[glance] swift_account_prefix`` parameter has been added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8d220059_c7f43840","line":4,"in_reply_to":"1fc57c54_a332965c","updated":"2022-01-11 02:14:07.000000000","message":"Ack. Will address this as well.","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b80dc06a8da75e23073bdd39dc13c89d70b307","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``[glance] swift_account_prefix`` parameter has been added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"590f4f85_009683e6","line":4,"in_reply_to":"8d220059_c7f43840","updated":"2022-01-26 10:29:42.000000000","message":"Done","commit_id":"5313ca93ee2cf24982a803824c7593b45747fe26"}]}