)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9168d2309ac3c54044183416a280a67eeec2007","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"    if not disable_ramdisk:"},{"line_number":1428,"context_line":"        prepare_agent_boot(task)"},{"line_number":1429,"context_line":"    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":1430,"context_line":"    return get_async_step_return_state(task.node)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"def get_root_device_for_deploy(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac3f28f_697a6ebd","line":1430,"updated":"2022-02-03 13:53:50.000000000","message":"I don\u0027t think this will work without IPA? We use heartbeats to determine when the node is done rebooting. Cleaning will get stuck after this step.","commit_id":"69e6152ac3824aed6531ca0e820d6c1ba178f1f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a52e5b44cce29443a19fe3bda3257fad8a257ef","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"    if not disable_ramdisk:"},{"line_number":1428,"context_line":"        prepare_agent_boot(task)"},{"line_number":1429,"context_line":"    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":1430,"context_line":"    return get_async_step_return_state(task.node)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"def get_root_device_for_deploy(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"42562683_655a8f60","line":1430,"in_reply_to":"d9c11943_12fea990","updated":"2022-02-09 12:50:28.000000000","message":"Okay, I missed that some steps do not need IPA to detect reboot.","commit_id":"69e6152ac3824aed6531ca0e820d6c1ba178f1f0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a8f6a7b52d7390960996fce94deb6a5555fa400b","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"    if not disable_ramdisk:"},{"line_number":1428,"context_line":"        prepare_agent_boot(task)"},{"line_number":1429,"context_line":"    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":1430,"context_line":"    return get_async_step_return_state(task.node)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"def get_root_device_for_deploy(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"eaaedc5f_5bf17135","line":1430,"in_reply_to":"dac3f28f_697a6ebd","updated":"2022-02-03 14:07:28.000000000","message":"from my testing cleaning was successful, but I can do more testing with more steps in a cleaning. I\u0027m guessing no-one is waiting for heartbeat to check reboot or step completion. All these idrac-redfish steps so far have corresponding Redfish task that is checked in periodics and when it\u0027s done, it calls resume method, e.g., [1]\n\n[1] https://review.opendev.org/c/openstack/ironic/+/825753/1/ironic/drivers/modules/drac/management.py#600","commit_id":"69e6152ac3824aed6531ca0e820d6c1ba178f1f0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"334b430ebdfa4a21fe3e2260d8152072eb1aed35","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"    if not disable_ramdisk:"},{"line_number":1428,"context_line":"        prepare_agent_boot(task)"},{"line_number":1429,"context_line":"    manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":1430,"context_line":"    return get_async_step_return_state(task.node)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"def get_root_device_for_deploy(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9c11943_12fea990","line":1430,"in_reply_to":"eaaedc5f_5bf17135","updated":"2022-02-04 08:25:09.000000000","message":"so I can\u0027t find any fault here. These steps are completing successfully and moving to next clean step, they don\u0027t need heartbeat and never have. This is not like redfish BIOS apply_configuration that we talked about in one of the PTGs and I\u0027m not touching that.","commit_id":"69e6152ac3824aed6531ca0e820d6c1ba178f1f0"}]}