)]}'
{"ironic/common/service.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d3da132a7392c0735c147bfbe432f7c31eb6461","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"service_opts \u003d ["},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027periodic_interval\u0027,"},{"line_number":32,"context_line":"               default\u003d10,"},{"line_number":33,"context_line":"               help\u003d\u0027Max seconds to wait between periodic task loops. \u0027"},{"line_number":34,"context_line":"               \u0027If this is set too high, a periodic task may have to wait a \u0027"},{"line_number":35,"context_line":"               \u0027maximum of periodic_interval seconds before its first run.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Blbo%3D","line":32,"updated":"2014-03-25 18:16:01.000000000","message":"There is now no need to change this from the current and global default of 60s","commit_id":"7683a90d1399d07e6888840e14c1b8c771b2efd5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f18e87ee602de44d7b6ff6fa97a86e49cc68b56","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"service_opts \u003d ["},{"line_number":31,"context_line":"    cfg.IntOpt(\u0027periodic_interval\u0027,"},{"line_number":32,"context_line":"               default\u003d10,"},{"line_number":33,"context_line":"               help\u003d\u0027Max seconds to wait between periodic task loops. \u0027"},{"line_number":34,"context_line":"               \u0027If this is set too high, a periodic task may have to wait a \u0027"},{"line_number":35,"context_line":"               \u0027maximum of periodic_interval seconds before its first run.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BlYU%3D","line":32,"in_reply_to":"AAAAWH%2F%2Blbo%3D","updated":"2014-03-25 18:20:02.000000000","message":"Done","commit_id":"7683a90d1399d07e6888840e14c1b8c771b2efd5"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d3da132a7392c0735c147bfbe432f7c31eb6461","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.IntOpt(\u0027periodic_interval\u0027,"},{"line_number":32,"context_line":"               default\u003d10,"},{"line_number":33,"context_line":"               help\u003d\u0027Max seconds to wait between periodic task loops. \u0027"},{"line_number":34,"context_line":"               \u0027If this is set too high, a periodic task may have to wait a \u0027"},{"line_number":35,"context_line":"               \u0027maximum of periodic_interval seconds before its first run.\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":37,"context_line":"               default\u003dsocket.getfqdn(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Blak%3D","line":34,"updated":"2014-03-25 18:16:01.000000000","message":"After rebasing this patch on top of https://review.openstack.org/#/c/81524/, this statement is factually incorrect.\n\nAlso, please avoid changing the doc string during feature freeze unless absolutely necessary (which IMO it\u0027s not).","commit_id":"7683a90d1399d07e6888840e14c1b8c771b2efd5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f18e87ee602de44d7b6ff6fa97a86e49cc68b56","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.IntOpt(\u0027periodic_interval\u0027,"},{"line_number":32,"context_line":"               default\u003d10,"},{"line_number":33,"context_line":"               help\u003d\u0027Max seconds to wait between periodic task loops. \u0027"},{"line_number":34,"context_line":"               \u0027If this is set too high, a periodic task may have to wait a \u0027"},{"line_number":35,"context_line":"               \u0027maximum of periodic_interval seconds before its first run.\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":37,"context_line":"               default\u003dsocket.getfqdn(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BlYQ%3D","line":34,"in_reply_to":"AAAAWH%2F%2Blak%3D","updated":"2014-03-25 18:20:02.000000000","message":"Done","commit_id":"7683a90d1399d07e6888840e14c1b8c771b2efd5"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6d3da132a7392c0735c147bfbe432f7c31eb6461","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def start(self):"},{"line_number":51,"context_line":"        super(PeriodicService, self).start()"},{"line_number":52,"context_line":"        admin_context \u003d context.RequestContext(\u0027admin\u0027, \u0027admin\u0027, is_admin\u003dTrue)"},{"line_number":53,"context_line":"        self.tg.add_dynamic_timer("},{"line_number":54,"context_line":"                self.manager.periodic_tasks,"},{"line_number":55,"context_line":"                periodic_interval_max\u003dcfg.CONF.periodic_interval,"},{"line_number":56,"context_line":"                context\u003dadmin_context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Blbc%3D","line":53,"updated":"2014-03-25 18:16:01.000000000","message":"Yes! This was the problem - -thanks for finding it!","commit_id":"7683a90d1399d07e6888840e14c1b8c771b2efd5"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a764fa36c56597ea3c4843a68149e25db8d693db","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def setUp(self):"},{"line_number":50,"context_line":"        super(ManagerTestCase, self).setUp()"},{"line_number":51,"context_line":"        self.hostname \u003d \u0027test-host\u0027"},{"line_number":52,"context_line":"        self.config(heartbeat_timeout\u003d90, group\u003d\u0027conductor\u0027)"},{"line_number":53,"context_line":"        self.service \u003d manager.ConductorManager(self.hostname, \u0027test-topic\u0027)"},{"line_number":54,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":55,"context_line":"        self.dbapi \u003d dbapi.get_instance()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Bo0w%3D","line":52,"updated":"2014-03-25 11:38:53.000000000","message":"\"heartbeat_timeout\" option used only in get_active_driver_dict() dbapi method, IMO this line not needed here. Unit tests passed w/o this.","commit_id":"4e80dd43ab36bb47ad1b4326049d4d9e432d578e"}]}