)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"325dfaba044c24c2a5cc32cfcf8468d178c81e53","unresolved":false,"context_lines":[{"line_number":24,"context_line":"init_host permits - and as there are no API calls needed for"},{"line_number":25,"context_line":"correct behaviour of the Ironic driver, this is straight forward :)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"See https://etherpad.openstack.org/p/ironic-nova-friction for"},{"line_number":28,"context_line":"more discussion."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I68d46c4da8715df03c3a88393b55665dc57045a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAWH%2F%2BmOQ%3D","line":27,"updated":"2014-03-25 17:08:18.000000000","message":"I\u0027d rather have a link to a blueprint or bug here - I think etherpads are too ephemeral for commit messages and code.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"be6db2a5cc22f38994cc0c2bbd4ce516bc015376","unresolved":false,"context_lines":[{"line_number":24,"context_line":"init_host permits - and as there are no API calls needed for"},{"line_number":25,"context_line":"correct behaviour of the Ironic driver, this is straight forward :)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"See https://etherpad.openstack.org/p/ironic-nova-friction for"},{"line_number":28,"context_line":"more discussion."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I68d46c4da8715df03c3a88393b55665dc57045a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAWH%2F%2BkX8%3D","line":27,"in_reply_to":"AAAAWH%2F%2BmOQ%3D","updated":"2014-03-25 20:53:31.000000000","message":"I can just delete the etherpad if the link is a problem; all the needed information is in the body of the commit. A blueprint won\u0027t capture discussion, so there is no value linking this to a blueprint.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"init_host permits - and as there are no API calls needed for"},{"line_number":25,"context_line":"correct behaviour of the Ironic driver, this is straight forward :)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"See https://etherpad.openstack.org/p/ironic-nova-friction for"},{"line_number":28,"context_line":"more discussion."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I68d46c4da8715df03c3a88393b55665dc57045a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAWH%2F%2BkU8%3D","line":27,"updated":"2014-03-25 20:55:07.000000000","message":"I agree with Jim\u0027s sentiment in the last patchset that having this tied to a BP or a bug with the details is better than referencing an etherpad which may not exist when someone is looking into this in the future.","commit_id":"c78c6b1e150477af641f9eebd0726deaa2e2339e"}],"ironic/nova/compute/__init__.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"cb54a2ec5fe959bee096580f85bc3df3a585edd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BtXg%3D","line":1,"updated":"2014-03-24 22:39:49.000000000","message":"copyright headers in empty __init__ files are discouraged.","commit_id":"23f0cad0c768ffb6ca2ae0af91e57b27ef5969bd"}],"ironic/nova/compute/manager.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"cb54a2ec5fe959bee096580f85bc3df3a585edd7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\"Initialization for a clustered compute service.\"\"\""},{"line_number":33,"context_line":"        self.driver.init_host(host\u003dself.host)"},{"line_number":34,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":35,"context_line":"        instances \u003d instance_obj.InstanceList.get_by_host("},{"line_number":36,"context_line":"            context, self.host, expected_attrs\u003d[\u0027info_cache\u0027])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # defer_iptables_apply is moot for clusters - no local iptables"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BtWk%3D","line":35,"updated":"2014-03-24 22:39:49.000000000","message":"this instances object is not being used anywhere, so there\u0027s no need to create it.","commit_id":"23f0cad0c768ffb6ca2ae0af91e57b27ef5969bd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"325dfaba044c24c2a5cc32cfcf8468d178c81e53","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Short term workaround for friction in the Nova compute manager with  Ironic."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"https://etherpad.openstack.org/p/ironic-nova-friction contains current design"},{"line_number":22,"context_line":"work. The goal here is to generalise the areas where n-c talking to a clustered"},{"line_number":23,"context_line":"hypervisor has issues, and long term fold them into the main ComputeManager."},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BmOE%3D","line":21,"updated":"2014-03-25 17:08:18.000000000","message":"I\u0027d rather have a link to a blueprint or bug here - I think etherpads are too ephemeral for commit messages and code.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"be6db2a5cc22f38994cc0c2bbd4ce516bc015376","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Short term workaround for friction in the Nova compute manager with  Ironic."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"https://etherpad.openstack.org/p/ironic-nova-friction contains current design"},{"line_number":22,"context_line":"work. The goal here is to generalise the areas where n-c talking to a clustered"},{"line_number":23,"context_line":"hypervisor has issues, and long term fold them into the main ComputeManager."},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BkXo%3D","line":21,"in_reply_to":"AAAAWH%2F%2BmOE%3D","updated":"2014-03-25 20:53:31.000000000","message":"There isn\u0027t a formalised blueprint yet, so thats impossible. Etherpads have more longevity than blueprints which have no changelog.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a8879e88d799c7c92dce04329174d222f0c05a7b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            # defer_iptables_apply is moot for clusters - no local iptables"},{"line_number":58,"context_line":"            # if CONF.defer_iptables_apply:"},{"line_number":59,"context_line":"            #     self.driver.filter_defer_apply_off()"},{"line_number":60,"context_line":"            pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def pre_start_hook(self):"},{"line_number":63,"context_line":"        \"\"\"After the service is initialized, but before we fully bring"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2Bl3M%3D","line":60,"updated":"2014-03-25 17:30:25.000000000","message":"Can we comment out this whole try...finally block? I understand it\u0027s intent to be a short term fix, but it just looks very odd to have a try...finally block that does nothing but only pass.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"be6db2a5cc22f38994cc0c2bbd4ce516bc015376","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            # defer_iptables_apply is moot for clusters - no local iptables"},{"line_number":58,"context_line":"            # if CONF.defer_iptables_apply:"},{"line_number":59,"context_line":"            #     self.driver.filter_defer_apply_off()"},{"line_number":60,"context_line":"            pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def pre_start_hook(self):"},{"line_number":63,"context_line":"        \"\"\"After the service is initialized, but before we fully bring"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BkXc%3D","line":60,"in_reply_to":"AAAAWH%2F%2Bl3M%3D","updated":"2014-03-25 20:53:31.000000000","message":"Sure.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"5607be6e9937339d04963058573fbaf130422193","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # directly."},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.update_available_resource(nova.context.get_admin_context())"},{"line_number":75,"context_line":"        except:"},{"line_number":76,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BkjM%3D","line":75,"updated":"2014-03-25 20:26:23.000000000","message":"prefer except Exception:\n\nBut I\u0027m not sure this is necessary. The only possible errors here would be from Ironic not being ready... but retries are being added for that.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"be6db2a5cc22f38994cc0c2bbd4ce516bc015376","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # directly."},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.update_available_resource(nova.context.get_admin_context())"},{"line_number":75,"context_line":"        except:"},{"line_number":76,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BkXA%3D","line":75,"in_reply_to":"AAAAWH%2F%2BkjM%3D","updated":"2014-03-25 20:53:31.000000000","message":"In 2.5? + bare excepts no longer catch SystemExit or KeyboardInterrupt, so bare excepts are actually safe. E.g. its safe here.","commit_id":"1c37a1890ca67c3e5156be8d9f445f9f52660354"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Short term workaround for friction in the Nova compute manager with  Ironic."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"https://etherpad.openstack.org/p/ironic-nova-friction contains current design"},{"line_number":22,"context_line":"work. The goal here is to generalise the areas where n-c talking to a clustered"},{"line_number":23,"context_line":"hypervisor has issues, and long term fold them into the main ComputeManager."},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BkUk%3D","line":21,"updated":"2014-03-25 20:55:07.000000000","message":"Again, can we summarize this info into a bug or bp so it\u0027s got a bit more permeance?","commit_id":"c78c6b1e150477af641f9eebd0726deaa2e2339e"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"efce361f3d2cb665584eb95db4a8006c0fc1a243","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # This is an optimisation to immediately advertise resources but"},{"line_number":67,"context_line":"        # the periodic task will update them eventually anyway, so ignore"},{"line_number":68,"context_line":"        # errors as they may be transient (e.g. the scheduler isn\u0027t"},{"line_number":69,"context_line":"        # available...). XXX(lifeless) this applies to all ComputeManagers"},{"line_number":70,"context_line":"        # and once I feature freeze is over we should push that to nova"},{"line_number":71,"context_line":"        # directly."},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2Bj3U%3D","line":69,"updated":"2014-03-25 22:04:58.000000000","message":"I left this in past patch set.. but you were probably focused on my awful idea. :)  I don\u0027t see the need for this?  The scheduler doesn\u0027t come into play at all here and there will be retries on any of the Ironic calls.\n\nThe DB could be down, but then we probably wouldn\u0027t have made it to this point anyway.\n\nThis doesn\u0027t really hurt anything, so it\u0027s not a big deal... although the comment about the scheduler bugs me because it\u0027s not accurate. :)","commit_id":"4a803d1106f71a1a4872229115d13573a4368bac"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"4bbce2bc7cdb3ee6b2ab26371ef433705020f5f8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # This is an optimisation to immediately advertise resources but"},{"line_number":67,"context_line":"        # the periodic task will update them eventually anyway, so ignore"},{"line_number":68,"context_line":"        # errors as they may be transient (e.g. the scheduler isn\u0027t"},{"line_number":69,"context_line":"        # available...). XXX(lifeless) this applies to all ComputeManagers"},{"line_number":70,"context_line":"        # and once I feature freeze is over we should push that to nova"},{"line_number":71,"context_line":"        # directly."},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2Bjcg%3D","line":69,"in_reply_to":"AAAAWH%2F%2Bj3U%3D","updated":"2014-03-25 23:24:21.000000000","message":"The function called gathers resources and advertises them. The DB-less scheduler does that directly via RPC. The DB based one via the DB.","commit_id":"4a803d1106f71a1a4872229115d13573a4368bac"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"77a662a943a2a48da04904dc785f38bea7a410f4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # This is an optimisation to immediately advertise resources but"},{"line_number":67,"context_line":"        # the periodic task will update them eventually anyway, so ignore"},{"line_number":68,"context_line":"        # errors as they may be transient (e.g. the scheduler isn\u0027t"},{"line_number":69,"context_line":"        # available...). XXX(lifeless) this applies to all ComputeManagers"},{"line_number":70,"context_line":"        # and once I feature freeze is over we should push that to nova"},{"line_number":71,"context_line":"        # directly."},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2Bi8I%3D","line":69,"in_reply_to":"AAAAWH%2F%2Bjcg%3D","updated":"2014-03-26 01:36:30.000000000","message":"Ah, but there is no DB-less scheduler. :)  Any speculation on how it might work would be just that.. speculation. But fair enough.","commit_id":"4a803d1106f71a1a4872229115d13573a4368bac"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"efce361f3d2cb665584eb95db4a8006c0fc1a243","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # directly."},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            self.update_available_resource(nova.context.get_admin_context())"},{"line_number":74,"context_line":"        except Exception:"},{"line_number":75,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2Bj3I%3D","line":74,"updated":"2014-03-25 22:04:58.000000000","message":"Ah, maybe you did see my comment!","commit_id":"4a803d1106f71a1a4872229115d13573a4368bac"}]}
