)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"1db3cbaab55de6095b12728ffc10c8a8dae386e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ae2d067_a82741a0","updated":"2022-01-27 09:22:33.000000000","message":"fujitsu-irmc-recheck","commit_id":"631300f785f92d63e6d0cf02aa3a9cece800875e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"633216876bfdbd2e0ec2584df29bb7e4f07b6476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6827cef3_99a06237","updated":"2022-01-28 06:03:48.000000000","message":"fujitsu-irmc-recheck","commit_id":"631300f785f92d63e6d0cf02aa3a9cece800875e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"5ad583a7aebdd270445aaecd2cd8030714fbf0b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a2374a7_85af2783","updated":"2022-01-27 06:47:29.000000000","message":"fujitsu-irmc-recheck","commit_id":"631300f785f92d63e6d0cf02aa3a9cece800875e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"8ac7896b8a88e161abb500fb46c8ff23d1d7187d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0a4e617_5badacac","updated":"2022-01-28 02:39:19.000000000","message":"fujitsu-irmc-recheck","commit_id":"631300f785f92d63e6d0cf02aa3a9cece800875e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"9644b131b69730c7c0415b42d12089d7cf60e505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0954973f_f85bfc4e","updated":"2022-01-28 23:08:49.000000000","message":"fujitsu-irmc-recheck","commit_id":"bba5db823a9a95923da428c42fa6f0ca82a10f48"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3e2063196b427255301ae07585411c5438dfdb94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"275de148_363eb66e","updated":"2022-02-03 18:23:48.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"58a2153d93ae6ca11a5db509051ae780699d74c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41947685_f5c99c3c","updated":"2022-02-03 08:44:09.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6d91f4c9c69f8a9772ada7bb631b38d5c1b107b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72ceec98_0d75bf86","updated":"2022-02-03 09:21:27.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"59e935c084f04ba9b8a09706427e2e3466078fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76a09e30_2b042e37","updated":"2022-02-04 13:53:49.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"ed877914654719650b62146720d5d44a27ca9f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"77693db0_813eb68a","updated":"2022-01-31 05:55:02.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"2da0065e311127c5a90a693fb26c372db36b39ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad2ffe84_a8044eef","updated":"2022-01-31 07:50:08.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"9743effe7f446433d1ccc209536ccb088c0c6539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af32919e_83aaa46c","updated":"2022-02-04 12:52:57.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6802d3c3943110d974b24c6d1229afa4b442d960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"caa9ddaf_f724f446","updated":"2022-02-05 00:03:16.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"77d2b226a0250ef5743cd030e0e6c97e4017ce4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fc050396_ddf52963","updated":"2022-02-03 08:31:36.000000000","message":"fujitsu-irmc-recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"383d3598f731ee5f69f8e2413ec5a09fa5951743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd08385a_3fbfab2f","updated":"2022-01-31 08:21:32.000000000","message":"recheck","commit_id":"0775f673093d0cf0767af84081dbf87b2433fcbf"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3d7051357f7d0ef81796c2be3b71414237c55bde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"218e33be_7ae46698","updated":"2022-02-09 23:10:29.000000000","message":"Hello Dmitry. Could you review this? Or should I propose this in next Ironic weekly meeting?\nWithout this patch, virtual media boot will always fail.","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"4714cf049f267b581be189820c6a390571660cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"75f989e0_ecee5097","updated":"2022-02-05 05:43:15.000000000","message":"fujitsu-irmc-recheck","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e26279083e1a2a035ceea645763b4361930d470f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a81a8399_ec2d525b","updated":"2022-02-07 01:57:16.000000000","message":"fujitsu-irmc-recheck","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"190a9e7e09d5235458e394cad5af652ace98ce32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbac447e_f666f92a","updated":"2022-02-06 22:49:05.000000000","message":"fujitsu-irmc-recheck","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"62fd7a69fb29c7d81b8faa870bf3f92692e05943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f0278cc1_edd04791","updated":"2022-02-05 03:59:41.000000000","message":"fujitsu-irmc-recheck","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"48c2cf17692c8f6dcc5a529102d0ef08888c15f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b437fdd_4402ebfe","in_reply_to":"218e33be_7ae46698","updated":"2022-02-10 00:13:19.000000000","message":"Sorry. Without this patch, virtual media boot which uses both virtual FD \u0026 virtual CD will always fail .","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"9cb74536bcac5f03fb47790a28e174c1be5710c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0285e315_18e7cf88","in_reply_to":"6b437fdd_4402ebfe","updated":"2022-03-02 10:37:47.000000000","message":"Done","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"5708ca2384f87de89b357957dd3b0da334729fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c0aafb81_6b9be2ec","updated":"2022-02-18 00:31:01.000000000","message":"Thanks Dmitry for review. I dealt with your comment. I appreciate if you check this.","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"21f0961b70c4fd7ed67c4aaa07d06f4a88be24ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1025452b_413c0526","updated":"2022-02-11 13:44:50.000000000","message":"fujitsu-irmc-recheck","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"9d22cfce838901c19924eeeaea87cd571b921988","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32c2a2c4_9dcc819e","updated":"2022-02-11 11:47:02.000000000","message":"fujitsu-irmc-recheck","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"d94335d16c4a67ef5cacfb02d858badd692e0bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5474cbea_11046a92","updated":"2022-02-11 08:02:35.000000000","message":"fujitsu-irmc-recheck","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b521ce1c81aabf55400eca0c515d9dea2d2cefc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0a426887_58bb89ed","updated":"2022-02-21 16:24:11.000000000","message":"lgtm but please add a release note, thanks!","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"f862b883d95ced6720dc32f8d07a374c37c272c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6060794b_778a0500","updated":"2022-02-11 05:29:12.000000000","message":"recheck","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3a2702e1f8e3dbbc490b21732cdd0836a65e11b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a8a18f69_182931dc","in_reply_to":"0a426887_58bb89ed","updated":"2022-02-22 12:53:23.000000000","message":"Thank you Riccardo for review. I have a question. This commit fixes problem in another commit (c3805b2bea404cf6b831a3262e2602db72324616) and that commit (c3805) is merged in this yoga development cycle.\nI\u0027m not sure I should add release note to my commit. In same development cycle,  commit c3805 put wrong code and this commit fixes it.\nIf these two commits are merged in different release cycles, it\u0027s make sense for me to add release note to this commit.","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"de3037cf014e58286d159607e2e0f78c0f68f9e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b9c16285_18f6c3ad","in_reply_to":"3e70dd10_3f1bd391","updated":"2022-03-02 01:14:49.000000000","message":"Thank you Riccardo for reply. Don\u0027t worry :) I would like to thank your review with kindness!\nI\u0027ll remove release note.","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"82e60db3d2c72414cd32b7d6e34658d9a9cf0a24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3e70dd10_3f1bd391","in_reply_to":"a8a18f69_182931dc","updated":"2022-03-01 09:21:49.000000000","message":"sorry Vanou, I didn\u0027t realize the fixed code was in the same cycle :/\nin this case we don\u0027t need a release note\nI will approve once it\u0027s removed, apologies again","commit_id":"b35ac42b6ad9a1c582ac100b19ec55c46f273194"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7dd3bdacf89f1e7c4a2cd5c0acf727a63c3254fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bbdecc12_077f8933","updated":"2022-02-28 22:17:58.000000000","message":"recheck","commit_id":"129e3e6bcac8ddb8e7748cac00533393663516dc"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"375dadd5db9c29fd7a65cdb7ef975ff5e38e03e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"25920329_6107602d","updated":"2022-03-02 03:54:45.000000000","message":"recheck","commit_id":"e5e8e3cd5421431a3a51a5a0e87f29fcac28cd4f"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"301fb4d5d59156e270f593e6e7a40a5b1a829ef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ab755982_5c8cb46e","updated":"2022-03-02 05:30:41.000000000","message":"recheck","commit_id":"e5e8e3cd5421431a3a51a5a0e87f29fcac28cd4f"}],"ironic/common/images.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8b329324031bbe80a60f46a28ec8698da03efb1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                file_contents \u003d \u0027\\n\u0027.join(params_list)"},{"line_number":137,"context_line":"                utils.write_to_file(parameters_file, file_contents)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            file_lists \u003d os.listdir(tmpdir)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"            if not file_lists:"},{"line_number":142,"context_line":"                # No files to be written to fat fs"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af26142_ec0e36f1","line":139,"updated":"2022-02-10 13:20:29.000000000","message":"nit: file_list","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8b329324031bbe80a60f46a28ec8698da03efb1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            file_lists \u003d os.listdir(tmpdir)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"            if not file_lists:"},{"line_number":142,"context_line":"                # No files to be written to fat fs"},{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            for i in range(len(file_lists)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec89bc93_c62d0fa5","line":142,"updated":"2022-02-10 13:20:29.000000000","message":"nit: this should be self-explanatory","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8b329324031bbe80a60f46a28ec8698da03efb1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            for i in range(len(file_lists)):"},{"line_number":146,"context_line":"                file_lists[i] \u003d os.path.join(tmpdir, file_lists[i])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            file_paths \u003d \u0027 \u0027.join(file_lists)"},{"line_number":149,"context_line":"            # use mtools to copy the files into the image in a single"}],"source_content_type":"text/x-python","patch_set":5,"id":"b6a13bd3_d4a21a6e","line":146,"updated":"2022-02-10 13:20:29.000000000","message":"nit:\n\n file_lists \u003d [os.path.join(tmpdir, item) for item in file_list]","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8b329324031bbe80a60f46a28ec8698da03efb1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            file_paths \u003d \u0027 \u0027.join(file_lists)"},{"line_number":149,"context_line":"            # use mtools to copy the files into the image in a single"},{"line_number":150,"context_line":"            # operation"},{"line_number":151,"context_line":"            utils.execute(\u0027mcopy\u0027, \u0027-s\u0027, \u0027%s\u0027 % file_paths,"},{"line_number":152,"context_line":"                          \u0027-i\u0027, output_file, \u0027::\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"38d40b63_87487f14","line":151,"updated":"2022-02-10 13:20:29.000000000","message":"\u0027%s\u0027 % file_paths is a meanignless operation, it\u0027s making a string out of a string. also I\u0027d rather not join arguments this way, probably better would be to do:\n\n utils.execute(\u0027mcopy\u0027, \u0027-s\u0027, *file_list, \u0027-i\u0027, output_file, \u0027::\u0027)","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"}],"ironic/tests/unit/common/test_images.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8b329324031bbe80a60f46a28ec8698da03efb1","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        parameters \u003d {\u0027p1\u0027: \u0027v1\u0027}"},{"line_number":312,"context_line":"        files_info \u003d {\u0027a\u0027: \u0027b\u0027}"},{"line_number":313,"context_line":"        os_listdir_mock.return_value \u003d [\u0027/tempdir/b\u0027, \u0027/tempdir/qwe\u0027]"},{"line_number":314,"context_line":"        images.create_vfat_image(\u0027tgt_file\u0027, parameters\u003dparameters,"},{"line_number":315,"context_line":"                                 files_info\u003dfiles_info, parameters_file\u003d\u0027qwe\u0027,"},{"line_number":316,"context_line":"                                 fs_size_kib\u003d1000)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ddeac7c_bfe5453a","line":313,"updated":"2022-02-10 13:20:29.000000000","message":"listdir should not return absolute paths","commit_id":"d811fa7b7cac7e03105b7520c552828d522c226b"}]}