)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"017c0ada49e549addc053ba00c6206a7fa9f37bd","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                                 sort_key\u003dsort_key,"},{"line_number":198,"context_line":"                                                 sort_dir\u003dsort_dir)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _get_port_by_address(self, address):"},{"line_number":201,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :returns: a list with the port, or an empty list if no port is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bi90%3D","line":200,"updated":"2014-03-26 01:35:14.000000000","message":"I agree that this function should be named _get_ports_by_address (plural naming), even if it\u0027s always a list with one port. In context, makes sense to return a list.","commit_id":"897300b4eba486946b9ae2748cdc92bbb94f354d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e07ea82e9accc7b922a72c417cca5b5352a28b17","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                                 sort_key\u003dsort_key,"},{"line_number":198,"context_line":"                                                 sort_dir\u003dsort_dir)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _get_port_by_address(self, address):"},{"line_number":201,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :returns: a list with the port, or an empty list if no port is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9xZM%3D","line":200,"in_reply_to":"AAAAWH%2F%2Bi90%3D","updated":"2014-04-02 08:37:47.000000000","message":"+1 I will fix it","commit_id":"897300b4eba486946b9ae2748cdc92bbb94f354d"},{"author":{"_account_id":10626,"name":"Russell Haering","email":"russellhaering@gmail.com","username":"russell_h"},"change_message_id":"388d8df8d4f273c2ebb9a3e609bade9ce54ce88d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def _get_port_by_address(self, address):"},{"line_number":201,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bjv0%3D","line":203,"updated":"2014-03-25 22:24:06.000000000","message":"IMO this method is either incorrectly named or has the wrong return type. My inclination is that it should return a single port or raise a PortNotFound, and you wrap that up one level up.","commit_id":"897300b4eba486946b9ae2748cdc92bbb94f354d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e07ea82e9accc7b922a72c417cca5b5352a28b17","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def _get_port_by_address(self, address):"},{"line_number":201,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9xZA%3D","line":203,"in_reply_to":"AAAAWH%2F%2Bjv0%3D","updated":"2014-04-02 08:37:47.000000000","message":"I\u0027ll rename the method","commit_id":"897300b4eba486946b9ae2748cdc92bbb94f354d"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"99199e4bd076ae67c8b9bd4f07b7f32c4650a709","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_ports_by_address(self, address):"},{"line_number":197,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9Yj0%3D","line":198,"updated":"2014-04-04 22:10:37.000000000","message":"doc string missing address param\n(i know it\u0027s a private method, but you\u0027ve got a doc string alraedy, it\u0027s just incorrect)","commit_id":"254429b311f09cd760344913655d18291a65b916"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee603534fca1d19202a4b1c31d0544c621609167","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_ports_by_address(self, address):"},{"line_number":197,"context_line":"        \"\"\"Retrieve a port by its address."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9TRo%3D","line":198,"in_reply_to":"AAAAWH%2F9Yj0%3D","updated":"2014-04-07 09:13:41.000000000","message":"ah thanks, right will fix","commit_id":"254429b311f09cd760344913655d18291a65b916"}]}
