)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"aa21eb36e53902d318fa9fa103d3178f2d191056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56755887_2ed86a8a","updated":"2022-03-16 11:07:18.000000000","message":"Thank you for your suggestions Arne. Uploading a revised version.","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"846b6c73ea5f52cfea85523b5f557e8cc5ae229d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9aff166f_98ec9fdf","updated":"2022-03-16 11:02:46.000000000","message":"Thanks, Jacob. Typo corrections and suggestions inline.","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"437ba66feef9d416ab7b24775c3d4c45b101b2aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31b5d295_09e94b02","updated":"2022-03-16 11:11:53.000000000","message":"Thanks, Jacob, LGTM!","commit_id":"687694c83ccd61371cf89816ef7602ae9fed0dd0"}],"doc/source/admin/cleaning.rst":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"846b6c73ea5f52cfea85523b5f557e8cc5ae229d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"``[deploy]/continue_if_disk_secure_erase_fails`` is set to ``True``, cleaning"},{"line_number":87,"context_line":"will fall back to using ``shred`` to overwrite the contents of the device."},{"line_number":88,"context_line":"Otherwise cleaning will fail. It is important to note that ``erase_devices``"},{"line_number":89,"context_line":"make take a very long time (hours or even days) to complete, unless fast,"},{"line_number":90,"context_line":"hardware assisted data erasure is supported by all the devices in a system."},{"line_number":91,"context_line":"Generally, it is very difficult (if possible at all) to recover data after"},{"line_number":92,"context_line":"performing cleaning with ``erase_devices``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"32c5ff54_8feeef50","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":4},"updated":"2022-03-16 11:02:46.000000000","message":"nit: may","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"aa21eb36e53902d318fa9fa103d3178f2d191056","unresolved":false,"context_lines":[{"line_number":86,"context_line":"``[deploy]/continue_if_disk_secure_erase_fails`` is set to ``True``, cleaning"},{"line_number":87,"context_line":"will fall back to using ``shred`` to overwrite the contents of the device."},{"line_number":88,"context_line":"Otherwise cleaning will fail. It is important to note that ``erase_devices``"},{"line_number":89,"context_line":"make take a very long time (hours or even days) to complete, unless fast,"},{"line_number":90,"context_line":"hardware assisted data erasure is supported by all the devices in a system."},{"line_number":91,"context_line":"Generally, it is very difficult (if possible at all) to recover data after"},{"line_number":92,"context_line":"performing cleaning with ``erase_devices``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"8cfc7ec5_2fe3453e","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":4},"in_reply_to":"32c5ff54_8feeef50","updated":"2022-03-16 11:07:18.000000000","message":"Done","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"846b6c73ea5f52cfea85523b5f557e8cc5ae229d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"performing cleaning with ``erase_devices``."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``erase_devices_metadata`` clean step doesn\u0027t provide as strong assurance"},{"line_number":95,"context_line":"of irreversible destruction of data as ``erase_devices`` however it has the"},{"line_number":96,"context_line":"advantage of a reasonably quick runtime (seconds to minutes). It operates by"},{"line_number":97,"context_line":"destroying metadata of the storage device without erasing every bit of the"},{"line_number":98,"context_line":"data itself. Attempts of restoring data after running"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bcdd3824_96870ea7","line":95,"range":{"start_line":95,"start_character":56,"end_line":95,"end_character":65},"updated":"2022-03-16 11:02:46.000000000","message":"Nit: \". However, \"\n(end the sentence and start a new one)","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"aa21eb36e53902d318fa9fa103d3178f2d191056","unresolved":false,"context_lines":[{"line_number":92,"context_line":"performing cleaning with ``erase_devices``."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``erase_devices_metadata`` clean step doesn\u0027t provide as strong assurance"},{"line_number":95,"context_line":"of irreversible destruction of data as ``erase_devices`` however it has the"},{"line_number":96,"context_line":"advantage of a reasonably quick runtime (seconds to minutes). It operates by"},{"line_number":97,"context_line":"destroying metadata of the storage device without erasing every bit of the"},{"line_number":98,"context_line":"data itself. Attempts of restoring data after running"}],"source_content_type":"text/x-rst","patch_set":1,"id":"84353868_b6c9953c","line":95,"range":{"start_line":95,"start_character":56,"end_line":95,"end_character":65},"in_reply_to":"bcdd3824_96870ea7","updated":"2022-03-16 11:07:18.000000000","message":"Done","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"846b6c73ea5f52cfea85523b5f557e8cc5ae229d","unresolved":true,"context_lines":[{"line_number":111,"context_line":"NVMe-HDD storage configuration as it allows fast and secure erasure of data"},{"line_number":112,"context_line":"stored on NVMes combined with equally fast but more basic metadata-based"},{"line_number":113,"context_line":"erasure of data on HDDs."},{"line_number":114,"context_line":"``erase_devices_express`` is disabled by default. In order to use it it, the"},{"line_number":115,"context_line":"following configuration is recommended. This ensures that ``erase_devices``"},{"line_number":116,"context_line":"and ``erase_devices_metadata`` are disabled so we\u0027re not cleaning storage"},{"line_number":117,"context_line":"twice and then assigns a non-zero priority to ``erase_devices_express``, hence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8c9d97db_778bed5c","line":114,"range":{"start_line":114,"start_character":66,"end_line":114,"end_character":71},"updated":"2022-03-16 11:02:46.000000000","message":"nit: it it","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"aa21eb36e53902d318fa9fa103d3178f2d191056","unresolved":false,"context_lines":[{"line_number":111,"context_line":"NVMe-HDD storage configuration as it allows fast and secure erasure of data"},{"line_number":112,"context_line":"stored on NVMes combined with equally fast but more basic metadata-based"},{"line_number":113,"context_line":"erasure of data on HDDs."},{"line_number":114,"context_line":"``erase_devices_express`` is disabled by default. In order to use it it, the"},{"line_number":115,"context_line":"following configuration is recommended. This ensures that ``erase_devices``"},{"line_number":116,"context_line":"and ``erase_devices_metadata`` are disabled so we\u0027re not cleaning storage"},{"line_number":117,"context_line":"twice and then assigns a non-zero priority to ``erase_devices_express``, hence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6f7529dd_485c104f","line":114,"range":{"start_line":114,"start_character":66,"end_line":114,"end_character":71},"in_reply_to":"8c9d97db_778bed5c","updated":"2022-03-16 11:07:18.000000000","message":"Done","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"846b6c73ea5f52cfea85523b5f557e8cc5ae229d","unresolved":true,"context_lines":[{"line_number":112,"context_line":"stored on NVMes combined with equally fast but more basic metadata-based"},{"line_number":113,"context_line":"erasure of data on HDDs."},{"line_number":114,"context_line":"``erase_devices_express`` is disabled by default. In order to use it it, the"},{"line_number":115,"context_line":"following configuration is recommended. This ensures that ``erase_devices``"},{"line_number":116,"context_line":"and ``erase_devices_metadata`` are disabled so we\u0027re not cleaning storage"},{"line_number":117,"context_line":"twice and then assigns a non-zero priority to ``erase_devices_express``, hence"},{"line_number":118,"context_line":"enabling it."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":".. code-block:: ini"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"54f6d929_9b33aaa2","line":118,"range":{"start_line":115,"start_character":40,"end_line":118,"end_character":12},"updated":"2022-03-16 11:02:46.000000000","message":"move this below the code block?","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"aa21eb36e53902d318fa9fa103d3178f2d191056","unresolved":false,"context_lines":[{"line_number":112,"context_line":"stored on NVMes combined with equally fast but more basic metadata-based"},{"line_number":113,"context_line":"erasure of data on HDDs."},{"line_number":114,"context_line":"``erase_devices_express`` is disabled by default. In order to use it it, the"},{"line_number":115,"context_line":"following configuration is recommended. This ensures that ``erase_devices``"},{"line_number":116,"context_line":"and ``erase_devices_metadata`` are disabled so we\u0027re not cleaning storage"},{"line_number":117,"context_line":"twice and then assigns a non-zero priority to ``erase_devices_express``, hence"},{"line_number":118,"context_line":"enabling it."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":".. code-block:: ini"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"80562ffe_6ec6c548","line":118,"range":{"start_line":115,"start_character":40,"end_line":118,"end_character":12},"in_reply_to":"54f6d929_9b33aaa2","updated":"2022-03-16 11:07:18.000000000","message":"Done","commit_id":"f350dcb5d81813617407e1966b161072efa6b77d"}]}