)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"1198070cabad4f414507444909b44a182f444b40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Get rid of the swap partition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get rid of the swap partition if noit wasn\u0027t specified. This patch fix"},{"line_number":10,"context_line":"the problem of when no swap partition is specified Ironic would create"},{"line_number":11,"context_line":"swap partition of 1MB by default."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAXX%2F%2F1TA%3D","line":9,"updated":"2014-04-25 22:26:56.000000000","message":"s/noit/it/\ns/fix/fixes/","commit_id":"a2477a8a5e250e509cbd8ffbeec2ea40baf63e40"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"df7841586a832d2112c6b8cdccf79f2292754f59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Get rid of the swap partition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get rid of the swap partition if noit wasn\u0027t specified. This patch fix"},{"line_number":10,"context_line":"the problem of when no swap partition is specified Ironic would create"},{"line_number":11,"context_line":"swap partition of 1MB by default."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAXX%2F%2FvtY%3D","line":9,"in_reply_to":"AAAAXX%2F%2F1TA%3D","updated":"2014-04-28 09:40:16.000000000","message":"done","commit_id":"a2477a8a5e250e509cbd8ffbeec2ea40baf63e40"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"1198070cabad4f414507444909b44a182f444b40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the problem of when no swap partition is specified Ironic would create"},{"line_number":11,"context_line":"swap partition of 1MB by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The patch also add consistency to the disk partition layout making the"},{"line_number":14,"context_line":"root partition to be always the last partition (in case an ephemeral or"},{"line_number":15,"context_line":"swap partition exists, otherwise it\u0027s the first :) )."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAXX%2F%2F1Sw%3D","line":13,"updated":"2014-04-25 22:26:56.000000000","message":"s/add/adds/\n\nIMO, \"also\" is a sign that this is two separate changes and should be split up.","commit_id":"a2477a8a5e250e509cbd8ffbeec2ea40baf63e40"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"df7841586a832d2112c6b8cdccf79f2292754f59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the problem of when no swap partition is specified Ironic would create"},{"line_number":11,"context_line":"swap partition of 1MB by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The patch also add consistency to the disk partition layout making the"},{"line_number":14,"context_line":"root partition to be always the last partition (in case an ephemeral or"},{"line_number":15,"context_line":"swap partition exists, otherwise it\u0027s the first :) )."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAXX%2F%2FvtM%3D","line":13,"in_reply_to":"AAAAXX%2F%2F1Sw%3D","updated":"2014-04-28 09:40:16.000000000","message":"done... Right I can split it up in 2 patches, one to get rid of the swap and the other fixing the the partition layout ordering.\n\nThanks","commit_id":"a2477a8a5e250e509cbd8ffbeec2ea40baf63e40"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ec9bcc6daf6d7fda987a37ea3e3e17c4d412223a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-04-28 10:38:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Get rid of the swap partition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get rid of the swap partition if it wasn\u0027t specified. This patch fixes"},{"line_number":10,"context_line":"the problem of when no swap partition is specified Ironic would create"},{"line_number":11,"context_line":"swap partition of 1MB by default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9ad9bd40_30cbdf73","line":8,"updated":"2014-04-30 16:57:41.000000000","message":"This isn\u0027t actually getting rid of the swap partition -- so I\u0027d like to suggest the following wording:\n\n  Stop creating a swap partition when none was specified\n\n  Formerly, when the Nova flavor specified no swap partition, Ironic would still create a 1mb swap partition to avoid certain issues. Those have been fixed in previous patches. This patch corrects the behavior such that Ironic will only create a swap partition when one is requested.","commit_id":"1dad522c3c21207bacb203d9593efff5152f3f69"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"48f3e06125d91a28363a9ed2f12a6c4ce0531ad6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :returns: The"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":88,"context_line":"    ephemeral_part \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BM7Y%3D","line":85,"updated":"2014-03-28 13:15:04.000000000","message":"I think you missed the description here \u003d)","commit_id":"67fa5759ab28c3a1ba1b00e6743da8ad16664f1c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fef9815d8ec6e536af2b5524cee6f399d7d05f91","unresolved":false,"context_lines":[{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :returns: The"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":88,"context_line":"    ephemeral_part \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BMw0%3D","line":85,"in_reply_to":"AAAAWH%2F%2BM7Y%3D","updated":"2014-03-28 13:34:12.000000000","message":"oh lol, yeah! will fix :D","commit_id":"67fa5759ab28c3a1ba1b00e6743da8ad16664f1c"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"f2a054513491bae62255bb72b620867d5263a5a7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :returns: A tuple with the partitions path."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad9bd40_04ff7868","line":85,"updated":"2014-05-01 00:56:08.000000000","message":"I\u0027d prefer to see a dict // named tuple here - e.g.\n\n{\u0027swap\u0027: foo, \u0027root\u0027: bar, \u0027ephemeral0\u0027: quux}. This would be clearer in calling code and less susceptible to typos.","commit_id":"62306960876e22adbe9a2ea0c4d44edb0db7d43b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"11edd320fac861b8162e455a987d7dc1d2b2d99c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :returns: A tuple with the partitions path."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad9bd40_ba633cb0","line":85,"in_reply_to":"9ad9bd40_04ff7868","updated":"2014-05-01 09:08:54.000000000","message":"done","commit_id":"62306960876e22adbe9a2ea0c4d44edb0db7d43b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52c8dae3b3082ee43655285fb1e44f7f467692c8","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :param root_mb: Size of the root partition in megabytes."},{"line_number":86,"context_line":"    :param swap_mb: Size of the swap partition in megabytes. If 0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad9bd40_d48b0366","line":83,"updated":"2014-05-06 13:36:17.000000000","message":"I wonder why we didn\u0027t mention \u0027ephemeral\u0027 here. (If you update, would you please add?)","commit_id":"a0fd71e91f1825a826b7ff512331e2799dfb6910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a696ca6bac139b5d8e35bc6b2388260d67b2b87c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb):"},{"line_number":83,"context_line":"    \"\"\"Create partitions for root and swap on a disk device."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :param root_mb: Size of the root partition in megabytes."},{"line_number":86,"context_line":"    :param swap_mb: Size of the swap partition in megabytes. If 0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad9bd40_91b348e8","line":83,"in_reply_to":"9ad9bd40_d48b0366","updated":"2014-05-06 15:36:59.000000000","message":"Will add, thanks","commit_id":"a0fd71e91f1825a826b7ff512331e2799dfb6910"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52c8dae3b3082ee43655285fb1e44f7f467692c8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        no swap partition will be created."},{"line_number":88,"context_line":"    :param ephemeral_mb: Size of the ephemeral partition in megabytes. If 0,"},{"line_number":89,"context_line":"        no ephemeral partition will be created."},{"line_number":90,"context_line":"    :returns: A dictionary with the partitions path."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad9bd40_f42e4742","line":90,"updated":"2014-05-06 13:36:17.000000000","message":"Nit. is it clear that the dictionary keys are \u0027root\u0027, \u0027swap\u0027, and \u0027ephemeral\u0027?","commit_id":"a0fd71e91f1825a826b7ff512331e2799dfb6910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a696ca6bac139b5d8e35bc6b2388260d67b2b87c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        no swap partition will be created."},{"line_number":88,"context_line":"    :param ephemeral_mb: Size of the ephemeral partition in megabytes. If 0,"},{"line_number":89,"context_line":"        no ephemeral partition will be created."},{"line_number":90,"context_line":"    :returns: A dictionary with the partitions path."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad9bd40_31143c9f","line":90,"in_reply_to":"9ad9bd40_f42e4742","updated":"2014-05-06 15:36:59.000000000","message":"Not always, the dict will contain the keys of the partitions it created, if it created swap and root it will contain \u0027swap\u0027 and \u0027root\u0027 but no \u0027ephemeral\u0027.","commit_id":"a0fd71e91f1825a826b7ff512331e2799dfb6910"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1d66efbde751f792d339389872e553851e24278","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        no swap partition will be created."},{"line_number":88,"context_line":"    :param ephemeral_mb: Size of the ephemeral partition in mebibytes (MiB)."},{"line_number":89,"context_line":"        If 0, no ephemeral partition will be created."},{"line_number":90,"context_line":"    :returns: A dictionary containg the partition type as Key and partition"},{"line_number":91,"context_line":"              path as Value for the partitions created by this method."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad9bd40_ffaa9b6f","line":90,"updated":"2014-05-06 16:50:58.000000000","message":"typo: containg-\u003econtaining","commit_id":"60d5eb20a081eb530cc188aa475b5981fa27a44e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f2a114b3f231d9b406057707cd8027a73a133308","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        no swap partition will be created."},{"line_number":88,"context_line":"    :param ephemeral_mb: Size of the ephemeral partition in mebibytes (MiB)."},{"line_number":89,"context_line":"        If 0, no ephemeral partition will be created."},{"line_number":90,"context_line":"    :returns: A dictionary containg the partition type as Key and partition"},{"line_number":91,"context_line":"              path as Value for the partitions created by this method."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad9bd40_ba7d811e","line":90,"in_reply_to":"9ad9bd40_ffaa9b6f","updated":"2014-05-06 17:29:53.000000000","message":":( will fix","commit_id":"60d5eb20a081eb530cc188aa475b5981fa27a44e"}]}