)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e4174ae6cea1637e24e10f9692807fc6c69183c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d1e45e8_38902cd0","updated":"2022-04-13 17:31:38.000000000","message":"Looks good (avoiding +W since CI is unstable and because I have a question \u003d) )","commit_id":"5feb39844ab1a3f266669f01b6a13f39462b4612"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a89710e5ba903ee7698c9e31935c65f678ab10d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b01b8c0_f6fe4556","updated":"2022-04-19 08:55:59.000000000","message":"recheck","commit_id":"5feb39844ab1a3f266669f01b6a13f39462b4612"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3296a6ba297e1f679e2154bb1d59876edc66b5e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af5245c6_0ad20738","updated":"2022-04-14 17:50:14.000000000","message":"recheck","commit_id":"5feb39844ab1a3f266669f01b6a13f39462b4612"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e4174ae6cea1637e24e10f9692807fc6c69183c8","unresolved":true,"context_lines":[{"line_number":1717,"context_line":"        info[\u0027kernel_append_params\u0027] \u003d \u0027param1 %default% params2\u0027"},{"line_number":1718,"context_line":"        self.node.driver_info \u003d info"},{"line_number":1719,"context_line":"        self.node.save()"},{"line_number":1720,"context_line":"        self._test_build_pxe_config_options_pxe("},{"line_number":1721,"context_line":"            whle_dsk_img\u003dTrue,"},{"line_number":1722,"context_line":"            expected_pxe_params\u003d\u0027param1 test_param params2\u0027)"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"    def test_build_pxe_config_options_kernel_params_from_instance_info(self):"},{"line_number":1725,"context_line":"        info \u003d self.node.instance_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"f30a8863_ef6916cd","line":1722,"range":{"start_line":1720,"start_character":0,"end_line":1722,"end_character":60},"updated":"2022-04-13 17:31:38.000000000","message":"Maybe I\u0027m missing something...\nIn case some of the values from `%default%` is already present in the driver_info[\u0027kernel_append_params\u0027] we will be removing to ensure there is no duplicate param? Or this is something operators will have to keep an eye and only provide the right configs?","commit_id":"5feb39844ab1a3f266669f01b6a13f39462b4612"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7c1e4970a835eb1ab52cf68771f2bd4598b3142b","unresolved":true,"context_lines":[{"line_number":1717,"context_line":"        info[\u0027kernel_append_params\u0027] \u003d \u0027param1 %default% params2\u0027"},{"line_number":1718,"context_line":"        self.node.driver_info \u003d info"},{"line_number":1719,"context_line":"        self.node.save()"},{"line_number":1720,"context_line":"        self._test_build_pxe_config_options_pxe("},{"line_number":1721,"context_line":"            whle_dsk_img\u003dTrue,"},{"line_number":1722,"context_line":"            expected_pxe_params\u003d\u0027param1 test_param params2\u0027)"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"    def test_build_pxe_config_options_kernel_params_from_instance_info(self):"},{"line_number":1725,"context_line":"        info \u003d self.node.instance_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ff79f40_f8ef086a","line":1722,"range":{"start_line":1720,"start_character":0,"end_line":1722,"end_character":60},"in_reply_to":"f30a8863_ef6916cd","updated":"2022-04-14 12:07:02.000000000","message":"We\u0027re not doing de-duplication right now, largely because I\u0027m not sure that no parameters can be specified several times.\n\nI\u0027ve done some reason on those that are specified once. It seems that at least both kernel and dracut explicitly give priority to the last instance, which matches the intuition. At least my intuition :) \n\nI do agree that we should document this aspect. I\u0027ll follow up.","commit_id":"5feb39844ab1a3f266669f01b6a13f39462b4612"}]}