)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6a34ac7fe1296c8f0bd057c7953a82f43ce4e5f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # Internal use only"},{"line_number":122,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    d_info[\u0027swap_gb\u0027] \u003d info.get(\u0027pxe_swap_gb\u0027, 0)"},{"line_number":125,"context_line":"    d_info[\u0027ephemeral_gb\u0027] \u003d info.get(\u0027pxe_ephemeral_gb\u0027, 0)"},{"line_number":126,"context_line":"    d_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027pxe_ephemeral_format\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_ad5456fe","line":124,"updated":"2014-06-12 13:35:18.000000000","message":"Do you know if we have to also support pxe_swap_mb for some period of time (indicate that it is deprecated somehow and that it will be removed by X?)","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e5e4cd255cf16469aea056cd18e79f4e23005447","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # Internal use only"},{"line_number":122,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    d_info[\u0027swap_gb\u0027] \u003d info.get(\u0027pxe_swap_gb\u0027, 0)"},{"line_number":125,"context_line":"    d_info[\u0027ephemeral_gb\u0027] \u003d info.get(\u0027pxe_ephemeral_gb\u0027, 0)"},{"line_number":126,"context_line":"    d_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027pxe_ephemeral_format\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_d4af67e1","line":124,"in_reply_to":"1ae5cdf2_ad5456fe","updated":"2014-06-12 16:01:02.000000000","message":"well... I don\u0027t think it\u0027s needed because who sets those values is the Nova driver not the user, the user sets the swap size when create the flavor not directly in Ironic","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"db2ddd865b0e778ea66ed0d29237275e73be0d41","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                  \u0027pxe_config_path\u0027: _get_pxe_config_file_path("},{"line_number":676,"context_line":"                                                    node.uuid),"},{"line_number":677,"context_line":"                  \u0027root_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027root_gb\u0027]))),"},{"line_number":678,"context_line":"                  \u0027swap_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027swap_gb\u0027]))),"},{"line_number":679,"context_line":"                  \u0027ephemeral_mb\u0027: int(math.ceil("},{"line_number":680,"context_line":"                                      1024 * float(d_info[\u0027ephemeral_gb\u0027]))),"},{"line_number":681,"context_line":"                  \u0027preserve_ephemeral\u0027: d_info[\u0027preserve_ephemeral\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_d643f410","line":678,"updated":"2014-06-12 12:08:19.000000000","message":"I think better create small function for this instead of 3 copy.","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e5e4cd255cf16469aea056cd18e79f4e23005447","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                  \u0027pxe_config_path\u0027: _get_pxe_config_file_path("},{"line_number":676,"context_line":"                                                    node.uuid),"},{"line_number":677,"context_line":"                  \u0027root_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027root_gb\u0027]))),"},{"line_number":678,"context_line":"                  \u0027swap_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027swap_gb\u0027]))),"},{"line_number":679,"context_line":"                  \u0027ephemeral_mb\u0027: int(math.ceil("},{"line_number":680,"context_line":"                                      1024 * float(d_info[\u0027ephemeral_gb\u0027]))),"},{"line_number":681,"context_line":"                  \u0027preserve_ephemeral\u0027: d_info[\u0027preserve_ephemeral\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_14b62f3e","line":678,"in_reply_to":"1ae5cdf2_2d8da67c","updated":"2014-06-12 16:01:02.000000000","message":"+1 done","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6a34ac7fe1296c8f0bd057c7953a82f43ce4e5f","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                  \u0027pxe_config_path\u0027: _get_pxe_config_file_path("},{"line_number":676,"context_line":"                                                    node.uuid),"},{"line_number":677,"context_line":"                  \u0027root_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027root_gb\u0027]))),"},{"line_number":678,"context_line":"                  \u0027swap_mb\u0027: int(math.ceil(1024 * float(d_info[\u0027swap_gb\u0027]))),"},{"line_number":679,"context_line":"                  \u0027ephemeral_mb\u0027: int(math.ceil("},{"line_number":680,"context_line":"                                      1024 * float(d_info[\u0027ephemeral_gb\u0027]))),"},{"line_number":681,"context_line":"                  \u0027preserve_ephemeral\u0027: d_info[\u0027preserve_ephemeral\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_2d8da67c","line":678,"in_reply_to":"1ae5cdf2_d643f410","updated":"2014-06-12 13:35:18.000000000","message":"+1. And then you can use the same function for calculating root_mb in _check_image_size().","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"}],"ironic/nova/tests/virt/ironic/test_patcher.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"adfe54c1f83e4c80431d08ccd5487a9504e895d1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                     \u0027value\u0027: str(instance[\u0027root_gb\u0027]),"},{"line_number":118,"context_line":"                     \u0027op\u0027: \u0027add\u0027},"},{"line_number":119,"context_line":"                    {\u0027path\u0027: \u0027/driver_info/pxe_swap_gb\u0027,"},{"line_number":120,"context_line":"                     \u0027value\u0027: str(1), # In GB"},{"line_number":121,"context_line":"                     \u0027op\u0027: \u0027add\u0027}]"},{"line_number":122,"context_line":"        patch \u003d patcher.create(node).get_deploy_patch("},{"line_number":123,"context_line":"                instance, self.image_meta, self.flavor)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2FtmY%3D","line":120,"updated":"2014-04-28 14:25:35.000000000","message":"str(1) \u003d\u003d \u00271\u0027 :)","commit_id":"b3c1e1fd4f0e3599132d818b0e345232f1ddbb3e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"647f94c287379242156c687be3caa13dfd2b2e10","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                     \u0027value\u0027: str(instance[\u0027root_gb\u0027]),"},{"line_number":118,"context_line":"                     \u0027op\u0027: \u0027add\u0027},"},{"line_number":119,"context_line":"                    {\u0027path\u0027: \u0027/driver_info/pxe_swap_gb\u0027,"},{"line_number":120,"context_line":"                     \u0027value\u0027: str(1), # In GB"},{"line_number":121,"context_line":"                     \u0027op\u0027: \u0027add\u0027}]"},{"line_number":122,"context_line":"        patch \u003d patcher.create(node).get_deploy_patch("},{"line_number":123,"context_line":"                instance, self.image_meta, self.flavor)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad9bd40_30ce7f5b","line":120,"in_reply_to":"AAAAXX%2F%2FtmY%3D","updated":"2014-04-30 17:28:11.000000000","message":"done","commit_id":"b3c1e1fd4f0e3599132d818b0e345232f1ddbb3e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6a34ac7fe1296c8f0bd057c7953a82f43ce4e5f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \u0027pxe_deploy_kernel\u0027: \u0027fake-kernel-id\u0027,"},{"line_number":83,"context_line":"                       \u0027pxe_deploy_ramdisk\u0027: \u0027fake-ramdisk-id\u0027,"},{"line_number":84,"context_line":"                       \u0027pxe_root_gb\u0027: \u00271024\u0027,"},{"line_number":85,"context_line":"                       \u0027pxe_swap_gb\u0027: \u00271\u0027,"},{"line_number":86,"context_line":"                       \u0027pxe_preserve_ephemeral\u0027: True,"},{"line_number":87,"context_line":"                       \u0027pxe_ephemeral_format\u0027: \u0027fake-format\u0027}"},{"line_number":88,"context_line":"        node \u003d ironic_utils.get_test_node(driver\u003d\u0027pxe_fake\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_eddd7e71","line":85,"updated":"2014-06-12 13:35:18.000000000","message":"I would use 0.5, since that\u0027s the equiv of 512 MB. Although I guess in this test, nothing checks the value afterwards so it doesn\u0027t matter. Guess it just seems odd to me because it changes the numbers, so not a big deal if you don\u0027t change.","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e5e4cd255cf16469aea056cd18e79f4e23005447","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \u0027pxe_deploy_kernel\u0027: \u0027fake-kernel-id\u0027,"},{"line_number":83,"context_line":"                       \u0027pxe_deploy_ramdisk\u0027: \u0027fake-ramdisk-id\u0027,"},{"line_number":84,"context_line":"                       \u0027pxe_root_gb\u0027: \u00271024\u0027,"},{"line_number":85,"context_line":"                       \u0027pxe_swap_gb\u0027: \u00271\u0027,"},{"line_number":86,"context_line":"                       \u0027pxe_preserve_ephemeral\u0027: True,"},{"line_number":87,"context_line":"                       \u0027pxe_ephemeral_format\u0027: \u0027fake-format\u0027}"},{"line_number":88,"context_line":"        node \u003d ironic_utils.get_test_node(driver\u003d\u0027pxe_fake\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_94795f84","line":85,"in_reply_to":"1ae5cdf2_eddd7e71","updated":"2014-06-12 16:01:02.000000000","message":"Hmm, just kept 1 cause it looks clear, the new test (test_pxe_get_deploy_patch_convert_swap) is testing the conversion already","commit_id":"9a63cff5d086790cd51eebb4229ca68f052f5c85"}],"ironic/nova/virt/ironic/ironic_driver_fields.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7b267093f9545139176a8b389d70094f53b7f969","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                 \u0027nova_object\u0027: \u0027instance\u0027,"},{"line_number":43,"context_line":"                 \u0027object_field\u0027: \u0027root_gb\u0027},"},{"line_number":44,"context_line":"                {\u0027ironic_path\u0027: \u0027/driver_info\u0027,"},{"line_number":45,"context_line":"                 \u0027ironic_variable\u0027: \u0027pxe_swap_mb\u0027,"},{"line_number":46,"context_line":"                 \u0027nova_object\u0027: \u0027flavor\u0027,"},{"line_number":47,"context_line":"                 \u0027object_field\u0027: \u0027swap\u0027},"},{"line_number":48,"context_line":"                {\u0027ironic_path\u0027: \u0027/driver_info\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F9Yhk%3D","side":"PARENT","line":45,"updated":"2014-04-04 22:16:28.000000000","message":"why is it removed entirely? shouldn\u0027t be either changed to swap_gb, or changed and moved to the optional list?","commit_id":"42529d89bb14a58e86133b6af5cae5c0ff24b252"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8ba761689c05e904c40f82ed06e3bc5d83eea75a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                 \u0027nova_object\u0027: \u0027instance\u0027,"},{"line_number":43,"context_line":"                 \u0027object_field\u0027: \u0027root_gb\u0027},"},{"line_number":44,"context_line":"                {\u0027ironic_path\u0027: \u0027/driver_info\u0027,"},{"line_number":45,"context_line":"                 \u0027ironic_variable\u0027: \u0027pxe_swap_mb\u0027,"},{"line_number":46,"context_line":"                 \u0027nova_object\u0027: \u0027flavor\u0027,"},{"line_number":47,"context_line":"                 \u0027object_field\u0027: \u0027swap\u0027},"},{"line_number":48,"context_line":"                {\u0027ironic_path\u0027: \u0027/driver_info\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F9TgY%3D","side":"PARENT","line":45,"in_reply_to":"AAAAWH%2F9Yhk%3D","updated":"2014-04-07 08:37:16.000000000","message":"Hi, so I had to move it to driver.py, because I need to do some math operation before setting it in Ironic, I have to convert the swap in flavor from MB to GB and round it up.","commit_id":"42529d89bb14a58e86133b6af5cae5c0ff24b252"}],"ironic/nova/virt/ironic/patcher.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"09c958b926e5477db6732f0e422338e3f4869a74","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # NOTE(lucasagomes): Convert swap from MB to GB and round it up"},{"line_number":108,"context_line":"        swap_mb \u003d flavor[\u0027swap\u0027]"},{"line_number":109,"context_line":"        if swap_mb:"},{"line_number":110,"context_line":"            swap_gb \u003d int(math.ceil(swap_mb / float(1024)))"},{"line_number":111,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_swap_gb\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":112,"context_line":"                          \u0027value\u0027: str(swap_gb)})"},{"line_number":113,"context_line":"        return patch"}],"source_content_type":"text/x-python","patch_set":11,"id":"bad4c104_232654bb","line":110,"updated":"2014-04-29 01:13:02.000000000","message":"I\u0027d like to see a test with e.g. 512MB swap to make sure this rounds correctly.","commit_id":"b3c1e1fd4f0e3599132d818b0e345232f1ddbb3e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"647f94c287379242156c687be3caa13dfd2b2e10","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # NOTE(lucasagomes): Convert swap from MB to GB and round it up"},{"line_number":108,"context_line":"        swap_mb \u003d flavor[\u0027swap\u0027]"},{"line_number":109,"context_line":"        if swap_mb:"},{"line_number":110,"context_line":"            swap_gb \u003d int(math.ceil(swap_mb / float(1024)))"},{"line_number":111,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_swap_gb\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":112,"context_line":"                          \u0027value\u0027: str(swap_gb)})"},{"line_number":113,"context_line":"        return patch"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad9bd40_50db031b","line":110,"in_reply_to":"bad4c104_232654bb","updated":"2014-04-30 17:28:11.000000000","message":"done","commit_id":"b3c1e1fd4f0e3599132d818b0e345232f1ddbb3e"}]}
