)]}'
{"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8ecdd23c8909a5218a2eba1d8d20a0526b94201d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        icli \u003d self._get_client()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # remove the instance uuid"},{"line_number":272,"context_line":"        if node.instance_uuid:"},{"line_number":273,"context_line":"            try:"},{"line_number":274,"context_line":"                patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":275,"context_line":"                self._retry_if_service_is_unavailable(icli.node.update,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9lBI%3D","line":272,"updated":"2014-04-03 15:17:58.000000000","message":"this needs to check that the node.instance_uuid is the same as the passed instance[\u0027uuid\u0027]","commit_id":"c48bf21860d80dce78e56309105c4ee85436643b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2d9735202d90af46024467b9e6fe45ff7f4e6d1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        icli \u003d self._get_client()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # remove the instance uuid"},{"line_number":272,"context_line":"        if node.instance_uuid:"},{"line_number":273,"context_line":"            try:"},{"line_number":274,"context_line":"                patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":275,"context_line":"                self._retry_if_service_is_unavailable(icli.node.update,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9Su8%3D","line":272,"in_reply_to":"AAAAWH%2F9lBI%3D","updated":"2014-04-07 10:53:32.000000000","message":"Right, I can check whether node.instance_uuid \u003d\u003d instance[\u0027uuid\u0027] here as an extra precaution because the methods that call _cleanup_deploy() already does get similar checks[1][2].\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/driver.py#L386-L395\n\n[2] https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/driver.py#L483-L487","commit_id":"c48bf21860d80dce78e56309105c4ee85436643b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8ecdd23c8909a5218a2eba1d8d20a0526b94201d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                        \"with node %(node)s\") % {\u0027instance\u0027: instance[\u0027uuid\u0027],"},{"line_number":280,"context_line":"                                                 \u0027node\u0027: node.uuid})"},{"line_number":281,"context_line":"                LOG.error(msg)"},{"line_number":282,"context_line":"                raise exception.NovaException(msg)"},{"line_number":283,"context_line":"            except ironic_exception.HTTPBadRequest:"},{"line_number":284,"context_line":"                pass"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9lAY%3D","line":282,"updated":"2014-04-03 15:17:58.000000000","message":"this raise will supercede the \"raise InstanceDeployFailure\" on line 466, which is probably not what you want to happen...","commit_id":"c48bf21860d80dce78e56309105c4ee85436643b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2d9735202d90af46024467b9e6fe45ff7f4e6d1","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                        \"with node %(node)s\") % {\u0027instance\u0027: instance[\u0027uuid\u0027],"},{"line_number":280,"context_line":"                                                 \u0027node\u0027: node.uuid})"},{"line_number":281,"context_line":"                LOG.error(msg)"},{"line_number":282,"context_line":"                raise exception.NovaException(msg)"},{"line_number":283,"context_line":"            except ironic_exception.HTTPBadRequest:"},{"line_number":284,"context_line":"                pass"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9SuE%3D","line":282,"in_reply_to":"AAAAWH%2F9lAY%3D","updated":"2014-04-07 10:53:32.000000000","message":"oh, true! thanks for pointing that out. Looking at flow of the code, I think it\u0027s better us to log a warning about it (like we do in L301)  but avoid raising that NovaException here. So it won\u0027t supercede any other exception hiddin the real error.","commit_id":"c48bf21860d80dce78e56309105c4ee85436643b"}]}