)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fb3f4f03a01be6d5e4566294a3feed9a4db46000","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54397435_68c7c48e","updated":"2022-06-24 18:32:57.000000000","message":"This is obviously already approved and it won\u0027t impact correctness, but it seems like a bad pattern to do log\u003dbool as an option for a method. If possible, it might be nice to remove this in a follow-up.","commit_id":"65583e64172a0188d125117d1f2288e105832395"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a67d59adf81fade45588689bb50f7a7fb9c2499","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11854010_ff19e705","updated":"2022-06-24 14:56:51.000000000","message":"recheck","commit_id":"65583e64172a0188d125117d1f2288e105832395"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5cb454d28d00b91de4d89c603739b64ef422ab1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25e90ef0_2533c880","updated":"2022-06-24 09:21:48.000000000","message":"recheck","commit_id":"65583e64172a0188d125117d1f2288e105832395"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7e907f4ec61f00eadae75e404ff155dbb73f3c56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"659562b1_0f5e33cf","updated":"2022-06-26 22:36:59.000000000","message":"recheck","commit_id":"65583e64172a0188d125117d1f2288e105832395"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"72bd232011347e6cd8c6abb996c53e36ef97cfb9","unresolved":true,"context_lines":[{"line_number":235,"context_line":"                os.path.join(root_dir, node_uuid, label)"},{"line_number":236,"context_line":"            )"},{"line_number":237,"context_line":"        except KeyError:"},{"line_number":238,"context_line":"            pass  # may be absent in rare cases, verified in parse_driver_info"},{"line_number":239,"context_line":"    return image_info"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c74d2c86_244473e7","line":238,"updated":"2022-06-24 12:01:25.000000000","message":"it\u0027s ok as it\u0027s verified later, alhtough I would have probably at least added a debug message","commit_id":"65583e64172a0188d125117d1f2288e105832395"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fb3f4f03a01be6d5e4566294a3feed9a4db46000","unresolved":true,"context_lines":[{"line_number":948,"context_line":"    elif node.automated_clean is None:"},{"line_number":949,"context_line":"        return not CONF.conductor.automated_clean"},{"line_number":950,"context_line":"    else:"},{"line_number":951,"context_line":"        if log:"},{"line_number":952,"context_line":"            LOG.info(\"Automated cleaning is disabled via the API for \""},{"line_number":953,"context_line":"                     \"node %(node)s\", {\u0027node\u0027: node.uuid})"},{"line_number":954,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"d994c8e5_d0202bb5","line":951,"updated":"2022-06-24 18:32:57.000000000","message":"nit: I think it\u0027s a bit of a smell to swap whether we log based on a flag. I\u0027d suggest in the future we add this log, with the call, to places that would pass true to log here. (Although I understand skipping it for the purposes of this bugfix, this is a weird construct)","commit_id":"65583e64172a0188d125117d1f2288e105832395"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6964420b84d883b0867ad7cb2e0802d1b2a5a6bd","unresolved":true,"context_lines":[{"line_number":948,"context_line":"    elif node.automated_clean is None:"},{"line_number":949,"context_line":"        return not CONF.conductor.automated_clean"},{"line_number":950,"context_line":"    else:"},{"line_number":951,"context_line":"        if log:"},{"line_number":952,"context_line":"            LOG.info(\"Automated cleaning is disabled via the API for \""},{"line_number":953,"context_line":"                     \"node %(node)s\", {\u0027node\u0027: node.uuid})"},{"line_number":954,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"296efa04_d2ef02f0","line":951,"in_reply_to":"d994c8e5_d0202bb5","updated":"2022-07-06 14:53:43.000000000","message":"Yeah, I agree","commit_id":"65583e64172a0188d125117d1f2288e105832395"}]}