)]}'
{"ironic/objects/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edcd2f28401c4070689c9b7f5b102a3649bedf52","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param context: Security context. NOTE: This should only"},{"line_number":129,"context_line":"                        only be used internally by the indirection_api."},{"line_number":130,"context_line":"                        A context should be set when instantiating"},{"line_number":131,"context_line":"                        the object, e.g.: Node(context\u003dcontext)"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        values \u003d self.obj_get_changes()"},{"line_number":134,"context_line":"        db_node \u003d self.dbapi.create_node(values)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8so%3D","line":131,"updated":"2014-04-16 10:17:58.000000000","message":"context variable is unused here and in destroy. E.g. in get_by_uuid is is set to node._context (see above). Don\u0027t we need something like that here?","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edcd2f28401c4070689c9b7f5b102a3649bedf52","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        \"\"\"Delete the Node from the DB."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :param context: Security context. NOTE: This is only used"},{"line_number":142,"context_line":"                        internally by the indirection_api."},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        self.dbapi.destroy_node(self.id)"},{"line_number":145,"context_line":"        self.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8sc%3D","line":142,"updated":"2014-04-16 10:17:58.000000000","message":"Again, do we need context?","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"975242a4e921a706c166df54c7eb6ca3e89e8837","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        node before updates are made."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        :param context: Security context. NOTE: This should only"},{"line_number":129,"context_line":"                        only be used internally by the indirection_api."},{"line_number":130,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":131,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":132,"context_line":"                        A context should be set when instantiating the"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAXX%2F%2FtdY%3D","line":129,"updated":"2014-04-28 14:50:13.000000000","message":"doubled \u0027only\u0027","commit_id":"60b7069e9f5c0797bd6ffefb6baa339f2316efad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"975242a4e921a706c166df54c7eb6ca3e89e8837","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\"Delete the Node from the DB."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        :param context: Security context. NOTE: This should only"},{"line_number":145,"context_line":"                        only be used internally by the indirection_api."},{"line_number":146,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":147,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":148,"context_line":"                        A context should be set when instantiating the"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAXX%2F%2FtdQ%3D","line":145,"updated":"2014-04-28 14:50:13.000000000","message":"ditto","commit_id":"60b7069e9f5c0797bd6ffefb6baa339f2316efad"}],"ironic/tests/api/v1/test_chassis.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eea6e7a5776c8ef61cb2573f50d2347ecb23a63a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            node \u003d obj_utils.get_test_node("},{"line_number":131,"context_line":"                    self.context, id\u003did, chassis_id\u003dcdict[\u0027id\u0027],"},{"line_number":132,"context_line":"                    uuid\u003dutils.generate_uuid())"},{"line_number":133,"context_line":"            node.create()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        data \u003d self.get_json(\u0027/chassis/%s/nodes\u0027 % cdict[\u0027uuid\u0027])"},{"line_number":136,"context_line":"        self.assertEqual(2, len(data[\u0027nodes\u0027]))"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXH%2F%2Fq98%3D","line":133,"updated":"2014-04-18 11:22:02.000000000","message":"Use obj_utils.create_test_node?","commit_id":"6ca11e32c9c2fe61957b08287f44d40b9f40e1e1"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eea6e7a5776c8ef61cb2573f50d2347ecb23a63a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def _create_node(**kwargs):"},{"line_number":48,"context_line":"    node \u003d obj_utils.get_test_node(context.get_admin_context(), **kwargs)"},{"line_number":49,"context_line":"    node.create()"},{"line_number":50,"context_line":"    return node"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class TestListNodes(base.FunctionalTest):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXH%2F%2Fq%2B4%3D","line":50,"updated":"2014-04-18 11:22:02.000000000","message":"Why not use obj_utils.create_test_node here?","commit_id":"6ca11e32c9c2fe61957b08287f44d40b9f40e1e1"}],"ironic/tests/api/v1/test_ports.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def _create_node(**kwargs):"},{"line_number":46,"context_line":"    node \u003d obj_utils.get_test_node(context.get_admin_context(), **kwargs)"},{"line_number":47,"context_line":"    node.create()"},{"line_number":48,"context_line":"    return node"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestListPorts(base.FunctionalTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8cY%3D","line":48,"updated":"2014-04-16 10:51:07.000000000","message":"I think it\u0027s better to not import it from test_nodes.py and instead put it in a common place that can import in both modules, test_nodes.py, test_ports.py, test_conductor_utils/py\n\nOne suggestion would be to have it at tests/api/utils.py[1] or even creating an ironic/tests/utils.py if it\u0027s going to be a common function across all parts (not specific to the api testings)\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/tests/api/utils.py","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edcd2f28401c4070689c9b7f5b102a3649bedf52","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def _create_node(**kwargs):"},{"line_number":46,"context_line":"    node \u003d obj_utils.get_test_node(context.get_admin_context(), **kwargs)"},{"line_number":47,"context_line":"    node.create()"},{"line_number":48,"context_line":"    return node"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestListPorts(base.FunctionalTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8ro%3D","line":48,"updated":"2014-04-16 10:17:58.000000000","message":"Maybe better import this function from test_nodes?","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"}],"ironic/tests/conductor/test_conductor_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edcd2f28401c4070689c9b7f5b102a3649bedf52","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _create_node(self, **kwargs):"},{"line_number":36,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":37,"context_line":"        node.create()"},{"line_number":38,"context_line":"        return node"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_node_set_boot_device_non_existent_device(self):"},{"line_number":41,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\"fake_ipmitool\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8qk%3D","line":38,"updated":"2014-04-16 10:17:58.000000000","message":"Maybe this function (and below) can also be imported from tests.api.v1.test_nodes?","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _create_node(self, **kwargs):"},{"line_number":36,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":37,"context_line":"        node.create()"},{"line_number":38,"context_line":"        return node"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_node_set_boot_device_non_existent_device(self):"},{"line_number":41,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\"fake_ipmitool\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8ao%3D","line":38,"updated":"2014-04-16 10:51:07.000000000","message":"ditto about having it in a common place.","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def _create_node(self, **kwargs):"},{"line_number":83,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":84,"context_line":"        node.create()"},{"line_number":85,"context_line":"        return node"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_node_power_action_power_on(self):"},{"line_number":88,"context_line":"        \"\"\"Test node_power_action to turn node power on.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8ag%3D","line":85,"updated":"2014-04-16 10:51:07.000000000","message":"ditto about having it in a common place","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eea6e7a5776c8ef61cb2573f50d2347ecb23a63a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def _create_node(self, **kwargs):"},{"line_number":80,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":81,"context_line":"        node.create()"},{"line_number":82,"context_line":"        return node"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_node_power_action_power_on(self):"},{"line_number":85,"context_line":"        \"\"\"Test node_power_action to turn node power on.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXH%2F%2Fq9g%3D","line":82,"updated":"2014-04-18 11:22:02.000000000","message":"ditto about obj_utils.create_test_node?","commit_id":"6ca11e32c9c2fe61957b08287f44d40b9f40e1e1"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def _create_node(self, **kwargs):"},{"line_number":73,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":74,"context_line":"        node.create()"},{"line_number":75,"context_line":"        return node"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_start_registers_conductor(self):"},{"line_number":78,"context_line":"        self.assertRaises(exception.ConductorNotFound,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8ac%3D","line":75,"updated":"2014-04-16 10:51:07.000000000","message":"ditto about having it in a common place","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"}],"ironic/tests/db/test_chassis.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _create_test_node(self, **kwargs):"},{"line_number":41,"context_line":"        node \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":42,"context_line":"        node.create()"},{"line_number":43,"context_line":"        return node"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_chassis_list(self):"},{"line_number":46,"context_line":"        uuids \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8aI%3D","line":43,"updated":"2014-04-16 10:51:07.000000000","message":"ditto about having it in a common place","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"}],"ironic/tests/drivers/test_seamicro.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad752604eba55c526cd50c2ce494937069eeb882","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def _create_test_node(self, **kwargs):"},{"line_number":159,"context_line":"        n \u003d obj_utils.get_test_node(self.context, **kwargs)"},{"line_number":160,"context_line":"        n.create()"},{"line_number":161,"context_line":"        return n"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @mock.patch.object(seamicro, \"_get_server\")"},{"line_number":164,"context_line":"    def test__get_power_status_on(self, mock_get_server):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F8Z4%3D","line":161,"updated":"2014-04-16 10:51:07.000000000","message":"ditto about having it in a common place","commit_id":"70ab7d1e4bf6255ecbf842302655d7276298bc9f"}]}
