)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1fed95b17521d39db91852d7d964c8509cd03e5f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                  marker)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if node_uuid:"},{"line_number":178,"context_line":"            node \u003d pecan.request.dbapi.get_node(node_uuid)"},{"line_number":179,"context_line":"            # TODO(comstud): I know it\u0027s slightly weird to be passing"},{"line_number":180,"context_line":"            # a Node object into this dbapi call. This will get cleaned"},{"line_number":181,"context_line":"            # up and turned into a call into a PortList object in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F37k%3D","line":178,"updated":"2014-04-09 18:53:51.000000000","message":"this is inefficient since it\u0027s requesting the whole node record, not just the node.id, which is all that\u0027s really needed in the next call.\n\nif lazy loading of attributes isn\u0027t implemented yet in this patch series (I haven\u0027t read the whole series, so I\u0027m not sure) then could you at least tag a #TODO here?","commit_id":"62eeb0ef6cd4d11eb72611165d719e05ac9b0f8c"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"edb5f882998591c577741f015f760366506c253b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                  marker)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if node_uuid:"},{"line_number":178,"context_line":"            node \u003d pecan.request.dbapi.get_node(node_uuid)"},{"line_number":179,"context_line":"            # TODO(comstud): I know it\u0027s slightly weird to be passing"},{"line_number":180,"context_line":"            # a Node object into this dbapi call. This will get cleaned"},{"line_number":181,"context_line":"            # up and turned into a call into a PortList object in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F3Lg%3D","line":178,"in_reply_to":"AAAAW3%2F%2F37k%3D","updated":"2014-04-09 21:02:49.000000000","message":"Yeah, good point..  The original code effectively did the same thing.  I\u0027ll add something here and fix the other comments.","commit_id":"62eeb0ef6cd4d11eb72611165d719e05ac9b0f8c"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"2102ffc8fa3edabc256f2e2b82c8837fd0274502","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                               sort_key, sort_dir)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    @objects.objectify(objects.Port)"},{"line_number":406,"context_line":"    def get_ports_by_node(self, node_obj, limit\u003dNone, marker\u003dNone,"},{"line_number":407,"context_line":"                          sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":408,"context_line":"        query \u003d model_query(models.Port)"},{"line_number":409,"context_line":"        query \u003d query.filter_by(node_id\u003dnode_obj.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F5%2FQ%3D","line":406,"updated":"2014-04-09 15:22:31.000000000","message":"Why are you naming node_obj instead of just node?","commit_id":"62eeb0ef6cd4d11eb72611165d719e05ac9b0f8c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1fed95b17521d39db91852d7d964c8509cd03e5f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                               sort_key, sort_dir)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    @objects.objectify(objects.Port)"},{"line_number":406,"context_line":"    def get_ports_by_node(self, node_obj, limit\u003dNone, marker\u003dNone,"},{"line_number":407,"context_line":"                          sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":408,"context_line":"        query \u003d model_query(models.Port)"},{"line_number":409,"context_line":"        query \u003d query.filter_by(node_id\u003dnode_obj.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2F39c%3D","line":406,"in_reply_to":"AAAAW3%2F%2F5%2FQ%3D","updated":"2014-04-09 18:53:51.000000000","message":"while the old code created a node_obj object on line 409, the doc string in db.api says this param is just \"node\"...","commit_id":"62eeb0ef6cd4d11eb72611165d719e05ac9b0f8c"}]}