)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c9989e0f6c6e82030f5332f8b9f48bf7b2cd9b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6c987e9_959fb025","updated":"2022-08-03 21:54:34.000000000","message":"LGTM but this is complex enough I think we need more eyes.","commit_id":"f0a1778766d2fbd13dfa7dcf4521004deddcab55"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dbbc85ff58ef790cd8778f9fda15f955e274c944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3db8ddfe_83866d4e","updated":"2022-08-03 08:07:06.000000000","message":"looks good :)","commit_id":"f0a1778766d2fbd13dfa7dcf4521004deddcab55"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"46b851c84bc585f72e0ec2a0e465b2c359bb1cf2","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        return \u0027ramdisk\u0027"},{"line_number":627,"context_line":"    capabilities \u003d utils.parse_instance_info_capabilities(node)"},{"line_number":628,"context_line":"    return capabilities.get(\u0027boot_option\u0027,"},{"line_number":629,"context_line":"                            CONF.deploy.default_boot_option).lower()"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"# FIXME(dtantsur): relying on deploy interface name is an anti-pattern."}],"source_content_type":"text/x-python","patch_set":5,"id":"7acac517_c098d33f","side":"PARENT","line":629,"updated":"2022-08-01 17:34:25.000000000","message":"\\o/","commit_id":"41484988efaa99122bb92b2314f781a53bba6984"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"46b851c84bc585f72e0ec2a0e465b2c359bb1cf2","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# NOTE(TheJulia): This should likely be migrated to pxe_utils."},{"line_number":161,"context_line":"# TODO(dtantsur): with the removal of netboot, root_uuid_or_disk_id and"},{"line_number":162,"context_line":"# the logic of replacing ROOT can be dropped, while is_whole_disk_image can"},{"line_number":163,"context_line":"# be renamed to something like netboot_fallback."},{"line_number":164,"context_line":"def switch_pxe_config(path, root_uuid_or_disk_id, boot_mode,"},{"line_number":165,"context_line":"                      is_whole_disk_image, iscsi_boot\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"19b26e89_d6978be3","line":162,"range":{"start_line":162,"start_character":46,"end_line":162,"end_character":72},"updated":"2022-08-01 17:34:25.000000000","message":"I actually kind of disagree about renaming it, since it has meaning in the code to handle the system, likely not explicitly required I guess, or possibly navigable, but something we should do with lots of caution, if we head down that path.","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"017f73ca184f03bd67e2b5102feff973ed96ce58","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# NOTE(TheJulia): This should likely be migrated to pxe_utils."},{"line_number":161,"context_line":"# TODO(dtantsur): with the removal of netboot, root_uuid_or_disk_id and"},{"line_number":162,"context_line":"# the logic of replacing ROOT can be dropped, while is_whole_disk_image can"},{"line_number":163,"context_line":"# be renamed to something like netboot_fallback."},{"line_number":164,"context_line":"def switch_pxe_config(path, root_uuid_or_disk_id, boot_mode,"},{"line_number":165,"context_line":"                      is_whole_disk_image, iscsi_boot\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"17e2c2f0_4581cf5d","line":162,"range":{"start_line":162,"start_character":46,"end_line":162,"end_character":72},"in_reply_to":"19b26e89_d6978be3","updated":"2022-08-02 10:46:46.000000000","message":"Well, is_whole_disk_image no longer means this. It is set to True unconditionally when netboot fallback is enabled (and False otherwise).","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"46b851c84bc585f72e0ec2a0e465b2c359bb1cf2","unresolved":true,"context_lines":[{"line_number":809,"context_line":""},{"line_number":810,"context_line":"            is_whole_disk_image \u003d node.driver_internal_info.get("},{"line_number":811,"context_line":"                \u0027is_whole_disk_image\u0027)"},{"line_number":812,"context_line":"            # FIXME(dtantsur): is it used for kickstart or can we remove it?"},{"line_number":813,"context_line":"            if (not is_whole_disk_image"},{"line_number":814,"context_line":"                    and boot_option !\u003d \u0027local\u0027"},{"line_number":815,"context_line":"                    and not service_utils.is_glance_image(image_source)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"8e4318aa_2f0e20dc","line":812,"updated":"2022-08-01 17:34:25.000000000","message":"I believe we presently expect is_whole_disk_image to be None for kickstart deploys.  That being said, there *really* wouldn\u0027t be a hard reason preventing it with kickstart, aside from style. That being said, Ansible deployment perhaps?","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"017f73ca184f03bd67e2b5102feff973ed96ce58","unresolved":true,"context_lines":[{"line_number":809,"context_line":""},{"line_number":810,"context_line":"            is_whole_disk_image \u003d node.driver_internal_info.get("},{"line_number":811,"context_line":"                \u0027is_whole_disk_image\u0027)"},{"line_number":812,"context_line":"            # FIXME(dtantsur): is it used for kickstart or can we remove it?"},{"line_number":813,"context_line":"            if (not is_whole_disk_image"},{"line_number":814,"context_line":"                    and boot_option !\u003d \u0027local\u0027"},{"line_number":815,"context_line":"                    and not service_utils.is_glance_image(image_source)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"50327dd4_11c6b984","line":812,"in_reply_to":"8e4318aa_2f0e20dc","updated":"2022-08-02 10:46:46.000000000","message":"IIRC the ansible deploy has never really supported netboot?","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"46b851c84bc585f72e0ec2a0e465b2c359bb1cf2","unresolved":true,"context_lines":[{"line_number":853,"context_line":"    iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":854,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":855,"context_line":"    if not iwdi:"},{"line_number":856,"context_line":"        # FIXME(dtantsur): is it used for kickstart or can we remove it?"},{"line_number":857,"context_line":"        if (i_info[\u0027image_source\u0027]"},{"line_number":858,"context_line":"                and boot_option !\u003d \u0027local\u0027"},{"line_number":859,"context_line":"                and not service_utils.is_glance_image("}],"source_content_type":"text/x-python","patch_set":5,"id":"f431c60e_a0645320","line":856,"updated":"2022-08-01 17:34:25.000000000","message":"kickstart does use it\u0027s own kernel/ramdisk, so yes it is used.","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"017f73ca184f03bd67e2b5102feff973ed96ce58","unresolved":true,"context_lines":[{"line_number":853,"context_line":"    iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":854,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":855,"context_line":"    if not iwdi:"},{"line_number":856,"context_line":"        # FIXME(dtantsur): is it used for kickstart or can we remove it?"},{"line_number":857,"context_line":"        if (i_info[\u0027image_source\u0027]"},{"line_number":858,"context_line":"                and boot_option !\u003d \u0027local\u0027"},{"line_number":859,"context_line":"                and not service_utils.is_glance_image("}],"source_content_type":"text/x-python","patch_set":5,"id":"c7d26aee_da8ba0c7","line":856,"in_reply_to":"f431c60e_a0645320","updated":"2022-08-02 10:46:46.000000000","message":"Ack","commit_id":"a5355073d5519f01e162021dcd4071a2b75872cb"}]}