)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"ea885a6ff6aea0526d0c5d7d0d0114c4713e04c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"740dbabe_03140d86","updated":"2022-07-25 00:57:08.000000000","message":"recheck","commit_id":"e9bdcfb49bf8c89e9afa53d0531f16dc3b9b112f"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"b42d2fa9188dfb0555323e4fe80209ae625cb0b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"199d5450_cf1f374e","updated":"2022-07-27 04:28:10.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7527b974cff01a8bbc550c6f0378e8abcf3cd2a"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"8a11459f542fe84da321e05fe1c96fcdc7a1d90f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e629686_cdcb7558","updated":"2022-07-27 01:43:04.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7527b974cff01a8bbc550c6f0378e8abcf3cd2a"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"de21e2d0b58252bcfb87ece87881358e0c0c4253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b10193df_7bc33d61","updated":"2022-07-28 01:58:51.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7527b974cff01a8bbc550c6f0378e8abcf3cd2a"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"7e7c7cb5b5954928db5f388559c52c285afecbb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b2cc1bfe_17a2fea7","updated":"2022-07-28 10:02:33.000000000","message":"fujitsu-irmc-recheck","commit_id":"c7527b974cff01a8bbc550c6f0378e8abcf3cd2a"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"9db5808c937b484ea8ada4db35f50ef4ff39341b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cc384d6_f3017c6f","updated":"2022-08-19 00:49:41.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"f2057d0553ba5d933f041f3e153357029c19f460","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"40bed09d_3dcdb429","updated":"2022-08-10 08:39:11.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"6fa6eeabcca34af530e8ef357a47fa25cb7e44b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"65eb91ed_a64e44b0","updated":"2022-08-18 06:57:17.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"85e41fbd7387718723b83da30cedc0de601fc201","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"679a0cd0_73369708","updated":"2022-08-19 08:20:29.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"80687198ca50a201eea287ac7609cffa5e3d3875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80f31157_7d4ce577","updated":"2022-08-19 07:19:32.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"f8ef1aa9b508362ee5bea28c066d946dcfc6bc04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"994bb37e_e3550653","updated":"2022-08-18 08:41:47.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"5b931684101e092b279ba885ebe76035bb2c1bfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a812514d_0f49aef0","updated":"2022-08-17 10:09:16.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"d8b2fc9ecd4b6cf14e8e53fd05243b93d2bdb15d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd5648be_67d15784","updated":"2022-08-17 02:56:05.000000000","message":"fujitsu-irmc-recheck","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1d71871d_6eefa493","updated":"2022-08-30 07:20:23.000000000","message":"Hi, Julia. \n\nThe code is updated and is compatible with old version python-scciclient now. \n\nI have tested the yoga patch in a yoga environment. Because the SNMPv3 change in python-scciclient for yoga release is from 0.12.1, so I used 0.12.0 and 0.12.2 to conduct the test and both version worked well.\n\nPlease review this patch again, thanks.","commit_id":"7ccc5d34de014673aa0bfa18836538766c3bdfdf"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"df3e1c37fd30c0a9cd6e68cefee7d452ab738aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"54d6e7d2_d8d0af25","updated":"2022-09-01 12:23:44.000000000","message":"The version check is bad and need to wait for the HTTPS patch as there may be some check function that this patch can use.","commit_id":"2ba65c9411c960ae6e604d0ff5c3d043b217e2d1"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"4b28a71cd35f56f05dfb10e67f27fc0e95a54580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"71ed1994_6e95a020","updated":"2022-09-06 01:56:11.000000000","message":"Hi, Julia.\n\nI have also updated this xena backport patch and done the same tests like yoga with the same python-scciclient versions and also all the tests passed.\n\nPlease also take a look at this one, thanks.","commit_id":"b60fb1a76f2830b4519c2fca1e073050a387fb97"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"c2f6cf92689059b4940d53db23b41ba021719e15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cdda2ef2_78b82c4c","updated":"2022-09-12 04:38:19.000000000","message":"Hi, Julia. Please also help review this patch, thanks.","commit_id":"b60fb1a76f2830b4519c2fca1e073050a387fb97"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"3d4a0814b1236b975183649c7d4c33296a5b8022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"506465ce_cc2a7bbb","updated":"2022-09-16 09:15:22.000000000","message":"fujitsu-irmc-recheck","commit_id":"b60fb1a76f2830b4519c2fca1e073050a387fb97"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"615179c7eb9a627be99df45bc357aa8e6f33a1ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7b03586f_ab0f500d","updated":"2022-09-20 00:46:07.000000000","message":"fujitsu-irmc-recheck","commit_id":"b60fb1a76f2830b4519c2fca1e073050a387fb97"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"6b9d0c256c3a26acc2fe6e58c3dd2349f9edeae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cf093af6_aeec34bc","updated":"2022-09-12 09:50:57.000000000","message":"fujitsu-irmc-recheck","commit_id":"b60fb1a76f2830b4519c2fca1e073050a387fb97"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"5d374a8b020fdc8bbf796774296a2f981663e739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"358929bb_61674e39","updated":"2022-11-15 09:54:48.000000000","message":"Riccardo, thanks for the review. Code updated.","commit_id":"ef0e33edf2b0420dc7fe851e41128ff86dc8ffed"}],"driver-requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.11.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.11.4,\u003c0.12"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c8.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"ad4fc146_b9651a54","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":31},"updated":"2022-08-01 17:03:52.000000000","message":"Greetings,\n\nSo we\u0027ve discussed this as a community, and we\u0027re concerned about the version constraint. Expect additional contributor comments as they find time to review this code.\n\nRealistically, there is no guarantee any downstream has 0.11.4, which means merging this will immediately be breaking for those pipelines and consumers.\n\nWe\u0027ve also observed internal changes in python-scciclient:\n\nhttps://opendev.org/x/python-scciclient/commit/04bb48cc814b6bdf8f9dc118722b2b8a398c5a6f\n\nSpecifically:\n1) community was renamed to read_community, which is a breaking change, albeit doesn\u0027t appear since the argument usage previously is positional.\n2) write_community was added instead of snmp_security, which incidentally was removed.\n\nWhich realistically means older versions of the library cannot be used, since the original, released declaration was \u003e\u003d0.8.0.\n\nIt also means that any packager which doesn\u0027t use requirements.txt will be broken by merging this change. As a community, we recommend changing the constraint to be \u003e\u003d0.8.0,\u003c0.12, and then support both versions, with raise of an explicit error if a configuration is requested that is impossible to support.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.11.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.11.4,\u003c0.12"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c8.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"af0ccec0_6e0b1398","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":31},"in_reply_to":"ad4fc146_b9651a54","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"}],"ironic/conf/irmc.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027SNMP community. Required for versions \"v1\" and \"v2c\"\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027snmp_security\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\"SNMP security name. Required for version \u0027v3\u0027.\"),"},{"line_number":77,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"               deprecated_reason\u003d_(\"Use irmc_snmp_user\")),"},{"line_number":79,"context_line":"    cfg.IntOpt(\u0027snmp_polling_interval\u0027,"},{"line_number":80,"context_line":"               default\u003d10,"},{"line_number":81,"context_line":"               help\u003d\u0027SNMP polling interval in seconds\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"08a7a650_0330db65","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":58},"updated":"2022-08-01 17:03:52.000000000","message":"So we\u0027re really not supposed to backport and merge deprecation.\n\nIdeall the code should support both, and the help text might wish to indicate what is explicitly required.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027SNMP community. Required for versions \"v1\" and \"v2c\"\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027snmp_security\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\"SNMP security name. Required for version \u0027v3\u0027.\"),"},{"line_number":77,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"               deprecated_reason\u003d_(\"Use irmc_snmp_user\")),"},{"line_number":79,"context_line":"    cfg.IntOpt(\u0027snmp_polling_interval\u0027,"},{"line_number":80,"context_line":"               default\u003d10,"},{"line_number":81,"context_line":"               help\u003d\u0027SNMP polling interval in seconds\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"a381109a_53d00447","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":58},"in_reply_to":"08a7a650_0330db65","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dfa070400c9dc6ef90cbe8db1951a5a1fb4a8b62","unresolved":true,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027SNMP community. Required for versions \"v1\" and \"v2c\"\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027snmp_security\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\"SNMP security name. Required for version \u0027v3\u0027. Will be \""},{"line_number":77,"context_line":"                      \"ignored if driver_info/irmc_snmp_uer is set.\")),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027snmp_polling_interval\u0027,"},{"line_number":79,"context_line":"               default\u003d10,"},{"line_number":80,"context_line":"               help\u003d\u0027SNMP polling interval in seconds\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9b1ab6aa_2ff38496","line":77,"range":{"start_line":77,"start_character":46,"end_line":77,"end_character":59},"updated":"2022-11-15 08:28:26.000000000","message":"nit: irmc_snmp_user","commit_id":"30f4f52eabc3390879d2a2d96658c01c5dc3b159"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"5d374a8b020fdc8bbf796774296a2f981663e739","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027SNMP community. Required for versions \"v1\" and \"v2c\"\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027snmp_security\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\"SNMP security name. Required for version \u0027v3\u0027. Will be \""},{"line_number":77,"context_line":"                      \"ignored if driver_info/irmc_snmp_uer is set.\")),"},{"line_number":78,"context_line":"    cfg.IntOpt(\u0027snmp_polling_interval\u0027,"},{"line_number":79,"context_line":"               default\u003d10,"},{"line_number":80,"context_line":"               help\u003d\u0027SNMP polling interval in seconds\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"188b8ff6_82e408a8","line":77,"range":{"start_line":77,"start_character":46,"end_line":77,"end_character":59},"in_reply_to":"9b1ab6aa_2ff38496","updated":"2022-11-15 09:54:48.000000000","message":"Done","commit_id":"30f4f52eabc3390879d2a2d96658c01c5dc3b159"}],"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            if param \u003d\u003d \u0027irmc_snmp_user\u0027:"},{"line_number":208,"context_line":"                if not security:"},{"line_number":209,"context_line":"                    missing_info.append(param)"},{"line_number":210,"context_line":"                else:"},{"line_number":211,"context_line":"                    LOG.warning(_(\"\u0027irmc_snmp_security\u0027 parameter is \""},{"line_number":212,"context_line":"                                  \"deprecated in favor of \u0027irmc_snmp_user\u0027 \""},{"line_number":213,"context_line":"                                  \"parameter. Please set \u0027irmc_snmp_user\u0027 \""},{"line_number":214,"context_line":"                                  \"and remove \u0027irmc_snmp_security\u0027 for node \""},{"line_number":215,"context_line":"                                  \"%s.\"), node.uuid)"},{"line_number":216,"context_line":"                    # In iRMC, the username must start with a letter, so only"},{"line_number":217,"context_line":"                    # a string can be a valid username and a string from a"},{"line_number":218,"context_line":"                    # number is invalid."}],"source_content_type":"text/x-python","patch_set":5,"id":"d109ccfe_b32a2eb1","line":215,"range":{"start_line":210,"start_character":0,"end_line":215,"end_character":52},"updated":"2022-08-01 17:03:52.000000000","message":"Is there any way to support both and just handle it in a backport?","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            if param \u003d\u003d \u0027irmc_snmp_user\u0027:"},{"line_number":208,"context_line":"                if not security:"},{"line_number":209,"context_line":"                    missing_info.append(param)"},{"line_number":210,"context_line":"                else:"},{"line_number":211,"context_line":"                    LOG.warning(_(\"\u0027irmc_snmp_security\u0027 parameter is \""},{"line_number":212,"context_line":"                                  \"deprecated in favor of \u0027irmc_snmp_user\u0027 \""},{"line_number":213,"context_line":"                                  \"parameter. Please set \u0027irmc_snmp_user\u0027 \""},{"line_number":214,"context_line":"                                  \"and remove \u0027irmc_snmp_security\u0027 for node \""},{"line_number":215,"context_line":"                                  \"%s.\"), node.uuid)"},{"line_number":216,"context_line":"                    # In iRMC, the username must start with a letter, so only"},{"line_number":217,"context_line":"                    # a string can be a valid username and a string from a"},{"line_number":218,"context_line":"                    # number is invalid."}],"source_content_type":"text/x-python","patch_set":5,"id":"4e6f188b_fca57121","line":215,"range":{"start_line":210,"start_character":0,"end_line":215,"end_character":52},"in_reply_to":"d109ccfe_b32a2eb1","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"}],"ironic/drivers/modules/irmc/inspect.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        auth_proto\u003dd_info.get(\u0027irmc_snmp_auth_proto\u0027),"},{"line_number":113,"context_line":"        auth_key\u003dd_info.get(\u0027irmc_snmp_auth_password\u0027),"},{"line_number":114,"context_line":"        priv_proto\u003dd_info.get(\u0027irmc_snmp_priv_proto\u0027),"},{"line_number":115,"context_line":"        priv_key\u003dd_info.get(\u0027irmc_snmp_priv_password\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    node_classes \u003d snmp_client.get_next(NODE_CLASS_OID)"},{"line_number":118,"context_line":"    mac_addresses \u003d [\u0027:\u0027.join([\u0027%02x\u0027 % x for x in mac])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3745de86_88d55d7b","line":115,"updated":"2022-08-01 17:03:52.000000000","message":"Is there any way to make this version safe, specifically so 0.8.x can be supported and cleanly backported so we don\u0027t break packagers or their users/customers.\n\nPerhaps, check the python-scciclient version and perform a client invocation depending on the version?","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        auth_proto\u003dd_info.get(\u0027irmc_snmp_auth_proto\u0027),"},{"line_number":113,"context_line":"        auth_key\u003dd_info.get(\u0027irmc_snmp_auth_password\u0027),"},{"line_number":114,"context_line":"        priv_proto\u003dd_info.get(\u0027irmc_snmp_priv_proto\u0027),"},{"line_number":115,"context_line":"        priv_key\u003dd_info.get(\u0027irmc_snmp_priv_password\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    node_classes \u003d snmp_client.get_next(NODE_CLASS_OID)"},{"line_number":118,"context_line":"    mac_addresses \u003d [\u0027:\u0027.join([\u0027%02x\u0027 % x for x in mac])"}],"source_content_type":"text/x-python","patch_set":5,"id":"463a8c2f_ea60383c","line":115,"in_reply_to":"3745de86_88d55d7b","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"}],"ironic/drivers/modules/irmc/power.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        auth_proto\u003dd_info.get(\u0027irmc_snmp_auth_proto\u0027),"},{"line_number":103,"context_line":"        auth_key\u003dd_info.get(\u0027irmc_snmp_auth_password\u0027),"},{"line_number":104,"context_line":"        priv_proto\u003dd_info.get(\u0027irmc_snmp_priv_proto\u0027),"},{"line_number":105,"context_line":"        priv_key\u003dd_info.get(\u0027irmc_snmp_priv_password\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    interval \u003d CONF.irmc.snmp_polling_interval"},{"line_number":108,"context_line":"    retry_timeout_soft \u003d timeout or CONF.conductor.soft_power_off_timeout"}],"source_content_type":"text/x-python","patch_set":5,"id":"0aa19e19_d0ea927e","line":105,"updated":"2022-08-01 17:03:52.000000000","message":"Same comment that I have on inspect.py for this.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        auth_proto\u003dd_info.get(\u0027irmc_snmp_auth_proto\u0027),"},{"line_number":103,"context_line":"        auth_key\u003dd_info.get(\u0027irmc_snmp_auth_password\u0027),"},{"line_number":104,"context_line":"        priv_proto\u003dd_info.get(\u0027irmc_snmp_priv_proto\u0027),"},{"line_number":105,"context_line":"        priv_key\u003dd_info.get(\u0027irmc_snmp_priv_password\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    interval \u003d CONF.irmc.snmp_polling_interval"},{"line_number":108,"context_line":"    retry_timeout_soft \u003d timeout or CONF.conductor.soft_power_off_timeout"}],"source_content_type":"text/x-python","patch_set":5,"id":"644d7622_b770be7a","line":105,"in_reply_to":"0aa19e19_d0ea927e","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"}],"releasenotes/notes/irmc-add-snmpv3-security-fca05bfc30f50d1a.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds SNMPv3 message authentication and encryption features to iRMC driver."},{"line_number":5,"context_line":"    To enable these features, the following parameters should be used in the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1ad963f_2fa6d584","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":9},"updated":"2022-08-01 17:03:52.000000000","message":"Backporting a feature is against backport policy:\n\nhttps://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines\n\nSpecifically, in discussion among the team, we believe this change is somewhat along the lines of a bugfix, since the preexisting code refers to snmpv3.\n\nIf we can re-frame this as a bug fix, this would be easier to accept.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds SNMPv3 message authentication and encryption features to iRMC driver."},{"line_number":5,"context_line":"    To enable these features, the following parameters should be used in the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e33ba9d6_0569984e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":9},"in_reply_to":"d1ad963f_2fa6d584","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    * ``snmp_auth_proto``"},{"line_number":19,"context_line":"    * ``snmp_priv_proto``"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"deprecations:"},{"line_number":22,"context_line":"  - |"},{"line_number":23,"context_line":"    Deprecates the ``irmc_snmp_security`` field in ``driver_info`` for iRMC"},{"line_number":24,"context_line":"    driver, it will be removed in the future. Please use ``irmc_snmp_user``"},{"line_number":25,"context_line":"    field instead."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"other:"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    Updates the minimum version of ``python-scciclient`` library to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a4e4e0aa_40251dd3","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":0},"updated":"2022-08-01 17:03:52.000000000","message":"We really can\u0027t backport deprecation changes.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    * ``snmp_auth_proto``"},{"line_number":19,"context_line":"    * ``snmp_priv_proto``"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"deprecations:"},{"line_number":22,"context_line":"  - |"},{"line_number":23,"context_line":"    Deprecates the ``irmc_snmp_security`` field in ``driver_info`` for iRMC"},{"line_number":24,"context_line":"    driver, it will be removed in the future. Please use ``irmc_snmp_user``"},{"line_number":25,"context_line":"    field instead."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"other:"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    Updates the minimum version of ``python-scciclient`` library to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"15f94e6d_5b2e0170","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":0},"in_reply_to":"a4e4e0aa_40251dd3","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"325aac3fa31a5726f76efa9358f374e26098c554","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"other:"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    Updates the minimum version of ``python-scciclient`` library to"},{"line_number":30,"context_line":"    ``0.12.1``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6e12fbd4_78ed42dd","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":15},"updated":"2022-08-01 17:03:52.000000000","message":"This is incorrect, the current patch bounds it. \u003c0.12","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"97aafb7f79cc020999c0978e754343a772fcef33","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"other:"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    Updates the minimum version of ``python-scciclient`` library to"},{"line_number":30,"context_line":"    ``0.12.1``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e78ab12e_ebb348f8","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":15},"in_reply_to":"25fb3426_4f383910","updated":"2022-08-30 07:20:23.000000000","message":"Done","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1d136383d4bc30262b797fad4b2d6c7a2d7f1b35","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"other:"},{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    Updates the minimum version of ``python-scciclient`` library to"},{"line_number":30,"context_line":"    ``0.12.1``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"25fb3426_4f383910","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":15},"in_reply_to":"6e12fbd4_78ed42dd","updated":"2022-08-10 15:01:34.000000000","message":"I believe, this would need to be in the 0.11.x range, not 0.12.x range, to align with packager expectations.","commit_id":"c8338f9dcc0a30c97386d121e0532ff6b788b1d0"}]}