)]}'
{"ironic/nova/tests/virt/ironic/test_driver.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"34494b8a3b8c5537e7236372cac3ce2c88baaa19","unresolved":false,"context_lines":[{"line_number":899,"context_line":"                             driver\u003d\u0027agent\u0027)"},{"line_number":900,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx,"},{"line_number":901,"context_line":"                                                   uuid\u003dinstance_uuid)"},{"line_number":902,"context_line":"        with mock.patch.object(FAKE_CLIENT.node, \u0027update\u0027) as mock_update:"},{"line_number":903,"context_line":"            self.driver._add_driver_fields(node, instance, {\u0027id\u0027: \u0027test\u0027})"},{"line_number":904,"context_line":"            mock_update.assert_called_once_with(node_uuid, expected_body)"},{"line_number":905,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FrO4%3D","line":902,"updated":"2014-04-11 08:22:22.000000000","message":"Please use mock-decorator :)","commit_id":"ecb5113ca26f619b8aced762cd9f442cc59554e3"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"34494b8a3b8c5537e7236372cac3ce2c88baaa19","unresolved":false,"context_lines":[{"line_number":919,"context_line":"                             driver\u003d\u0027agent\u0027)"},{"line_number":920,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.ctx,"},{"line_number":921,"context_line":"                                                   uuid\u003dinstance_uuid)"},{"line_number":922,"context_line":"        with mock.patch.object(FAKE_CLIENT.node, \u0027update\u0027) as mock_update:"},{"line_number":923,"context_line":"            self.driver._cleanup_deploy(node, instance, {})"},{"line_number":924,"context_line":"            self.assertEqual(2, mock_update.call_count)"},{"line_number":925,"context_line":"            expected_calls \u003d [mock.call(node_uuid, uuid_body),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FrOg%3D","line":922,"updated":"2014-04-11 08:22:22.000000000","message":"ditto","commit_id":"ecb5113ca26f619b8aced762cd9f442cc59554e3"}],"ironic/nova/virt/ironic/driver.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"6c53da740ea2a1837366601516f7016b39590109","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        elif \u0027agent\u0027 in node.driver:"},{"line_number":259,"context_line":"            fields \u003d importutils.import_class("},{"line_number":260,"context_line":"                \u0027ironic.nova.virt.ironic.ironic_driver_fields.Agent\u0027)"},{"line_number":261,"context_line":"            # TODO(jimrollenhagen) also add configdrive here"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if fields:"},{"line_number":264,"context_line":"            patch \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FhC0%3D","line":261,"updated":"2014-04-14 02:35:54.000000000","message":"We have duplicate code to import class with these lines L255-L261 and L302-L309, so how do you think if it is better we can define a common method to share the same logic?\n\n\ndef _import_driver_class(self, driver_name, node):\n    if driver_name in node.driver:\n        fields \u003d importutils.import_class(\n            \u0027ironic.nova.virt.ironic.ironic_driver_fields.\u0027 + driver_name)\n    return fields","commit_id":"3723172c331e0e4b42a37b517d5798e03fd569ce"}]}