)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    ironic/tests/unit/drivers/modules/irmc/test_common.py"},{"line_number":18,"context_line":"    ironic/tests/unit/drivers/modules/irmc/test_power.py"},{"line_number":19,"context_line":"    releasenotes/notes/irmc-add-certification-file-option-34e7a0062c768e58.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ironic/+/852509"},{"line_number":22,"context_line":"Change-Id: If69ce1cf2789d9d60fb8e544596cf7d29eab514d"},{"line_number":23,"context_line":"Co-authored-by: Kobayashi Daisuke \u003ckobayashi.da-06@fujitsu.com\u003e"},{"line_number":24,"context_line":"Co-authored-by: Song Shukun \u003csong.shukun@jp.fujitsu.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ac1352af_b3e356d8","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":66},"updated":"2022-08-16 15:08:32.000000000","message":"fwiw, this is not needed as the patch has already merged, but it is not hurting anything as this is on the correct branch.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    ironic/tests/unit/drivers/modules/irmc/test_common.py"},{"line_number":18,"context_line":"    ironic/tests/unit/drivers/modules/irmc/test_power.py"},{"line_number":19,"context_line":"    releasenotes/notes/irmc-add-certification-file-option-34e7a0062c768e58.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ironic/+/852509"},{"line_number":22,"context_line":"Change-Id: If69ce1cf2789d9d60fb8e544596cf7d29eab514d"},{"line_number":23,"context_line":"Co-authored-by: Kobayashi Daisuke \u003ckobayashi.da-06@fujitsu.com\u003e"},{"line_number":24,"context_line":"Co-authored-by: Song Shukun \u003csong.shukun@jp.fujitsu.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"211e433f_75223deb","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":66},"in_reply_to":"ac1352af_b3e356d8","updated":"2022-08-17 11:51:55.000000000","message":"Got it.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ffbdf4292802e34fd98e65a4f0ec04abc43ad5a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35ef3887_39647a00","updated":"2022-08-11 16:06:53.000000000","message":"I did not review the code once I found the requirement change; we typically do not change requirements in stable branches.","commit_id":"48e54717935ff32257e8863da7d8083153f1d382"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"294ed379a2e215be31116120150193c1e1584b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a545784a_3d9d174b","updated":"2022-08-25 14:38:55.000000000","message":"Thanks.","commit_id":"223b75c471eeda493415923206b854eeee17f958"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"71d666cf2da577a313176708d22e6cd10403acf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4b7d5d83_d119f29e","updated":"2022-08-19 17:28:23.000000000","message":"Two relatively minor items need to be fixed, but aside from the noted Ititems this looks good to me.","commit_id":"223b75c471eeda493415923206b854eeee17f958"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54fd259c749c745abafac4b047521b9f8d830b6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5608173f_f21e1e6d","updated":"2022-08-25 15:47:28.000000000","message":"I see only one issue. See the release note.","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7f2b12f5d462ab479ed4681afaf51e8a0d46c0e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6cd49cb4_a12af1d2","updated":"2022-08-25 15:51:12.000000000","message":"Sorry. I forgot to revert it to True. Thanks.","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7bf496ff2fbc2bd21e64b7297b83eaca0614420b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a194e10f_83a38866","updated":"2022-08-30 14:59:01.000000000","message":"Thanks Ironic team for review. This patch passes Fujitsu 3rd party CI test. So, if possible, please take time to review this.","commit_id":"6c0152afa141d05ee28cba81178622021574ae17"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"6d5f14b4ab3c9d83c8241dcb8ec3506f6e82d986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"19ace2e1_e1279eef","updated":"2022-08-30 07:59:34.000000000","message":"fujitsu-irmc-recheck","commit_id":"6c0152afa141d05ee28cba81178622021574ae17"},{"author":{"_account_id":34597,"name":"KOBAYASHI DAISUKE","email":"kobayashi.da-06@fujitsu.com","username":"kobayashi-da"},"change_message_id":"06d1d774fe37a11331b7bcd3211efdac46447650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"73c6d236_efd1b9fa","updated":"2022-08-30 03:35:33.000000000","message":"fujitsu-irmc-recheck","commit_id":"6c0152afa141d05ee28cba81178622021574ae17"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3ec6f199ca68d541856b29c34b911b5135b18f21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a5ed0753_6d9d7d32","updated":"2022-08-30 05:54:03.000000000","message":"fujitsu-irmc-recheck","commit_id":"6c0152afa141d05ee28cba81178622021574ae17"}],"driver-requirements.txt":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ffbdf4292802e34fd98e65a4f0ec04abc43ad5a4","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.13.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c9.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"d1d103a9_e6b98999","line":9,"updated":"2022-08-11 16:06:53.000000000","message":"We typically do not permit upgrades of dependencies in stable branches. Unless this change can be made compatible with the existing client version used in Yoga, this backport is unlikely to merge.","commit_id":"48e54717935ff32257e8863da7d8083153f1d382"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"85b754f41f53dc72d39c3a4caa31e73773b88bc7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.13.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c9.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"8bd73291_941961fd","line":9,"in_reply_to":"19cc387d_6209223e","updated":"2022-08-15 14:45:35.000000000","message":"Thanks for review. I reverts driver-requirements.txt and modify code to handle  python-scciclient version.","commit_id":"48e54717935ff32257e8863da7d8083153f1d382"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"38ef792a60851f0a450aed19466dbd9a371ecd95","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.13.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c9.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"19cc387d_6209223e","line":9,"in_reply_to":"c0cbe11a_5e762c49","updated":"2022-08-11 16:21:43.000000000","message":"I don\u0027t think it would be a good idea to raise the min-version in stable/branches (having \u003c0.13.0 is ok, but \u003e\u003d0.12.0 when we had 0.8.0 before, makes me a bit worried..","commit_id":"48e54717935ff32257e8863da7d8083153f1d382"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0c745e91de07f0608661884793bbf6ac64a91c9c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# These are available on pypi"},{"line_number":7,"context_line":"proliantutils\u003e\u003d2.13.0"},{"line_number":8,"context_line":"pysnmp\u003e\u003d4.3.0,\u003c5.0.0"},{"line_number":9,"context_line":"python-scciclient\u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":10,"context_line":"python-dracclient\u003e\u003d5.1.0,\u003c9.0.0"},{"line_number":11,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":12,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"c0cbe11a_5e762c49","line":9,"in_reply_to":"d1d103a9_e6b98999","updated":"2022-08-11 16:11:49.000000000","message":"One good alternative would be to push a stable update to python-scciclient so this pin becomes unneeded.","commit_id":"48e54717935ff32257e8863da7d8083153f1d382"}],"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    {\u0027min\u0027: \u00270.9.4\u0027, \u0027upp\u0027: \u00270.10.0\u0027},"},{"line_number":78,"context_line":"    {\u0027min\u0027: \u00270.10.1\u0027, \u0027upp\u0027: \u00270.11.0\u0027},"},{"line_number":79,"context_line":"    {\u0027min\u0027: \u00270.11.3\u0027, \u0027upp\u0027: \u00270.12.0\u0027},"},{"line_number":80,"context_line":"    {\u0027min\u0027: \u00270.12.0\u0027, \u0027upp\u0027: \u00270.13.0\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def version_lt(v1, v2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"77afe60a_5290b571","line":80,"updated":"2022-08-16 15:08:32.000000000","message":"I kind of like this approach, since it avoids doing constraining down the version and still enables the capability. But wouldn\u0027t we *want* the user to upgrade to at least 0.8.2 in general?","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6c97a82189c20979d81ff741f32eb3000e62b666","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    {\u0027min\u0027: \u00270.9.4\u0027, \u0027upp\u0027: \u00270.10.0\u0027},"},{"line_number":78,"context_line":"    {\u0027min\u0027: \u00270.10.1\u0027, \u0027upp\u0027: \u00270.11.0\u0027},"},{"line_number":79,"context_line":"    {\u0027min\u0027: \u00270.11.3\u0027, \u0027upp\u0027: \u00270.12.0\u0027},"},{"line_number":80,"context_line":"    {\u0027min\u0027: \u00270.12.0\u0027, \u0027upp\u0027: \u00270.13.0\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def version_lt(v1, v2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"6c0840b2_a42b5d00","line":80,"in_reply_to":"65e851c1_67d23188","updated":"2022-08-18 00:12:18.000000000","message":"Thanks","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    {\u0027min\u0027: \u00270.9.4\u0027, \u0027upp\u0027: \u00270.10.0\u0027},"},{"line_number":78,"context_line":"    {\u0027min\u0027: \u00270.10.1\u0027, \u0027upp\u0027: \u00270.11.0\u0027},"},{"line_number":79,"context_line":"    {\u0027min\u0027: \u00270.11.3\u0027, \u0027upp\u0027: \u00270.12.0\u0027},"},{"line_number":80,"context_line":"    {\u0027min\u0027: \u00270.12.0\u0027, \u0027upp\u0027: \u00270.13.0\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def version_lt(v1, v2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3d48c1_952c3155","line":80,"in_reply_to":"77afe60a_5290b571","updated":"2022-08-17 11:51:55.000000000","message":"I think this approach may want the user to upgrade to at least 0.8.2. I take this approach because I think there can be user who uses upstream code and manages module version themselves.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41af929f2ace78f50cb88303ebd1529b517c2cd5","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    {\u0027min\u0027: \u00270.9.4\u0027, \u0027upp\u0027: \u00270.10.0\u0027},"},{"line_number":78,"context_line":"    {\u0027min\u0027: \u00270.10.1\u0027, \u0027upp\u0027: \u00270.11.0\u0027},"},{"line_number":79,"context_line":"    {\u0027min\u0027: \u00270.11.3\u0027, \u0027upp\u0027: \u00270.12.0\u0027},"},{"line_number":80,"context_line":"    {\u0027min\u0027: \u00270.12.0\u0027, \u0027upp\u0027: \u00270.13.0\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def version_lt(v1, v2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"65e851c1_67d23188","line":80,"in_reply_to":"df3d48c1_952c3155","updated":"2022-08-17 17:12:15.000000000","message":"I think this is reasonable.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def version_le(v1, v2):"},{"line_number":101,"context_line":"    v1_l \u003d v1.split(\u0027.\u0027)"},{"line_number":102,"context_line":"    v2_l \u003d v2.split(\u0027.\u0027)"},{"line_number":103,"context_line":"    if len(v1_l) \u003c\u003d len(v2_l):"},{"line_number":104,"context_line":"        v1_l.extend([\u00270\u0027] * (len(v2_l) - len(v1_l)))"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        v2_l.extend([\u00270\u0027] * (len(v1_l) - len(v2_l)))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    for i in range(len(v1_l)):"},{"line_number":109,"context_line":"        if int(v1_l[i]) \u003c int(v2_l[i]):"},{"line_number":110,"context_line":"            return True"},{"line_number":111,"context_line":"        elif int(v1_l[i]) \u003e int(v2_l[i]):"},{"line_number":112,"context_line":"            return False"},{"line_number":113,"context_line":"    else:"},{"line_number":114,"context_line":"        return True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def scci_support_certification():"},{"line_number":118,"context_line":"    scciclient_version \u003d scci_mod.__version__"}],"source_content_type":"text/x-python","patch_set":7,"id":"0707ccd7_01aef06e","line":115,"range":{"start_line":101,"start_character":0,"end_line":115,"end_character":0},"updated":"2022-08-16 15:08:32.000000000","message":"you may want to consider taking a look at https://stackoverflow.com/questions/11887762/how-do-i-compare-version-numbers-in-python\n\nIt would make it easier, I think.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def version_le(v1, v2):"},{"line_number":101,"context_line":"    v1_l \u003d v1.split(\u0027.\u0027)"},{"line_number":102,"context_line":"    v2_l \u003d v2.split(\u0027.\u0027)"},{"line_number":103,"context_line":"    if len(v1_l) \u003c\u003d len(v2_l):"},{"line_number":104,"context_line":"        v1_l.extend([\u00270\u0027] * (len(v2_l) - len(v1_l)))"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        v2_l.extend([\u00270\u0027] * (len(v1_l) - len(v2_l)))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    for i in range(len(v1_l)):"},{"line_number":109,"context_line":"        if int(v1_l[i]) \u003c int(v2_l[i]):"},{"line_number":110,"context_line":"            return True"},{"line_number":111,"context_line":"        elif int(v1_l[i]) \u003e int(v2_l[i]):"},{"line_number":112,"context_line":"            return False"},{"line_number":113,"context_line":"    else:"},{"line_number":114,"context_line":"        return True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def scci_support_certification():"},{"line_number":118,"context_line":"    scciclient_version \u003d scci_mod.__version__"}],"source_content_type":"text/x-python","patch_set":7,"id":"b91ab582_02c1bb30","line":115,"range":{"start_line":101,"start_character":0,"end_line":115,"end_character":0},"in_reply_to":"0707ccd7_01aef06e","updated":"2022-08-17 11:51:55.000000000","message":"Thanks for recommendation. If I use packaging module, does it mean I need to add packaging line to requirements.txt? I\u0027m not sure it\u0027s acceptable to add new line to requirements.txt.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"41af929f2ace78f50cb88303ebd1529b517c2cd5","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def version_le(v1, v2):"},{"line_number":101,"context_line":"    v1_l \u003d v1.split(\u0027.\u0027)"},{"line_number":102,"context_line":"    v2_l \u003d v2.split(\u0027.\u0027)"},{"line_number":103,"context_line":"    if len(v1_l) \u003c\u003d len(v2_l):"},{"line_number":104,"context_line":"        v1_l.extend([\u00270\u0027] * (len(v2_l) - len(v1_l)))"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        v2_l.extend([\u00270\u0027] * (len(v1_l) - len(v2_l)))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    for i in range(len(v1_l)):"},{"line_number":109,"context_line":"        if int(v1_l[i]) \u003c int(v2_l[i]):"},{"line_number":110,"context_line":"            return True"},{"line_number":111,"context_line":"        elif int(v1_l[i]) \u003e int(v2_l[i]):"},{"line_number":112,"context_line":"            return False"},{"line_number":113,"context_line":"    else:"},{"line_number":114,"context_line":"        return True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def scci_support_certification():"},{"line_number":118,"context_line":"    scciclient_version \u003d scci_mod.__version__"}],"source_content_type":"text/x-python","patch_set":7,"id":"d9462791_48dc6327","line":115,"range":{"start_line":101,"start_character":0,"end_line":115,"end_character":0},"in_reply_to":"b91ab582_02c1bb30","updated":"2022-08-17 17:12:15.000000000","message":"packaging listed in the overall openstack requirements, so it should be fine to add.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"6c97a82189c20979d81ff741f32eb3000e62b666","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def version_le(v1, v2):"},{"line_number":101,"context_line":"    v1_l \u003d v1.split(\u0027.\u0027)"},{"line_number":102,"context_line":"    v2_l \u003d v2.split(\u0027.\u0027)"},{"line_number":103,"context_line":"    if len(v1_l) \u003c\u003d len(v2_l):"},{"line_number":104,"context_line":"        v1_l.extend([\u00270\u0027] * (len(v2_l) - len(v1_l)))"},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        v2_l.extend([\u00270\u0027] * (len(v1_l) - len(v2_l)))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    for i in range(len(v1_l)):"},{"line_number":109,"context_line":"        if int(v1_l[i]) \u003c int(v2_l[i]):"},{"line_number":110,"context_line":"            return True"},{"line_number":111,"context_line":"        elif int(v1_l[i]) \u003e int(v2_l[i]):"},{"line_number":112,"context_line":"            return False"},{"line_number":113,"context_line":"    else:"},{"line_number":114,"context_line":"        return True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def scci_support_certification():"},{"line_number":118,"context_line":"    scciclient_version \u003d scci_mod.__version__"}],"source_content_type":"text/x-python","patch_set":7,"id":"35109c54_613cbcb2","line":115,"range":{"start_line":101,"start_character":0,"end_line":115,"end_character":0},"in_reply_to":"d9462791_48dc6327","updated":"2022-08-18 00:12:18.000000000","message":"Thanks. I added it to list.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    verify_ca \u003d d_info.get(\u0027irmc_verify_ca\u0027)"},{"line_number":200,"context_line":"    if verify_ca is None:"},{"line_number":201,"context_line":"        d_info[\u0027irmc_verify_ca\u0027] \u003d verify_ca \u003d False"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    # Check if verify_ca is a Boolean or a file/directory in the file-system"},{"line_number":204,"context_line":"    if isinstance(verify_ca, str):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f62c5c4d_ff6dce14","line":201,"range":{"start_line":201,"start_character":47,"end_line":201,"end_character":52},"updated":"2022-08-16 15:08:32.000000000","message":"shouldn\u0027t this realistically be CONF.webserver_verify_ca ?\n\nIt could be breaking upon a minor update though.  Maybe the alternative is to explicitly log a warning?","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    verify_ca \u003d d_info.get(\u0027irmc_verify_ca\u0027)"},{"line_number":200,"context_line":"    if verify_ca is None:"},{"line_number":201,"context_line":"        d_info[\u0027irmc_verify_ca\u0027] \u003d verify_ca \u003d False"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    # Check if verify_ca is a Boolean or a file/directory in the file-system"},{"line_number":204,"context_line":"    if isinstance(verify_ca, str):"}],"source_content_type":"text/x-python","patch_set":7,"id":"932a1bf8_46c0105c","line":201,"range":{"start_line":201,"start_character":47,"end_line":201,"end_character":52},"in_reply_to":"f62c5c4d_ff6dce14","updated":"2022-08-17 11:51:55.000000000","message":"Yes. Your point is correct. It should be same as master.","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"}],"ironic/tests/unit/drivers/modules/irmc/test_common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"71d666cf2da577a313176708d22e6cd10403acf8","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    @mock.patch.object(irmc_common, \u0027scci\u0027,"},{"line_number":199,"context_line":"                       spec_set\u003dmock_specs.SCCICLIENT_IRMC_SCCI_SPEC)"},{"line_number":200,"context_line":"    def test_get_irmc_client_cert_support(self, mock_scci, mock_scciclient):"},{"line_number":201,"context_line":"        mock_scciclient.__version__ \u003d \u00270.8.2\u0027"},{"line_number":202,"context_line":"        self.info[\u0027irmc_port\u0027] \u003d 80"},{"line_number":203,"context_line":"        self.info[\u0027irmc_auth_method\u0027] \u003d \u0027digest\u0027"},{"line_number":204,"context_line":"        self.info[\u0027irmc_client_timeout\u0027] \u003d 60"}],"source_content_type":"text/x-python","patch_set":11,"id":"c484f01d_3fd83e96","line":201,"updated":"2022-08-19 17:28:23.000000000","message":"looks like we don\u0027t test that a warning is logged if a version outside of the acceptable range is logged.\n\nIdeally, I think we would want to loop through a list of of known-good/anticipated positive ranges and just make sure that the code returns what is expected.","commit_id":"223b75c471eeda493415923206b854eeee17f958"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"294ed379a2e215be31116120150193c1e1584b62","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    @mock.patch.object(irmc_common, \u0027scci\u0027,"},{"line_number":199,"context_line":"                       spec_set\u003dmock_specs.SCCICLIENT_IRMC_SCCI_SPEC)"},{"line_number":200,"context_line":"    def test_get_irmc_client_cert_support(self, mock_scci, mock_scciclient):"},{"line_number":201,"context_line":"        mock_scciclient.__version__ \u003d \u00270.8.2\u0027"},{"line_number":202,"context_line":"        self.info[\u0027irmc_port\u0027] \u003d 80"},{"line_number":203,"context_line":"        self.info[\u0027irmc_auth_method\u0027] \u003d \u0027digest\u0027"},{"line_number":204,"context_line":"        self.info[\u0027irmc_client_timeout\u0027] \u003d 60"}],"source_content_type":"text/x-python","patch_set":11,"id":"8731c3be_cb0af41f","line":201,"in_reply_to":"c484f01d_3fd83e96","updated":"2022-08-25 14:38:55.000000000","message":"Done","commit_id":"223b75c471eeda493415923206b854eeee17f958"}],"releasenotes/notes/irmc-add-certification-file-option-34e7a0062c768e58.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4ea84932_428266ab","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":39},"updated":"2022-08-16 15:08:32.000000000","message":"We generally recommend avoiding word contractions.\n\nI suggest \"will not\" instead of \"won\u0027t\".","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2ddd4cba_3d5bd0e8","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":46},"updated":"2022-08-16 15:08:32.000000000","message":"maybe s/happen/occur/","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3cec45d5_45ae9b20","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":20},"updated":"2022-08-16 15:08:32.000000000","message":"s/certification/certificate/","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb678dfb9000fde986140f33fd18f628264fd6c9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"57cb4fb6_639ca3c8","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":33},"updated":"2022-08-16 15:08:32.000000000","message":"verification","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"60d3e232_14f5ce06","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":46},"in_reply_to":"2ddd4cba_3d5bd0e8","updated":"2022-08-17 11:51:55.000000000","message":"Done","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4a8a9c12_37fc2ea6","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":20},"in_reply_to":"3cec45d5_45ae9b20","updated":"2022-08-17 11:51:55.000000000","message":"Done","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ccdc417d_6503fe4a","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":39},"in_reply_to":"4ea84932_428266ab","updated":"2022-08-17 11:51:55.000000000","message":"Done","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0aca1964c64175d301e32bb12b2c68867be0bb37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    enforcement of HTTPS certificate verification. By default this is enforced."},{"line_number":10,"context_line":"    python-scciclient version must be one of \u003e\u003d0.8.2,\u003c0.9.0, \u003e\u003d0.9.4,\u003c0.10.0,"},{"line_number":11,"context_line":"    \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"},{"line_number":12,"context_line":"    Or certification verifycation won\u0027t happen."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ab73141f_3518bc64","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":33},"in_reply_to":"57cb4fb6_639ca3c8","updated":"2022-08-17 11:51:55.000000000","message":"Done","commit_id":"07f1a7e5bf1c67f1952a89bd6e23a977c74e57f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"71d666cf2da577a313176708d22e6cd10403acf8","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"},{"line_number":16,"context_line":"    iRMC driver requires python-scciclient version to be one of \u003e\u003d0.8.2,\u003c0.9.0,"},{"line_number":17,"context_line":"    \u003e\u003d0.9.4,\u003c0.10.0, \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e6377bbd_9ed6184d","line":17,"updated":"2022-08-19 17:28:23.000000000","message":"This also needs to note that this is now dependent on the python \"packaging\" module.","commit_id":"223b75c471eeda493415923206b854eeee17f958"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"294ed379a2e215be31116120150193c1e1584b62","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    On Yoga release, to use certification file on HTTPS connection,"},{"line_number":16,"context_line":"    iRMC driver requires python-scciclient version to be one of \u003e\u003d0.8.2,\u003c0.9.0,"},{"line_number":17,"context_line":"    \u003e\u003d0.9.4,\u003c0.10.0, \u003e\u003d0.10.1,\u003c0.11.0, \u003e\u003d0.11.3,\u003c0.12.0 or \u003e\u003d0.12.0,\u003c0.13.0"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a8729b8_9b81976a","line":17,"in_reply_to":"e6377bbd_9ed6184d","updated":"2022-08-25 14:38:55.000000000","message":"Done","commit_id":"223b75c471eeda493415923206b854eeee17f958"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"31c96a08914f18f58f5c483e526b8acbb694cc2a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds driver_info/irmc_verify_ca option to specify certification file."},{"line_number":5,"context_line":"    Default value of driver_info/irmc_verify_ca is False."},{"line_number":6,"context_line":"security:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"47f79230_969cdd4e","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":36},"updated":"2022-08-25 15:49:33.000000000","message":"nit: ``driver_info/irmc_verify_ca``","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"cfda681186a7058876b1c2ec2d096b8efe8605db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds driver_info/irmc_verify_ca option to specify certification file."},{"line_number":5,"context_line":"    Default value of driver_info/irmc_verify_ca is False."},{"line_number":6,"context_line":"security:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"12a217ad_1de7071e","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":36},"in_reply_to":"47f79230_969cdd4e","updated":"2022-08-25 15:53:12.000000000","message":"Done","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54fd259c749c745abafac4b047521b9f8d830b6d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds driver_info/irmc_verify_ca option to specify certification file."},{"line_number":5,"context_line":"    Default value of driver_info/irmc_verify_ca is False."},{"line_number":6,"context_line":"security:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Modifies the ``irmc`` hardware type to include a capability to control"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5cc2643b_8c40b676","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":57},"updated":"2022-08-25 15:47:28.000000000","message":"This is incorrect. https://review.opendev.org/c/openstack/ironic/+/852797/12/ironic/drivers/modules/irmc/common.py#168\n\nThe default is True.","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7f2b12f5d462ab479ed4681afaf51e8a0d46c0e9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds driver_info/irmc_verify_ca option to specify certification file."},{"line_number":5,"context_line":"    Default value of driver_info/irmc_verify_ca is False."},{"line_number":6,"context_line":"security:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Modifies the ``irmc`` hardware type to include a capability to control"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e48f4a31_608d919c","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":57},"in_reply_to":"5cc2643b_8c40b676","updated":"2022-08-25 15:51:12.000000000","message":"Done","commit_id":"6ac466b8f083c395c650df565753ecfda1ed3a61"}]}
