)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"8928e21fdd17919bab1ee53988e105dfdbfd9f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30ebfbcd_4c28d13e","updated":"2022-08-30 05:37:04.000000000","message":"Thank you for the comments. ","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c7954ec09edefc18ec0a378b818e4304335fc71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a9f69ec_84c6e76e","updated":"2022-08-25 21:08:29.000000000","message":"This change seems like it should have a release note. Can you add one or clue me in on why we don\u0027t need one?\n\nThanks!","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"8928e21fdd17919bab1ee53988e105dfdbfd9f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a491685c_e0af712b","in_reply_to":"2a9f69ec_84c6e76e","updated":"2022-08-30 05:37:04.000000000","message":"Done in the next patch","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"918212bdc4140387950422b3ac51e07bb3ddbbe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d49ac9c3_928e238b","updated":"2022-09-05 09:42:22.000000000","message":"HP third party CI 4/6 gates passed now. The 2 gates failed are know failures due to infrastructure issues which we will upgrade in the future and are nothing to do with this patch.","commit_id":"e062b69af783276a9726bab6bc170ebc55eead80"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"869b5151e25524c41925c3a8fa55dc8972ba88c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46ef4cf9_0070f1b9","updated":"2022-09-01 17:00:49.000000000","message":"I need to see HP Third-Party CI passing on this change, or a good reason why it can\u0027t, before I\u0027ll +2 it.","commit_id":"e062b69af783276a9726bab6bc170ebc55eead80"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"a8b6feec10e682a9d67426df9471d75c0873bca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62c1c1fa_1f1535cb","updated":"2022-09-02 14:24:37.000000000","message":"ilorecheck","commit_id":"e062b69af783276a9726bab6bc170ebc55eead80"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"a00093dd30d187da7c97b10b3be8f1dfd996988b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2290dabc_814ed8b4","updated":"2022-09-06 06:17:13.000000000","message":"HP third party CI 4/6 gates passed. The 2 gates failed are know failures due to infrastructure issues which we will upgrade in the future and are nothing to do with this patch.","commit_id":"166bd1697aa5cad99c733127f83fc4a08e24d153"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"12acc94d6b711112ef80a37ca3b22c43a419dee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2769d852_69f5a1c7","updated":"2022-09-05 15:17:56.000000000","message":"ilorecheck","commit_id":"166bd1697aa5cad99c733127f83fc4a08e24d153"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"1123bcea109f199b64ac3b3b7e6fabf31af9f786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36a00aa1_7c0552a3","updated":"2022-09-06 05:07:39.000000000","message":"ilorecheck","commit_id":"166bd1697aa5cad99c733127f83fc4a08e24d153"}],"ironic/drivers/ilo.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c7954ec09edefc18ec0a378b818e4304335fc71","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b2a915d_e69bb407","line":1,"updated":"2022-08-25 21:08:29.000000000","message":"nit: Years are generally only updated for substantial changes to the file, per OpenStack policy. I don\u0027t care enough to -1 over it, but you may want to reconsider when adding these in the future.","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"8928e21fdd17919bab1ee53988e105dfdbfd9f51","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"759e957d_139f1fd6","line":1,"in_reply_to":"3b2a915d_e69bb407","updated":"2022-08-30 05:37:04.000000000","message":"Thanks for the information. It helps. I updated the copyright not due to the change in year year but due to the change in the company name, that is Hewlett Packard Enterprise Development LP.","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"cf5c1a22532741a7fe7fb36c5c1b3852761335d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"52360e71_b05a2586","line":1,"in_reply_to":"759e957d_139f1fd6","updated":"2022-08-30 05:45:04.000000000","message":"Done","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e0957b666eceb05a4d984235928592ae4fc8cfc6","unresolved":true,"context_lines":[{"line_number":498,"context_line":"def update_redfish_properties(task):"},{"line_number":499,"context_line":"    \"\"\"Update redfish properties to node driver_info"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    :param task: a task from TaskManager."},{"line_number":502,"context_line":"    \"\"\""},{"line_number":503,"context_line":"    node \u003d task.node"},{"line_number":504,"context_line":"    info \u003d node.driver_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"06f8ef3e_5dfe7515","line":501,"updated":"2022-09-01 17:00:23.000000000","message":"Can we be more specific in the docstring about what this method does? It looks like it\u0027s trying to convert from an ilo -\u003e ilo+redfish configuration?","commit_id":"e062b69af783276a9726bab6bc170ebc55eead80"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"6c8cabf8ad07c05099327b5defe40aabd012606f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"def update_redfish_properties(task):"},{"line_number":499,"context_line":"    \"\"\"Update redfish properties to node driver_info"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    :param task: a task from TaskManager."},{"line_number":502,"context_line":"    \"\"\""},{"line_number":503,"context_line":"    node \u003d task.node"},{"line_number":504,"context_line":"    info \u003d node.driver_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea5c992b_78abbd00","line":501,"in_reply_to":"06f8ef3e_5dfe7515","updated":"2022-09-05 10:54:04.000000000","message":"Done","commit_id":"e062b69af783276a9726bab6bc170ebc55eead80"}],"ironic/drivers/modules/ilo/vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9d2a87700f0f44136efec33ba65c0b3ff37757ce","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class IloRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"},{"line_number":107,"context_line":"    \"\"\"iLO Redfish interface for vendor_passthru.\"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def validate(self, task, method, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a5ba630_bafe199d","line":106,"updated":"2022-08-21 11:31:55.000000000","message":"1) If all ilo4 hardware supports all our vendor passthru, please inherit VendorPassthru from redfish_vendor to avoid having 2 interfaces in one hardware type.\n\n2) If not, you need to update VendorPassthru with supported calls.\n\nEither way, a new interface is not necessary","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5c7954ec09edefc18ec0a378b818e4304335fc71","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class IloRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"},{"line_number":107,"context_line":"    \"\"\"iLO Redfish interface for vendor_passthru.\"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def validate(self, task, method, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"84bf2967_87085860","line":106,"in_reply_to":"4a5ba630_bafe199d","updated":"2022-08-25 21:08:29.000000000","message":"+1","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"8928e21fdd17919bab1ee53988e105dfdbfd9f51","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class IloRedfishVendorPassthru(redfish_vendor.RedfishVendorPassthru):"},{"line_number":107,"context_line":"    \"\"\"iLO Redfish interface for vendor_passthru.\"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def validate(self, task, method, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"26ba7f55_1b510d13","line":106,"in_reply_to":"84bf2967_87085860","updated":"2022-08-30 05:37:04.000000000","message":"Done","commit_id":"a5df756f1bddbf829cd812a09bc9abea5c98daa4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e0afdbac12a05f6e5383a71292426da130bcf1c6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                ramdisk_options\u003dNone)"},{"line_number":116,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _validate_is_it_a_supported_system(self, task):"},{"line_number":119,"context_line":"        \"\"\"Verify and raise an exception if it is not a supported system."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param task: A TaskManager object."}],"source_content_type":"text/x-python","patch_set":4,"id":"da312a96_ce99ae85","line":118,"updated":"2022-09-12 14:14:50.000000000","message":"nit: _validate_support_system (for brevity)","commit_id":"166bd1697aa5cad99c733127f83fc4a08e24d153"}]}