)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3e06c4472dcef6341d3954a87f1a88e0fd0c8aab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"852c14d2_b4e9a423","updated":"2023-07-11 14:09:50.000000000","message":"I\u0027m very sorry, I just realized I\u0027m the reason this hasn\u0027t landed yet.","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"90c9f977069afa00be00a4ed4cd62ee75e280b4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1e239b0a_c1623479","updated":"2023-03-16 22:38:34.000000000","message":"With this change, does it remain possible to create a conductor with no conductor group whatsoever (emulating existing behavior)? e.g. could you create a conductor, then change the conductor group to \"emptystring\" or \"None\"? \n\nIf not, is that likely to cause any headaches? Especially for environments upgrading into this new functionality.","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a786d0a0dbbd13bb2bf9820f5f545e68e678bc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"85f81665_86e79363","updated":"2024-01-23 15:58:43.000000000","message":"recheck","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5e4f1409245499ff69d16a69a8e716bba3bd9f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"afd3b895_28a061f8","updated":"2023-10-06 01:10:53.000000000","message":"recheck","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9371e91275684dad34a79ee875c79d8c90eb3c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1f8fc08_7bb9b592","updated":"2023-07-18 13:23:54.000000000","message":"recheck infinitely unhappy ci","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1199cd07e2e9053d8b2170d11d8f873e6d99a782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dabe4f0a_adc7f1e7","updated":"2023-10-06 19:26:41.000000000","message":"recheck master branch CI fixed","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1a15de54495471c47bbfefb941d0149126ae919e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d89ea49a_1ded742a","updated":"2023-07-19 13:32:21.000000000","message":"recheck metal3 db fix merged, prior failure was before that fix merged.","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79652ab3e99baeac77249f3e8f71ba8573fef57d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3419c14_dfa0e828","in_reply_to":"1e239b0a_c1623479","updated":"2023-04-17 13:19:05.000000000","message":"Manually create one via the API?\n\nThe code permits posting one without any value, and you are allowed to change the field value after the fact. Generally where people have gotten into trouble is where they have a nova-compute pointing at the default conductor group.\n\nGenerally this is to help enable avoiding headaches if operators have odd nova-computes and have already felt the headaches.","commit_id":"9953b5a2e8d7bd3269ab720f844cdb6450337b9c"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"faf75f75a59f354714d1de3eca85ebe13bbe6b40","unresolved":true,"context_lines":[{"line_number":2483,"context_line":""},{"line_number":2484,"context_line":"        # NOTE(jroll) this is special-cased to \"\" and not None,"},{"line_number":2485,"context_line":"        # because it is used in hash ring calculations"},{"line_number":2486,"context_line":"        if not node.get(\u0027conductor_group\u0027):"},{"line_number":2487,"context_line":"            node[\u0027conductor_group\u0027] \u003d \u0027\u0027"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"        if node.get(\u0027name\u0027) is not None:"},{"line_number":2490,"context_line":"            error_msg \u003d _(\"Cannot create node with invalid name \u0027%(name)s\u0027\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b403b2b_db718acd","line":2487,"range":{"start_line":2486,"start_character":0,"end_line":2487,"end_character":40},"updated":"2023-03-01 10:45:54.000000000","message":"Merge with this code?","commit_id":"478ce66cfb9d5cb3f602eab8e14d1ac866b5b091"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b97752ceff208765a983c3f54e443532d2106e3","unresolved":false,"context_lines":[{"line_number":2483,"context_line":""},{"line_number":2484,"context_line":"        # NOTE(jroll) this is special-cased to \"\" and not None,"},{"line_number":2485,"context_line":"        # because it is used in hash ring calculations"},{"line_number":2486,"context_line":"        if not node.get(\u0027conductor_group\u0027):"},{"line_number":2487,"context_line":"            node[\u0027conductor_group\u0027] \u003d \u0027\u0027"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"        if node.get(\u0027name\u0027) is not None:"},{"line_number":2490,"context_line":"            error_msg \u003d _(\"Cannot create node with invalid name \u0027%(name)s\u0027\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff4c810b_5bd4412a","line":2487,"range":{"start_line":2486,"start_character":0,"end_line":2487,"end_character":40},"in_reply_to":"4b403b2b_db718acd","updated":"2023-03-13 19:14:36.000000000","message":"Done","commit_id":"478ce66cfb9d5cb3f602eab8e14d1ac866b5b091"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"16c29c23784e532eef6a9723f93eab7a0e0cb182","unresolved":true,"context_lines":[{"line_number":2538,"context_line":"        # NOTE(jroll) this is special-cased to \"\" and not None,"},{"line_number":2539,"context_line":"        # because it is used in hash ring calculations"},{"line_number":2540,"context_line":"        if not node.get(\u0027conductor_group\u0027):"},{"line_number":2541,"context_line":"            if CONF.default_conductor_group:"},{"line_number":2542,"context_line":"                node[\u0027conductor_group\u0027] \u003d CONF.default_conductor_group"},{"line_number":2543,"context_line":"            else:"},{"line_number":2544,"context_line":"                node[\u0027conductor_group\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"881f0523_14eb7463","line":2541,"updated":"2023-03-08 10:02:32.000000000","message":"nit: this is redundant now that the default for the option is \u0027\u0027","commit_id":"f337351144154e3413250ccd68f41f35a87cb64e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b97752ceff208765a983c3f54e443532d2106e3","unresolved":false,"context_lines":[{"line_number":2538,"context_line":"        # NOTE(jroll) this is special-cased to \"\" and not None,"},{"line_number":2539,"context_line":"        # because it is used in hash ring calculations"},{"line_number":2540,"context_line":"        if not node.get(\u0027conductor_group\u0027):"},{"line_number":2541,"context_line":"            if CONF.default_conductor_group:"},{"line_number":2542,"context_line":"                node[\u0027conductor_group\u0027] \u003d CONF.default_conductor_group"},{"line_number":2543,"context_line":"            else:"},{"line_number":2544,"context_line":"                node[\u0027conductor_group\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"e343d6c5_3f5f0b96","line":2541,"in_reply_to":"881f0523_14eb7463","updated":"2023-03-13 19:14:36.000000000","message":"Done","commit_id":"f337351144154e3413250ccd68f41f35a87cb64e"}],"ironic/conf/default.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a07cbcc3bd72aaf2fde26c47bd163831af5db19f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\u0027Resource class to use for new nodes when no resource \u0027"},{"line_number":83,"context_line":"                      \u0027class is provided in the creation request.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027default_conductor_group\u0027,"},{"line_number":85,"context_line":"               mutable\u003dTrue,"},{"line_number":86,"context_line":"               help\u003d_(\u0027The conductor_group to use for new nodes when no \u0027"},{"line_number":87,"context_line":"                      \u0027conductor_group was defined in the creation request.\u0027)),"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"deae99d6_2dda22dc","line":85,"updated":"2023-02-23 10:05:23.000000000","message":"I suspect this defaults to None, while the old default was \"\" (an empty string)","commit_id":"2556135d10c0d7fda739b17bd34625060ed6cdab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"faf75f75a59f354714d1de3eca85ebe13bbe6b40","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\u0027Resource class to use for new nodes when no resource \u0027"},{"line_number":83,"context_line":"                      \u0027class is provided in the creation request.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027default_conductor_group\u0027,"},{"line_number":85,"context_line":"               mutable\u003dTrue,"},{"line_number":86,"context_line":"               help\u003d_(\u0027The conductor_group to use for new nodes when no \u0027"},{"line_number":87,"context_line":"                      \u0027conductor_group was defined in the creation request.\u0027)),"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b759c81f_ae9dbd43","line":85,"in_reply_to":"00167562_678efa9f","updated":"2023-03-01 10:45:54.000000000","message":"Even then, str(None) \u003d\u003d \"None\"","commit_id":"2556135d10c0d7fda739b17bd34625060ed6cdab"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b97752ceff208765a983c3f54e443532d2106e3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\u0027Resource class to use for new nodes when no resource \u0027"},{"line_number":83,"context_line":"                      \u0027class is provided in the creation request.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027default_conductor_group\u0027,"},{"line_number":85,"context_line":"               mutable\u003dTrue,"},{"line_number":86,"context_line":"               help\u003d_(\u0027The conductor_group to use for new nodes when no \u0027"},{"line_number":87,"context_line":"                      \u0027conductor_group was defined in the creation request.\u0027)),"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3deb1ea9_77683518","line":85,"in_reply_to":"b759c81f_ae9dbd43","updated":"2023-03-13 19:14:36.000000000","message":"le-sigh. Hmmm","commit_id":"2556135d10c0d7fda739b17bd34625060ed6cdab"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b00a40bd3af7c30cd1dba8dd3c419c03b7e0988","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d_(\u0027Resource class to use for new nodes when no resource \u0027"},{"line_number":83,"context_line":"                      \u0027class is provided in the creation request.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027default_conductor_group\u0027,"},{"line_number":85,"context_line":"               mutable\u003dTrue,"},{"line_number":86,"context_line":"               help\u003d_(\u0027The conductor_group to use for new nodes when no \u0027"},{"line_number":87,"context_line":"                      \u0027conductor_group was defined in the creation request.\u0027)),"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"00167562_678efa9f","line":85,"in_reply_to":"deae99d6_2dda22dc","updated":"2023-02-23 16:48:28.000000000","message":"hmm! I guess yeah, we wouldn\u0027t be str(val) anywhere would we.","commit_id":"2556135d10c0d7fda739b17bd34625060ed6cdab"}]}