)]}'
{"ironic/tests/drivers/test_seamicro.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"83f1e1bb95a0e157f4126e73604396e02a4b2561","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":281,"context_line":"            task.resources[0].driver.power.validate("},{"line_number":282,"context_line":"                        task, self.node)"},{"line_number":283,"context_line":"        self.assertEqual(1, parse_drv_info_mock.call_count)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @mock.patch.object(seamicro, \u0027_parse_driver_info\u0027)"},{"line_number":286,"context_line":"    def test_power_interface_validate_fails(self, parse_drv_info_mock):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9RtI%3D","line":283,"updated":"2014-04-07 13:39:36.000000000","message":"IMO better to use assert_called_once_with.","commit_id":"b1c4ad6755fdbbe21f11365834d80969e48f27db"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"81963ff2342a2f23f0c1c1a02c813cd97d3ea7db","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":281,"context_line":"            task.resources[0].driver.power.validate("},{"line_number":282,"context_line":"                        task, self.node)"},{"line_number":283,"context_line":"        self.assertEqual(1, parse_drv_info_mock.call_count)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @mock.patch.object(seamicro, \u0027_parse_driver_info\u0027)"},{"line_number":286,"context_line":"    def test_power_interface_validate_fails(self, parse_drv_info_mock):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9QRw%3D","line":283,"in_reply_to":"AAAAWH%2F9RtI%3D","updated":"2014-04-07 16:16:37.000000000","message":"In a previous patch, Devananda had noticed that if mocked_method.assert_called_once is misspelled eg. Assert_called_Once\n\nIt still passes the test since mock will call any method called upon a mocked object. Hence directly counting the calls is better IMO.","commit_id":"b1c4ad6755fdbbe21f11365834d80969e48f27db"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"83f1e1bb95a0e157f4126e73604396e02a4b2561","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":292,"context_line":"                              task.resources[0].driver.power.validate,"},{"line_number":293,"context_line":"                              task, self.node)"},{"line_number":294,"context_line":"        self.assertEqual(1, parse_drv_info_mock.call_count)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @mock.patch.object(seamicro, \u0027_reboot\u0027)"},{"line_number":297,"context_line":"    def test_reboot(self, mock_reboot):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9Rs8%3D","line":294,"updated":"2014-04-07 13:39:36.000000000","message":"ditto","commit_id":"b1c4ad6755fdbbe21f11365834d80969e48f27db"}]}
