)]}'
{"ironic/drivers/modules/ipminative.py":[{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"d81d292defcbb3fdbdd0132385cd328b37c2d6c1","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        return list(_BOOT_DEVICES_MAP.keys())"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":298,"context_line":"    def set_boot_device(self, task, device, persistent\u003dFalse, **kwargs):"},{"line_number":299,"context_line":"        \"\"\"Set the boot device for a node."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Set the boot device to use on next reboot of the node."}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_1c29c39a","line":298,"updated":"2014-06-06 06:55:25.000000000","message":"Not so sure about changing the default params from an abstract class.","commit_id":"c3a93a7781c8dc7a5878b90410765e07a00a46c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bac87d1a770953337c01b3f37a66d45207df041b","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        return list(_BOOT_DEVICES_MAP.keys())"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":298,"context_line":"    def set_boot_device(self, task, device, persistent\u003dFalse, **kwargs):"},{"line_number":299,"context_line":"        \"\"\"Set the boot device for a node."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Set the boot device to use on next reboot of the node."}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_f8ffbaff","line":298,"in_reply_to":"1ae5cdf2_1c29c39a","updated":"2014-06-06 11:21:45.000000000","message":"Why not? It\u0027s not any better than kwargs.pop(\u0027persistent\u0027, False), but is much more clear to a user and can be better documented.","commit_id":"c3a93a7781c8dc7a5878b90410765e07a00a46c7"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"7e1defe4281d7dcadb4ea9c7e914aa626aa14602","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        return list(_BOOT_DEVICES_MAP.keys())"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":298,"context_line":"    def set_boot_device(self, task, device, persistent\u003dFalse, **kwargs):"},{"line_number":299,"context_line":"        \"\"\"Set the boot device for a node."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Set the boot device to use on next reboot of the node."}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_ba57aa25","line":298,"in_reply_to":"1ae5cdf2_f8ffbaff","updated":"2014-06-09 16:13:45.000000000","message":"Agree that it\u0027s clearer, but(personal preference) an abstract method it\u0027s like a contract that all subclasses should agree. If every subclass accepts different params set, it can lead to future incompatibility problems.","commit_id":"c3a93a7781c8dc7a5878b90410765e07a00a46c7"}],"ironic/tests/drivers/test_ipminative.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"c27808fddae3743401977ed32dc810565c16e54b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                                       boot_devices.PXE)"},{"line_number":213,"context_line":"            # boot_devices.PXE should be converted to \u0027net\u0027 for pyghmi"},{"line_number":214,"context_line":"            ipmicmd.set_bootdev.assert_called_once_with(\u0027net\u0027, persist\u003dFalse)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def test_set_boot_device_bad_device(self):"},{"line_number":217,"context_line":"        with task_manager.acquire(self.context, [self.node.uuid]) as task:"},{"line_number":218,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_2d3a20e7","line":215,"updated":"2014-05-16 17:59:43.000000000","message":"Can we have a new test for set_boot_device where persistance\u003dTrue?  I\u0027d like to see this use case covered with a test (not just that the param is passed thru)","commit_id":"c3a93a7781c8dc7a5878b90410765e07a00a46c7"}]}
