)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a91b2bec91858fbc23d4a14ce0c6b27b845228e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d5069e0_5541354f","updated":"2022-09-27 12:16:49.000000000","message":"recheck","commit_id":"697cefc3b2b64fb6df1b12699ebbd53ddebf4180"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"85156d80c0817240c1f55efc352b03b1b019e774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12f5e069_401e0593","updated":"2022-09-29 04:08:19.000000000","message":"recheck","commit_id":"aff1f9fa34d731f469ac52a8ea188c937f7156b0"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9fe4a4a99c2cd70ee36eeca34e2f85540e1ff78c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db87dbfd_d1840562","updated":"2022-10-26 11:34:07.000000000","message":"If my inline comment is an issue, it can be done in a separate change.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7f853a555b0b703c00599452a6d6ba9dac51eaac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83dccb95_2fd85b78","updated":"2022-10-26 18:35:04.000000000","message":"It\u0027s passing the anaconda job now. Going to give you a chance to respond to hjensas\u0027s comment before I workflow this.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"de516bda619a62293b9b8a5e46dba5f27603af76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f090f544_26af3e79","updated":"2022-10-10 16:41:35.000000000","message":"Lets get https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/854031 landed, then do a re-check here to ensure ironic-standalone-anaconda is passing.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"7ea0e4a29acd3da7d2d6e2ff504b903174fc7f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82637c8d_666aed20","updated":"2022-11-03 05:56:07.000000000","message":"Sorry Jensas i had not seen the comment earlier. I have replied to the comemnt. I will prefer to do it in a different patch as first we need to hit that condition. \n@Jayf, @Riccardo, please let me know your opinion also.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"70e2da815639b96e384127445a9be3e2379dbca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f50a6bc_4d35033e","updated":"2022-10-13 09:22:54.000000000","message":"recheck","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bc01c7f4adde55b704baf024e619d785da3ffcdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f3c7f63_c578fdae","in_reply_to":"83dccb95_2fd85b78","updated":"2022-11-03 06:02:01.000000000","message":"Responded to his comment. Sorry for the delay.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"33027f4f2be1f39695c72526f52d8aaebece5400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f1644fd5_dbadee27","in_reply_to":"db87dbfd_d1840562","updated":"2022-11-03 06:01:19.000000000","message":"I will prefer to do in a seperate patch but the comments are always welcome. 😊\nI didnt see the comment earlier at all as i was on leave and thats why delay in response.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"}],"ironic/common/images.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"82230dcfce5a234bb70ec7208780944c2691c4de","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        # us any hints."},{"line_number":688,"context_line":"        return True"},{"line_number":689,"context_line":"    # We were unable to determine if this was a folder or a file."},{"line_number":690,"context_line":"    return False"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"def _extract_iso(extract_iso, extract_dir):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9724067_cd7cfe3d","line":690,"range":{"start_line":690,"start_character":11,"end_line":690,"end_character":16},"updated":"2022-10-26 08:30:02.000000000","message":"If we where unable to determine, this should return None? Not False, indicating a file?","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"7ea0e4a29acd3da7d2d6e2ff504b903174fc7f95","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        # us any hints."},{"line_number":688,"context_line":"        return True"},{"line_number":689,"context_line":"    # We were unable to determine if this was a folder or a file."},{"line_number":690,"context_line":"    return False"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"def _extract_iso(extract_iso, extract_dir):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e8c87c2d_3e298f65","line":690,"range":{"start_line":690,"start_character":11,"end_line":690,"end_character":16},"in_reply_to":"a9724067_cd7cfe3d","updated":"2022-11-03 05:56:07.000000000","message":"I can change it but i havent hit this condition and i am not sure how it will impact the complete workflow of the code if it returns None. Probably that can be a seperate patch so as to have the complete workflow for case \"None\". Or probably it should return error in such a case.\nAny idea how we can hit this False? I can handle that in a seperate patch.","commit_id":"ca54c4df26071937599529857dfe0dda33ca743e"}]}