)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4d5700385ddeee0484f46c20bf58890c44962ea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a46dfcb5_1121b7ba","updated":"2022-10-09 19:25:33.000000000","message":"I did some local testing; it looks like this will proactively migrate DBs to this encoding (good!). \n\nThis can have some side effects; so I suggest we put in an upgrade release note warning of this migration - it should be free in most cases but being explicit about it is not a bad idea.\n\nI think this is fine with a bigger release note.","commit_id":"df490e61bffcfc1147fdd7ce31299ae4ed0d45c2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fd845bbcf7491b8fecee71997422c4dbaa25f013","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"214c5e0c_aea7a570","updated":"2022-10-06 22:30:55.000000000","message":"So, I don\u0027t like this change. I don\u0027t think I\u0027ll like any change that solves this problem though, so I don\u0027t think that matters.\n\nThe -1 is for this specific case: what happens if an operator has already deployed Ironic on a DB that is set to utf8mb4 -- won\u0027t all our existing (and future) migrations break those users pretty aggressively?\n\nI\u0027m not sure how we get out of this without forcing a hard migration for *someone*, but being explicit about encoding in our migrations, when we haven\u0027t before, is likely to put an operator in a position where something is broken in a difficult-to-fix way that may have otherwise been unpredictable.\n\nIn fact, I\u0027m fairly sure that today, if an operator performed these steps; they\u0027d likely be broken already:\n- Dump ironic DB without create table statements (a valid way to dump/backup DBs)\n- Run ironic DB creation tool on a new DB that\u0027s running *newer* mysql/mariadb/etc\n- Import your DB\n- Operator finds out, after the fact, values are truncated.\n\n\n\nI think this attempt to solve this ... DB mismatch quietly is laudable; but we\u0027re better off making loud noises and requiring operators to manually validate or migrate than just changing these out from under them. Essentially we have a minefield of operator DBs out there, waiting to blow up when/if exported from their existing DB server into a new one.","commit_id":"df490e61bffcfc1147fdd7ce31299ae4ed0d45c2"}],"doc/source/install/include/common-prerequisites.inc":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9869385be90f20e8431172707eee30b24c042974","unresolved":true,"context_lines":[{"line_number":31,"context_line":".. note::"},{"line_number":32,"context_line":"   When creating the database to house Ironic, specifically on MySQL/MariaDB,"},{"line_number":33,"context_line":"   the character set *cannot* be 4 byte Unicode characters. This is due to"},{"line_number":34,"context_line":"   an internal sctructural constraint. UTF8, in these database platforms,"},{"line_number":35,"context_line":"   has traditionally meant ``utf8mb3``, short for \"UTF-8, 3 byte encoding\","},{"line_number":36,"context_line":"   however the platforms are expected to move to ``utf8mb4`` which is"},{"line_number":37,"context_line":"   incompatible with Ironic."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"62a9e2f8_60f1f4ff","line":34,"updated":"2022-10-04 15:39:02.000000000","message":"typo: structural","commit_id":"ea84674f63a0bc156e7d4d5e5dd6e0bc816a3532"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"684042131301ab7e3633e4455b0284a92f94d407","unresolved":false,"context_lines":[{"line_number":31,"context_line":".. note::"},{"line_number":32,"context_line":"   When creating the database to house Ironic, specifically on MySQL/MariaDB,"},{"line_number":33,"context_line":"   the character set *cannot* be 4 byte Unicode characters. This is due to"},{"line_number":34,"context_line":"   an internal sctructural constraint. UTF8, in these database platforms,"},{"line_number":35,"context_line":"   has traditionally meant ``utf8mb3``, short for \"UTF-8, 3 byte encoding\","},{"line_number":36,"context_line":"   however the platforms are expected to move to ``utf8mb4`` which is"},{"line_number":37,"context_line":"   incompatible with Ironic."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"f30d2058_a9dfe5ec","line":34,"in_reply_to":"62a9e2f8_60f1f4ff","updated":"2022-10-04 21:32:25.000000000","message":"Done","commit_id":"ea84674f63a0bc156e7d4d5e5dd6e0bc816a3532"}]}