)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kirill \u003ckirill.germanov@gcore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-07 15:50:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add vnc console"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibc50885e2d92e3fa8dfa00ce362150aa67a2e910"},{"line_number":10,"context_line":"spec: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/vnc-graphical-console.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"150db2ee_00630ada","line":7,"updated":"2022-11-08 16:16:26.000000000","message":"Please add a detailed commit message as documented here: https://wiki.openstack.org/wiki/GitCommitMessages\n\nI\u0027m not sure there\u0027s a good way to reference that spec since it\u0027s not tied to a storyboard story or a launchpad bug... I also don\u0027t want to ask you to file a storyboard story when we might migrate it out from under you. So please just update the text of the commit message to be more detailed; but don\u0027t worry about the spec/bug linking now.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5ea09ce_8d878c49","updated":"2022-11-16 09:38:17.000000000","message":"Thanks for the patch, some comments and questions inline.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bdb78caa_b674b07c","updated":"2022-11-08 16:16:26.000000000","message":"This needs work to pass CI. Has it been tested on actual hardware?","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"}],"ironic/drivers/modules/drac/console.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"8ea77f9b_e30045a4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":58},"updated":"2022-11-16 09:38:17.000000000","message":"Copy-paste from somewhere? Can be removed.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9ba4f8bb8317c85e4db8cf2922e70ae6fcb2efc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"e14bcf49_06b8e6d7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":58},"in_reply_to":"8ea77f9b_e30045a4","updated":"2022-11-17 17:24:31.000000000","message":"++ Agreed.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ironic.drivers.modules.drac import vnc"},{"line_number":17,"context_line":"from ironic_lib import metrics_utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"160b795e_3a734d93","line":17,"in_reply_to":"851321aa_cc679c01","updated":"2022-11-08 16:16:26.000000000","message":"\u003e pep8: I100 Import statements are in the wrong order. \u0027from ironic_lib import metrics_utils\u0027 should be before \u0027from ironic.drivers.modules.drac import vnc\u0027 and in a different group.\n\nPlease fix.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":true,"context_lines":[{"line_number":19,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class DracVNCConsoleInterface(vnc.DracVNCConsole):"},{"line_number":23,"context_line":"    \"\"\"A ConsoleInterface that uses vnc.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @METRICS.timer(\u0027DracVNCConsoleInterface.validate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"583089b9_d3f8ca9d","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":50},"updated":"2022-11-16 09:38:17.000000000","message":"Why this class? Why not go with `DracWsManVNCConsole` (`DracVNCConsole`) here and have only console.py file?","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"}],"ironic/drivers/modules/drac/vnc.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from ironic.common.i18n import _"},{"line_number":19,"context_line":"from ironic.drivers import base"},{"line_number":20,"context_line":"from ironic.drivers.modules.drac import common as drac_common"},{"line_number":21,"context_line":"from ironic_lib import metrics_utils"},{"line_number":22,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"cff0e290_11acdab1","line":21,"in_reply_to":"19b3ec74_dd3e2278","updated":"2022-11-08 16:16:26.000000000","message":"\u003e pep8: I100 Import statements are in the wrong order. \u0027from ironic_lib import metrics_utils\u0027 should be before \u0027from ironic.drivers.modules.drac import common\u0027 and in a different group.\n\nPlease fix.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":true,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# TODO(pas-ha): propose iDRACCard[Service|View] mgmt to python-dracclient"},{"line_number":41,"context_line":"class iDRACCard(object):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"33cc65f0_182a7578","line":40,"updated":"2022-11-08 16:16:26.000000000","message":"You sure we don\u0027t want this in dracclient instead?","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":true,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# TODO(pas-ha): propose iDRACCard[Service|View] mgmt to python-dracclient"},{"line_number":41,"context_line":"class iDRACCard(object):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"d8604981_c3bb5186","line":40,"in_reply_to":"33cc65f0_182a7578","updated":"2022-11-16 09:38:17.000000000","message":"Agree, this belongs more to python-dracclient.\n\nAlso note that WS-Man that python-dracclient uses is deprecated and at some point will not be available in future (new) systems. For newer systems (iDRAC 8/9) Redfish protocol should be considered.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9ba4f8bb8317c85e4db8cf2922e70ae6fcb2efc","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        p_info[\u0027drac_vnc_timeout\u0027] \u003d timeout"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    password \u003d d_info.get(\u0027drac_vnc_password\u0027)"},{"line_number":105,"context_line":"    if password \u003d\u003d \"\":"},{"line_number":106,"context_line":"        password \u003d None"},{"line_number":107,"context_line":"    if password is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"94b1add3_c8cf592d","line":104,"range":{"start_line":104,"start_character":44,"end_line":104,"end_character":45},"updated":"2022-11-17 17:24:31.000000000","message":"So the VNC password is static and is set by the user? Interesting...","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        target\u003diDRAC_FQDD)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class DracVNCConsole(base.ConsoleInterface):"},{"line_number":160,"context_line":"    \"\"\"Control VNC server on Dell iDRAC \u003e\u003d 7 via WS-MAN API"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    On starting console, sets VNC password, port, timeout and SSL settings"}],"source_content_type":"text/x-python","patch_set":7,"id":"4a885d14_4e5827d0","line":159,"updated":"2022-11-16 09:38:17.000000000","message":"Class should be named `DracWSManVNCConsole` to follow existing pattern and allow for Redfish implementation later.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d502d58e5e0b80a92a0d07053073c973bd91ab53","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        client \u003d drac_common.get_drac_client(task.node)"},{"line_number":208,"context_line":"        _change_vnc_property(client, \u0027Enable\u0027, \u0027Disabled\u0027)"},{"line_number":209,"context_line":"        _commit_changes(client)"},{"line_number":210,"context_line":"        "},{"line_number":211,"context_line":"    @METRICS.timer(\u0027DracVNCConsole.get_console\u0027)"},{"line_number":212,"context_line":"    def get_console(self, task):"},{"line_number":213,"context_line":"        p_info \u003d parse_vnc_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":7,"id":"09e34de0_1b2dcbae","line":210,"in_reply_to":"106cb1b3_92c18780","updated":"2022-11-08 16:16:26.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9ba4f8bb8317c85e4db8cf2922e70ae6fcb2efc","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        p_info \u003d parse_vnc_driver_info(task.node)"},{"line_number":214,"context_line":"        p_info.update(drac_common.parse_driver_info(task.node))"},{"line_number":215,"context_line":"        url \u003d \"vnc://{host}:{port}\".format(host\u003dp_info[\u0027drac_address\u0027],"},{"line_number":216,"context_line":"                                           port\u003dp_info[\u0027drac_vnc_port\u0027])"},{"line_number":217,"context_line":"        "},{"line_number":218,"context_line":"        return {\u0027type\u0027: \u0027vnc\u0027, \u0027url\u0027: url, "},{"line_number":219,"context_line":"                \u0027password\u0027: p_info[\u0027drac_vnc_password\u0027]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"ef10a780_72d76951","line":216,"range":{"start_line":216,"start_character":7,"end_line":216,"end_character":72},"updated":"2022-11-17 17:24:31.000000000","message":"It occurs to me we\u0027re going to need to document how the user determines what the port is or should be, since it seems supplied upfront as opposed to collected from the running/operating state of the BMC.","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"}],"setup.cfg":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"54a799e9f3691034ea9fe06630e616802b8647d0","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.console:IloConsoleInterface"},{"line_number":84,"context_line":"    ipmitool-shellinabox \u003d ironic.drivers.modules.ipmitool:IPMIShellinaboxConsole"},{"line_number":85,"context_line":"    ipmitool-socat \u003d ironic.drivers.modules.ipmitool:IPMISocatConsole"},{"line_number":86,"context_line":"    vnc \u003d ironic.drivers.modules.drac.console:DracVNCConsoleInterface"},{"line_number":87,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"ironic.hardware.interfaces.deploy \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"c64ddb47_0dc5c6bd","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":7},"updated":"2022-11-16 09:38:17.000000000","message":"should be `idrac-wsman` or `idrac-wsman-vnc` to follow existing pattern for interface names","commit_id":"bb1aab3ee4d2da9592cfae73a2283974ff5abe66"}]}