)]}'
{"ironic/tests/unit/common/test_glance_service.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb6686dfe27bcdeaaad074d16bf205d8328b8a6c","unresolved":true,"context_lines":[{"line_number":148,"context_line":"            \u0027os_hash_value\u0027: None,"},{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":151,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":152,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":153,"context_line":"        image_meta \u003d self.service.show(image_id)"},{"line_number":154,"context_line":"        self.service.call.assert_called_with(\u0027get\u0027, image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c400d323_59b20a58","line":151,"updated":"2022-10-20 10:21:20.000000000","message":"This calls start(), but nothing stops it. Instead of copying this broken code, we need to fix it to use a decorator or a context manager.","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"591d3083d327589b0f931282771dd3ea7fc9699d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027os_hash_value\u0027: None,"},{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":151,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":152,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":153,"context_line":"        image_meta \u003d self.service.show(image_id)"},{"line_number":154,"context_line":"        self.service.call.assert_called_with(\u0027get\u0027, image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"70de5f05_74362c25","line":151,"in_reply_to":"c400d323_59b20a58","updated":"2022-10-20 12:59:14.000000000","message":"Done","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb6686dfe27bcdeaaad074d16bf205d8328b8a6c","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    def test_show_makes_datetimes(self):"},{"line_number":158,"context_line":"        image_id \u003d uuidutils.generate_uuid()"},{"line_number":159,"context_line":"        image \u003d self._make_datetime_fixture()"},{"line_number":160,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":161,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":162,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":163,"context_line":"        image_meta \u003d self.service.show(image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4cee26ba_aaeca6b9","line":160,"updated":"2022-10-20 10:21:20.000000000","message":"This strikes me as a wrong approach. How comes we don\u0027t know if this is a mock or not? Do we not tear down the mock somewhere? Oh, we don\u0027t. Will comment above.","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"591d3083d327589b0f931282771dd3ea7fc9699d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def test_show_makes_datetimes(self):"},{"line_number":158,"context_line":"        image_id \u003d uuidutils.generate_uuid()"},{"line_number":159,"context_line":"        image \u003d self._make_datetime_fixture()"},{"line_number":160,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":161,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":162,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":163,"context_line":"        image_meta \u003d self.service.show(image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9333252_a8490f55","line":160,"in_reply_to":"4cee26ba_aaeca6b9","updated":"2022-10-20 12:59:14.000000000","message":"Done","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb6686dfe27bcdeaaad074d16bf205d8328b8a6c","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        image_id \u003d uuidutils.generate_uuid()"},{"line_number":179,"context_line":"        image \u003d self._make_fixture(name\u003d\u0027image1\u0027, id\u003dimage_id, status\u003d\"queued\")"},{"line_number":180,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":181,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":182,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":183,"context_line":"        self.assertRaises(exception.ImageUnacceptable,"},{"line_number":184,"context_line":"                          self.service.show, image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fefc7a91_adb09888","line":181,"updated":"2022-10-20 10:21:20.000000000","message":"Same","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"591d3083d327589b0f931282771dd3ea7fc9699d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        image_id \u003d uuidutils.generate_uuid()"},{"line_number":179,"context_line":"        image \u003d self._make_fixture(name\u003d\u0027image1\u0027, id\u003dimage_id, status\u003d\"queued\")"},{"line_number":180,"context_line":"        if not mock._is_instance_mock(self.service.call):"},{"line_number":181,"context_line":"            mock.patch.object(self.service, \u0027call\u0027, autospec\u003dTrue).start()"},{"line_number":182,"context_line":"        self.service.call.return_value \u003d image"},{"line_number":183,"context_line":"        self.assertRaises(exception.ImageUnacceptable,"},{"line_number":184,"context_line":"                          self.service.show, image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2280c74_1960ed20","line":181,"in_reply_to":"fefc7a91_adb09888","updated":"2022-10-20 12:59:14.000000000","message":"Done","commit_id":"6926b2bda15749687b01cc77597b6e129ef7050d"}]}