)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f133a78f82273153b1ff3a1f975bfcbd2de82e7c","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d80ce88c1066cfd0467e9c887e80850b935e2fa"},{"line_number":14,"context_line":"Story: 2007789"},{"line_number":15,"context_line":"Task:  40035"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3c741e26_e4581923","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":7},"updated":"2022-10-28 13:36:32.000000000","message":"nit: it might not grok the extra space. :\\  The UI definitely does not.","commit_id":"b0fc53339f5e9a50525a4f9f1a36a2c0fc7a7b22"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f133a78f82273153b1ff3a1f975bfcbd2de82e7c","unresolved":true,"context_lines":[{"line_number":314,"context_line":"                if len(row) \u003c 2:"},{"line_number":315,"context_line":"                    combined_res.append(row)"},{"line_number":316,"context_line":"                elif (isinstance(row[0], models.Port)"},{"line_number":317,"context_line":"                      and isinstance(row[1], models.Node)):"},{"line_number":318,"context_line":"                    new_obj \u003d row[0]"},{"line_number":319,"context_line":"                    new_obj.node_uuid \u003d row[1].uuid"},{"line_number":320,"context_line":"                    combined_res.append(tuple([new_obj]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"82219947_f78de151","line":317,"updated":"2022-10-28 13:36:32.000000000","message":"Hmm, this is going to be costly if we need to do instance checking for every case where we want to do this. :\\ Hmmm!\n\nthis is also the path I think we need to work towards eliminating for any sort of bulk operation.","commit_id":"b0fc53339f5e9a50525a4f9f1a36a2c0fc7a7b22"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9981d5018df5a0965337437c42c8e153cd6ae271","unresolved":true,"context_lines":[{"line_number":335,"context_line":"            # object is garbage collected as ORM Query objects allow"},{"line_number":336,"context_line":"            # for DB interactions to occur after the fact, so it remains"},{"line_number":337,"context_line":"            # connected to the DB.."},{"line_number":338,"context_line":"            return combine_joined_models(query.all())"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            # In this case, we have a sqlalchemy.sql.selectable.Select"},{"line_number":341,"context_line":"            # (most likely) which utilizes the unified select interface."}],"source_content_type":"text/x-python","patch_set":4,"id":"c85a152f_abf92170","line":338,"range":{"start_line":338,"start_character":19,"end_line":338,"end_character":40},"updated":"2022-10-28 12:55:51.000000000","message":"Most likely don\u0027t need to do the combine here.","commit_id":"b0fc53339f5e9a50525a4f9f1a36a2c0fc7a7b22"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f133a78f82273153b1ff3a1f975bfcbd2de82e7c","unresolved":true,"context_lines":[{"line_number":335,"context_line":"            # object is garbage collected as ORM Query objects allow"},{"line_number":336,"context_line":"            # for DB interactions to occur after the fact, so it remains"},{"line_number":337,"context_line":"            # connected to the DB.."},{"line_number":338,"context_line":"            return combine_joined_models(query.all())"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            # In this case, we have a sqlalchemy.sql.selectable.Select"},{"line_number":341,"context_line":"            # (most likely) which utilizes the unified select interface."}],"source_content_type":"text/x-python","patch_set":4,"id":"0a1c5986_88da771c","line":338,"range":{"start_line":338,"start_character":19,"end_line":338,"end_character":40},"in_reply_to":"c85a152f_abf92170","updated":"2022-10-28 13:36:32.000000000","message":"Yeah, I was thinking the path to achieve this was just get sqlalchemy to do it entirely for us so we didn\u0027t have to do any model response pre-processing.","commit_id":"b0fc53339f5e9a50525a4f9f1a36a2c0fc7a7b22"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f133a78f82273153b1ff3a1f975bfcbd2de82e7c","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"                                  sort_key\u003dNone, sort_dir\u003dNone, owner\u003dNone,"},{"line_number":1028,"context_line":"                                  project\u003dNone):"},{"line_number":1029,"context_line":"        query \u003d ("},{"line_number":1030,"context_line":"            sa.select(models.Port, models.Node)"},{"line_number":1031,"context_line":"            .options(Load(models.Node).load_only(models.Node.uuid))"},{"line_number":1032,"context_line":"            .join(models.Node, models.Port.node_id \u003d\u003d models.Node.id)"},{"line_number":1033,"context_line":"            .where(models.Port.portgroup_id \u003d\u003d portgroup_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2ac1bc66_0ef06af9","line":1030,"range":{"start_line":1030,"start_character":34,"end_line":1030,"end_character":46},"updated":"2022-10-28 13:36:32.000000000","message":"So, I wonder if this could be models.Node.uuid instead of models.Node. The first item asks for the entire object, the second might be, and load_only is below...","commit_id":"b0fc53339f5e9a50525a4f9f1a36a2c0fc7a7b22"}]}