)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fc6bc3b4b625eb3d58a218826cd5c969df02e320","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-11 13:08:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use association_proxy for ports node_uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds \u0027node_uuid\u0027 to ironic.objects.port.Port"},{"line_number":10,"context_line":"and adds a relationship using association_proxy in"},{"line_number":11,"context_line":"models.Port. Using the association_proxy removes the need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ec2dedfc_5ed754d6","line":8,"updated":"2022-11-16 20:18:05.000000000","message":"If this is what gives us the 3000%+ perf increase demonstrated in IRC today; please explicitly say that in the commit message.","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f3ba930cbaf3a1eae5ad7b80ac6cda1921632d75","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-11-11 13:08:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use association_proxy for ports node_uuid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds \u0027node_uuid\u0027 to ironic.objects.port.Port"},{"line_number":10,"context_line":"and adds a relationship using association_proxy in"},{"line_number":11,"context_line":"models.Port. Using the association_proxy removes the need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"01d3e1c8_8bbdd018","line":8,"in_reply_to":"ec2dedfc_5ed754d6","updated":"2022-11-17 00:06:57.000000000","message":"I added my test results in commit message. Full test output here: https://paste.opendev.org/show/boW6bFAIxuh4bMcYsvse/","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fc6bc3b4b625eb3d58a218826cd5c969df02e320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad09f484_0338255a","updated":"2022-11-16 20:18:05.000000000","message":"Leaving this up for some visibility even though I\u0027m the second +2. If I haven\u0027t landed this by the EOW, ping me on IRC and I will.","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa1ce09ba8f16f3009da83940f45b53ef46421cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c91a212_f8145dad","updated":"2022-11-16 18:48:10.000000000","message":"Looks GREAT to me!","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"bca2525ddef6ab24e15457fcfb06c441f8055a0c","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            \u0027pxe_enabled\u0027,"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"    )"},{"line_number":128,"context_line":"    api_utils.populate_node_uuid(rpc_port, port)"},{"line_number":129,"context_line":"    if rpc_port.portgroup_id:"},{"line_number":130,"context_line":"        pg \u003d objects.Portgroup.get(api.request.context, rpc_port.portgroup_id)"},{"line_number":131,"context_line":"        port[\u0027portgroup_uuid\u0027] \u003d pg.uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"35818bde_be790fd0","side":"PARENT","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":48},"updated":"2022-11-02 13:28:42.000000000","message":"The unit tests test_list_with_deleted_node fails, with this removed.","commit_id":"5d5ae595380ac506eeb6a369e26efaed338790d1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"37b0f1dbd3b226f211ad4473ca794473cdbffd56","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027pxe_enabled\u0027,"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"    )"},{"line_number":128,"context_line":"    api_utils.populate_node_uuid(rpc_port, port)"},{"line_number":129,"context_line":"    if rpc_port.portgroup_id:"},{"line_number":130,"context_line":"        pg \u003d objects.Portgroup.get(api.request.context, rpc_port.portgroup_id)"},{"line_number":131,"context_line":"        port[\u0027portgroup_uuid\u0027] \u003d pg.uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"870de0d0_ccc5d8e4","side":"PARENT","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":48},"in_reply_to":"35818bde_be790fd0","updated":"2022-11-11 12:02:25.000000000","message":"Removed the tests.\n\nAdded a filter to remove ports with NULL value for node_uuid in the database query.\n(SELECT nodes.uuid FROM nodes WHERE nodes.id \u003d ports.node_id) IS NOT NULL","commit_id":"5d5ae595380ac506eeb6a369e26efaed338790d1"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa1ce09ba8f16f3009da83940f45b53ef46421cf","unresolved":true,"context_lines":[{"line_number":985,"context_line":"            models.Port.portgroup_id \u003d\u003d portgroup_id)"},{"line_number":986,"context_line":"        # Filter ports with \u0027null\u0027 value in node_uuid. If the node was"},{"line_number":987,"context_line":"        # deleted, the port was deleted as well."},{"line_number":988,"context_line":"        query \u003d add_port_filter_node_uuid_is_not_none(query)"},{"line_number":989,"context_line":"        if owner:"},{"line_number":990,"context_line":"            query \u003d add_port_filter_by_node_owner(query, owner)"},{"line_number":991,"context_line":"        elif project:"}],"source_content_type":"text/x-python","patch_set":4,"id":"80fffacf_c5135091","line":988,"updated":"2022-11-16 18:48:10.000000000","message":"makes sense and I *think* this fixes another long standing race condition bug.","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"065c04c9701e3f2e663774dd6c9c13e357ae2d87","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            models.Port.portgroup_id \u003d\u003d portgroup_id)"},{"line_number":986,"context_line":"        # Filter ports with \u0027null\u0027 value in node_uuid. If the node was"},{"line_number":987,"context_line":"        # deleted, the port was deleted as well."},{"line_number":988,"context_line":"        query \u003d add_port_filter_node_uuid_is_not_none(query)"},{"line_number":989,"context_line":"        if owner:"},{"line_number":990,"context_line":"            query \u003d add_port_filter_by_node_owner(query, owner)"},{"line_number":991,"context_line":"        elif project:"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2a31980_c207449b","line":988,"in_reply_to":"80fffacf_c5135091","updated":"2023-01-10 14:38:52.000000000","message":"Done","commit_id":"b2a4d5a40319180ddd0ad1b9c97cec43026807a7"}],"ironic/objects/port.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"bca2525ddef6ab24e15457fcfb06c441f8055a0c","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        # via association_proxy relationship is loaded."},{"line_number":385,"context_line":"        # TODO(hjensas): It might be possible change the creator for the"},{"line_number":386,"context_line":"        #  association_proxy in models.Port, removing the need for this read."},{"line_number":387,"context_line":"        db_port \u003d self.dbapi.get_port_by_id(db_port[\u0027id\u0027])"},{"line_number":388,"context_line":"        self._from_db_object(self._context, self, db_port)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    # NOTE(xek): We don\u0027t want to enable RPC on this call just yet. Remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"33e00a05_b8371f99","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":58},"updated":"2022-11-02 13:28:42.000000000","message":":( Having to do a read after each create is not great.","commit_id":"003a4d7005045f8a1e5e3a0814a9f4e7ebb94d9a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa1ce09ba8f16f3009da83940f45b53ef46421cf","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        # via association_proxy relationship is loaded."},{"line_number":385,"context_line":"        # TODO(hjensas): It might be possible change the creator for the"},{"line_number":386,"context_line":"        #  association_proxy in models.Port, removing the need for this read."},{"line_number":387,"context_line":"        db_port \u003d self.dbapi.get_port_by_id(db_port[\u0027id\u0027])"},{"line_number":388,"context_line":"        self._from_db_object(self._context, self, db_port)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    # NOTE(xek): We don\u0027t want to enable RPC on this call just yet. Remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa673f38_7614e926","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":58},"in_reply_to":"33e00a05_b8371f99","updated":"2022-11-16 18:48:10.000000000","message":"we actually need to do it in multiple places, and the *secret* is sqlalchemy does it automatically in many places which gets hidden inside ORM.","commit_id":"003a4d7005045f8a1e5e3a0814a9f4e7ebb94d9a"}]}