)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"349db83b5188cdad4e5166ef39018444f054dc0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3e355a35_adbb1d72","updated":"2023-08-17 15:22:26.000000000","message":"Seems reasonable to me.","commit_id":"73075e04ee00b2c52772eb0b951d905bf401e4e2"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"349db83b5188cdad4e5166ef39018444f054dc0d","unresolved":true,"context_lines":[{"line_number":351,"context_line":"                 \u0027%(value)s\u0027, {\u0027node\u0027: task.node.uuid, \u0027value\u0027: mode})"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def _wait_for_boot_mode(self, task, mode):"},{"line_number":354,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":355,"context_line":"        # TODO(janders)"},{"line_number":356,"context_line":"        # NOTE(dtantsur/janders): at least Dell machines change boot mode via"},{"line_number":357,"context_line":"        # a BIOS configuration job. A reboot is needed to apply it."}],"source_content_type":"text/x-python","patch_set":8,"id":"69201b67_54739d0f","line":354,"updated":"2023-08-17 15:22:26.000000000","message":"It\u0027s probably better to use system.refresh() with force. Otherwise there is a risk that the system is cached on the cached connection.","commit_id":"73075e04ee00b2c52772eb0b951d905bf401e4e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3b5eb51f9beaec5521d243489946788040464b1","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                 \u0027%(value)s\u0027, {\u0027node\u0027: task.node.uuid, \u0027value\u0027: mode})"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def _wait_for_boot_mode(self, task, mode):"},{"line_number":354,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":355,"context_line":"        # TODO(janders)"},{"line_number":356,"context_line":"        # NOTE(dtantsur/janders): at least Dell machines change boot mode via"},{"line_number":357,"context_line":"        # a BIOS configuration job. A reboot is needed to apply it."}],"source_content_type":"text/x-python","patch_set":8,"id":"0a53993e_44568028","line":354,"in_reply_to":"69201b67_54739d0f","updated":"2023-09-12 14:45:12.000000000","message":"Done","commit_id":"73075e04ee00b2c52772eb0b951d905bf401e4e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"349db83b5188cdad4e5166ef39018444f054dc0d","unresolved":true,"context_lines":[{"line_number":357,"context_line":"        # a BIOS configuration job. A reboot is needed to apply it."},{"line_number":358,"context_line":"        # TODO(janders) find out if caching may be a problem here"},{"line_number":359,"context_line":"        if system.boot.get(\u0027mode\u0027) \u003d\u003d BOOT_MODE_MAP_REV[mode]:"},{"line_number":360,"context_line":"            LOG.info(\u0027Node %(node)s is already configured with requested \u0027"},{"line_number":361,"context_line":"                     \u0027boot mode %(new_value)s.\u0027,"},{"line_number":362,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":363,"context_line":"                      \u0027new_value\u0027: BOOT_MODE_MAP_REV[mode]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"03e0cc2f_388e4ec0","line":360,"updated":"2023-08-17 15:22:26.000000000","message":"s/info/debug/","commit_id":"73075e04ee00b2c52772eb0b951d905bf401e4e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3b5eb51f9beaec5521d243489946788040464b1","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        # a BIOS configuration job. A reboot is needed to apply it."},{"line_number":358,"context_line":"        # TODO(janders) find out if caching may be a problem here"},{"line_number":359,"context_line":"        if system.boot.get(\u0027mode\u0027) \u003d\u003d BOOT_MODE_MAP_REV[mode]:"},{"line_number":360,"context_line":"            LOG.info(\u0027Node %(node)s is already configured with requested \u0027"},{"line_number":361,"context_line":"                     \u0027boot mode %(new_value)s.\u0027,"},{"line_number":362,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":363,"context_line":"                      \u0027new_value\u0027: BOOT_MODE_MAP_REV[mode]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d58dd39_3cf12f35","line":360,"in_reply_to":"03e0cc2f_388e4ec0","updated":"2023-09-12 14:45:12.000000000","message":"Done","commit_id":"73075e04ee00b2c52772eb0b951d905bf401e4e2"}],"releasenotes/notes/uefi-and-secureboot-waits-a783215327164e2c.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8cf8e17622be7b12c462c23bdc2c346bbb3eadf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9e683d02_be65010b","line":8,"updated":"2023-09-11 16:53:24.000000000","message":"Given we have an API endpoint to set boot mode, this is a pretty large change in behavior. Can we indicate that behavior change in a release note, and update the API Ref if needed to indicate changing boot mode can lead to a reboot?\n\nI don\u0027t have a good handle on the use case for the separate API; but we may want to even consider gating \"don\u0027t reboot ever for boot mode\" behind an API or configuration flag.","commit_id":"e355eff83851e7470c3d1b04a4a0a3dc372902e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3c990d3265e61c8caec100d9b45b6e71f93bb007","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    (``/v1/nodes/{node_ident}/states/boot_mode`` and"},{"line_number":12,"context_line":"    ``/v1/nodes/{node_ident}/states/secure_boot`` accordingly) may now"},{"line_number":13,"context_line":"    result in a reboot. This happens when the change cannot be applied"},{"line_number":14,"context_line":"    immediately. Previously, the change would be applied whenever the next"},{"line_number":15,"context_line":"    reboot happens for any unrelated reason, causing inconsistent behavior."},{"line_number":16,"context_line":"issues:"},{"line_number":17,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9dac5c68_437131ea","line":14,"updated":"2023-09-12 16:33:21.000000000","message":"I wouldn\u0027t hate wording like \"Previously, on impacted hardware, the change...\" but it\u0027s OK as-is too.","commit_id":"6487b958136e41d2f672c2d80845b876f37b0561"}]}