)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a46348a395506712bec78ff8fcff1c54c285ad70","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When pxe-booting, try to set the boot device. Setting the"},{"line_number":10,"context_line":"boot device could result in an IPMI failure -- we don\u0027t"},{"line_number":11,"context_line":"want that to cause a failure in the pxe-booting process."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When retrying a pxe boot, modify the log to indicate what"},{"line_number":14,"context_line":"provision state the ironic node is in. The data gathered"},{"line_number":15,"context_line":"could be useful for tweaking the option settings like the"},{"line_number":16,"context_line":"[pxe]boot_retry_timeout value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2aa3cbc4b9fa33ad8cf84d1a782ea1fbd14cd5b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"acf34da7_2e583d25","line":16,"range":{"start_line":12,"start_character":0,"end_line":16,"end_character":30},"updated":"2022-11-21 17:51:16.000000000","message":"O.o","commit_id":"48c70c4d99b78dcb0660aea738c6c20be3fc767f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"323cbad82d9e888fa5e330cfd1fcc9c01d94401d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When pxe-booting, try to set the boot device. Setting the"},{"line_number":10,"context_line":"boot device could result in an IPMI failure -- we don\u0027t"},{"line_number":11,"context_line":"want that to cause a failure in the pxe-booting process."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When retrying a pxe boot, modify the log to indicate what"},{"line_number":14,"context_line":"provision state the ironic node is in. The data gathered"},{"line_number":15,"context_line":"could be useful for tweaking the option settings like the"},{"line_number":16,"context_line":"[pxe]boot_retry_timeout value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2aa3cbc4b9fa33ad8cf84d1a782ea1fbd14cd5b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8eed5768_70cede56","line":16,"range":{"start_line":12,"start_character":0,"end_line":16,"end_character":30},"in_reply_to":"acf34da7_2e583d25","updated":"2022-11-21 18:43:03.000000000","message":"ha ha. would you like me to remove that? i wanted to know how many times a reboot had to be done, for the clean or deploy to work (or not work). We\u0027ve got some questionable machines and/or networking or something...","commit_id":"48c70c4d99b78dcb0660aea738c6c20be3fc767f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"323cbad82d9e888fa5e330cfd1fcc9c01d94401d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c118cb6a_821a45ff","updated":"2022-11-21 18:43:03.000000000","message":"Thanks for reviewing!","commit_id":"48c70c4d99b78dcb0660aea738c6c20be3fc767f"}],"ironic/drivers/modules/pxe_base.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a46348a395506712bec78ff8fcff1c54c285ad70","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                                    pxe_config_template,"},{"line_number":203,"context_line":"                                    ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":204,"context_line":"        deploy_utils.try_set_boot_device(task, boot_devices.PXE,"},{"line_number":205,"context_line":"                                         persistent\u003dFalse)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if self.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":208,"context_line":"            kernel_label \u003d \u0027%s_kernel\u0027 % mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"621e7571_b92292a6","line":205,"updated":"2022-11-21 17:51:16.000000000","message":"So this is only going to not error if the node is in UEFI mode. Is that what we want?","commit_id":"48c70c4d99b78dcb0660aea738c6c20be3fc767f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"323cbad82d9e888fa5e330cfd1fcc9c01d94401d","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                                    pxe_config_template,"},{"line_number":203,"context_line":"                                    ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":204,"context_line":"        deploy_utils.try_set_boot_device(task, boot_devices.PXE,"},{"line_number":205,"context_line":"                                         persistent\u003dFalse)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if self.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":208,"context_line":"            kernel_label \u003d \u0027%s_kernel\u0027 % mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"220dc7d9_4c5cf799","line":205,"in_reply_to":"621e7571_b92292a6","updated":"2022-11-21 18:43:03.000000000","message":"honestly, downstream we modified try_set_boot_device() to NEVER error. Upstream, that won\u0027t error if try_set_boot_device() doesn\u0027t error. Right now, the try_set_boot_device() handles uefi boot mode. Next year, who knows (well, prob. won\u0027t be changed)? Since agent_base.py calls try_set_boot_device() [1], I think it makes sense to be consistent.\n\n[1] https://opendev.org/openstack/ironic/src/commit/e91b59c47e28b94e0c84abf0e50dde985e7ca100/ironic/drivers/modules/agent_base.py","commit_id":"48c70c4d99b78dcb0660aea738c6c20be3fc767f"}]}