)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"03cf1599823a0ebe89c98de015b04f61e9776349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1375557d_ac02e131","updated":"2022-12-06 08:57:56.000000000","message":"recheck","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"04f8500ed7a719bae4612aaa4ac725169a70e45a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a089979_5fb4555c","updated":"2022-12-06 05:26:46.000000000","message":"recheck","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"ff9a03d2130cd10c0b04d9bef131ceb703d2071c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7b2d47a_d8ea6d7c","updated":"2022-12-07 05:33:12.000000000","message":"recheck\n\nIt seems tinycorelinux.net is not healthy.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a251a800798c24e0259de5192f8566fc40fbbfbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2154e9b6_f25c091c","updated":"2022-12-12 23:08:27.000000000","message":"I\u0027m confused as to the approach; can\u0027t you just reconfigure the BMC to enable IPMI over LAN if it\u0027s disabled? Why would you still prefer the IPMI methods for older firmwares? (Just to avoid behavior change?)","commit_id":"146724f40ca73a6376625ad896369197becbacad"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0016c7bffee5fcec32b05a96cb3e0a5850737df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e5997aee_29d2f12f","updated":"2022-12-13 06:13:38.000000000","message":"Thanks for review!","commit_id":"146724f40ca73a6376625ad896369197becbacad"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"0016c7bffee5fcec32b05a96cb3e0a5850737df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"950eea7c_b6d0fb2f","in_reply_to":"2154e9b6_f25c091c","updated":"2022-12-13 06:13:38.000000000","message":"Regarding new version of firmware:\nServer firmware team wants to discourage use of IPMI because they think IPMI is less secure compared to HTTPS. Incompatibility introduced in new version of firmware is representation of such discouragement. So I would like to use HTTPS instead of IPMI.\n\nRegarding old version of firmware:\nReason why I continue to use IPMI on old firmware version is (as you said) to avoid behavior change of existing user.","commit_id":"146724f40ca73a6376625ad896369197becbacad"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ef5535c94ec8015566c34d83f7a65fec91feefee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc3196e0_66605749","in_reply_to":"950eea7c_b6d0fb2f","updated":"2022-12-13 17:32:14.000000000","message":"I\u0027d almost prefer that instead of trying to handle the version and make decisions based upon that, that we take a \"does this work? yes/no, okay, that didn\u0027t work, what about this? yes/no, okay, the other two didn\u0027t work, lets try this last possible option.\n\nI agree with FJ Hardware Engineering, IPMI is basically insecure and highly problematic and we (the community) should not be encouraging or requiring IPMI usage. Adding a bunch of version detection logic and forked logic based upon version just seems problematic and painful where as we can try/fallback appropriately based upon the situation.","commit_id":"146724f40ca73a6376625ad896369197becbacad"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3cad434f1f14d3ea5b8da5001045ac84a7e50680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e4cf59b_e626bc7e","updated":"2022-12-13 17:40:23.000000000","message":"I\u0027ll note that upon further consideration, the version tracking method used here is not really going to be backportable for multiple reasons.\n\nPlease switch to a try/fallback model if you want a patch that is more likely to be backportable.","commit_id":"5544a5b6bdfe569193c88f110b4f58b11f7ea03e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"f7c1790f3537f73656cb0286c5d7170bed118531","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8914ca68_df8fd785","updated":"2022-12-14 05:50:22.000000000","message":"Julia and JayF\nThanks for review.\n\nI have one concern on try/fallback model. If I follow this model, iRMC driver first tries IPMI, and if IPMI fails it tries Redfish.\nIn this case, IPMI operation is done through code in `driver/modules/ipmitool.py` in which code (especially `_exec_ipmitool` func) resends IPMI command till timeout reaches (timeout default value is set to 60s in `conf/ipmi.py`). So every IPMI operation attempt takes 60s and then Redfish operation runs.\nChanging default timeout value through `ironic.conf [ipmi] command_retry_timeout` affects another driver\u0027s IPMI operation. So changing timeout value to mitigate this delay is not good.\n\nSuch additional delay is bit hard thing, I think.","commit_id":"5544a5b6bdfe569193c88f110b4f58b11f7ea03e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"780b2cf2f4c80108cb20701d4798c1d15f448d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"496445ff_0bfcd3e1","in_reply_to":"8914ca68_df8fd785","updated":"2022-12-14 23:19:45.000000000","message":"I think it\u0027s reasonable to have a method in the IPMI module that would not retry for this use case. Don\u0027t let yourself be limited by the methods that already exist.","commit_id":"5544a5b6bdfe569193c88f110b4f58b11f7ea03e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"299ba17e6d321c63c6bc8b86f1d0b8449d5f3e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ec18bf48_81f16923","updated":"2022-12-16 05:28:42.000000000","message":"recheck","commit_id":"15dd2d8a4fec802c01752cedb98025b82f80c6aa"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"ff9ac4d8b898c51ea17ec19bb90bb3bd22d5b2ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2c568865_f8b20623","updated":"2022-12-19 12:18:53.000000000","message":"recheck","commit_id":"56fc82176e36ce5db554c7ea6106397f1c6c2db3"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"4f3255e4b19cd938d0e405217cc667442678c835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f9033545_aabacfc3","updated":"2022-12-20 10:40:48.000000000","message":"recheck","commit_id":"56fc82176e36ce5db554c7ea6106397f1c6c2db3"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"a1859b9dd9782377000cd5df543e1668a6111d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7600389c_ec6b81d1","updated":"2022-12-20 13:22:09.000000000","message":"recheck\n\nI think this Zuul failure is not caused by this patch\u0027s change because failed Zuul job is different between recheck.","commit_id":"56fc82176e36ce5db554c7ea6106397f1c6c2db3"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"557f8a5d378ec427d4338fddedc2e19371e78b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7e599e74_8fb83c80","updated":"2023-01-18 04:21:21.000000000","message":"fujitsu-irmc-recheck","commit_id":"d23f72ee501a5bdcc89806eb0ebbba929a36e64d"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"3f61bc75b953a076fccae140b10a6e618958ca3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d895f51f_df424da5","updated":"2023-01-17 11:24:07.000000000","message":"recheck","commit_id":"d23f72ee501a5bdcc89806eb0ebbba929a36e64d"}],"doc/source/admin/drivers/irmc.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":144,"context_line":"  - ``driver_info/redfish_password`` to be password of ``redfish_username``"},{"line_number":145,"context_line":"  - ``driver_info/redfish_verify_ca`` accepts values those accepted in"},{"line_number":146,"context_line":"    ``driver_info/irmc_verify_ca``"},{"line_number":147,"context_line":"  - ``driver_info/redfish_auth_type`` to be ``basic``"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* If ``port`` in ``[irmc]`` section of ``/etc/ironic/ironic.conf`` or"},{"line_number":150,"context_line":"  ``driver_info/irmc_port`` is set to 443, ``driver_info/irmc_verify_ca``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e2d279e3_66c9fbed","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":53},"updated":"2022-12-07 20:55:27.000000000","message":"This is problematic performance wise. Is it necessary? Can we confirm the irmc\u0027s don\u0027t have API session limits? This means new authentication will be performed every interaction as well.\n\nPerhaps the actual primary question, do iRMC BMCs not support session authentication?","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  - ``driver_info/redfish_password`` to be password of ``redfish_username``"},{"line_number":145,"context_line":"  - ``driver_info/redfish_verify_ca`` accepts values those accepted in"},{"line_number":146,"context_line":"    ``driver_info/irmc_verify_ca``"},{"line_number":147,"context_line":"  - ``driver_info/redfish_auth_type`` to be ``basic``"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* If ``port`` in ``[irmc]`` section of ``/etc/ironic/ironic.conf`` or"},{"line_number":150,"context_line":"  ``driver_info/irmc_port`` is set to 443, ``driver_info/irmc_verify_ca``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d2dd381c_65dcd1ef","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":53},"in_reply_to":"e2d279e3_66c9fbed","updated":"2022-12-08 07:43:35.000000000","message":"I overlooked this option. I confirm session and auto authentication works.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"}],"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"468296eb15154a2a8b6264e1b99c15f6b0327b7a","unresolved":true,"context_lines":[{"line_number":644,"context_line":"    for param in redfish_params:"},{"line_number":645,"context_line":"        if (not parsed_info.get(param)"},{"line_number":646,"context_line":"            or node.driver_info.get(param) !\u003d parsed_info.get(param)):"},{"line_number":647,"context_line":"            need_refresh \u003d True"},{"line_number":648,"context_line":"            break"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"c12fc384_79f00943","line":648,"range":{"start_line":647,"start_character":0,"end_line":648,"end_character":17},"updated":"2022-11-21 23:15:43.000000000","message":"so if one is missing, of two optional paremeters (redfish_verify_ca, and redfish_auth_type), then we immediately proceed. I\u0027d prefer to handle it item by item if at all possible.","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"53ffa30e0103125e75c156f742d3a9424febfee0","unresolved":false,"context_lines":[{"line_number":644,"context_line":"    for param in redfish_params:"},{"line_number":645,"context_line":"        if (not parsed_info.get(param)"},{"line_number":646,"context_line":"            or node.driver_info.get(param) !\u003d parsed_info.get(param)):"},{"line_number":647,"context_line":"            need_refresh \u003d True"},{"line_number":648,"context_line":"            break"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"a90c5d5a_078e4015","line":648,"range":{"start_line":647,"start_character":0,"end_line":648,"end_character":17},"in_reply_to":"c12fc384_79f00943","updated":"2022-12-05 09:08:24.000000000","message":"Done","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"468296eb15154a2a8b6264e1b99c15f6b0327b7a","unresolved":true,"context_lines":[{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"},{"line_number":652,"context_line":"        d_info[\u0027redfish_address\u0027] \u003d parsed_info[\u0027irmc_address\u0027]"},{"line_number":653,"context_line":"        d_info[\u0027redfish_username\u0027] \u003d parsed_info[\u0027irmc_username\u0027]"},{"line_number":654,"context_line":"        d_info[\u0027redfish_password\u0027] \u003d parsed_info[\u0027irmc_password\u0027]"},{"line_number":655,"context_line":"        d_info[\u0027redfish_verify_ca\u0027] \u003d parsed_info[\u0027irmc_verify_ca\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"c971b9c6_75856796","line":652,"updated":"2022-11-21 23:15:43.000000000","message":"The redfish_address is a URL if memory serves, that seems like it is going to need to more modification?","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"53ffa30e0103125e75c156f742d3a9424febfee0","unresolved":false,"context_lines":[{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"},{"line_number":652,"context_line":"        d_info[\u0027redfish_address\u0027] \u003d parsed_info[\u0027irmc_address\u0027]"},{"line_number":653,"context_line":"        d_info[\u0027redfish_username\u0027] \u003d parsed_info[\u0027irmc_username\u0027]"},{"line_number":654,"context_line":"        d_info[\u0027redfish_password\u0027] \u003d parsed_info[\u0027irmc_password\u0027]"},{"line_number":655,"context_line":"        d_info[\u0027redfish_verify_ca\u0027] \u003d parsed_info[\u0027irmc_verify_ca\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8b683d0_9401c363","line":652,"in_reply_to":"c971b9c6_75856796","updated":"2022-12-05 09:08:24.000000000","message":"redfish parse_driver_info adds \u0027https://\u0027 if \u0027redfish_address\u0027 only contains IP/hostname.","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"468296eb15154a2a8b6264e1b99c15f6b0327b7a","unresolved":true,"context_lines":[{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"},{"line_number":652,"context_line":"        d_info[\u0027redfish_address\u0027] \u003d parsed_info[\u0027irmc_address\u0027]"},{"line_number":653,"context_line":"        d_info[\u0027redfish_username\u0027] \u003d parsed_info[\u0027irmc_username\u0027]"},{"line_number":654,"context_line":"        d_info[\u0027redfish_password\u0027] \u003d parsed_info[\u0027irmc_password\u0027]"},{"line_number":655,"context_line":"        d_info[\u0027redfish_verify_ca\u0027] \u003d parsed_info[\u0027irmc_verify_ca\u0027]"},{"line_number":656,"context_line":"        d_info[\u0027redfish_auth_type\u0027] \u003d parsed_info[\u0027irmc_auth_method\u0027]"},{"line_number":657,"context_line":"        node.driver_info \u003d d_info"},{"line_number":658,"context_line":"        node.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f91250d3_0b359d38","line":656,"range":{"start_line":652,"start_character":1,"end_line":656,"end_character":69},"updated":"2022-11-21 23:15:43.000000000","message":"This pattern concerns me because we:\n1) Generally shouldn\u0027t be self-editing driver_info.\n1.5) I suspect this might be okay *if* the value is not already set.\n2) A common operational pattern, we at least see with other vendor hardware is for all of these parameters to already be set.","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"53ffa30e0103125e75c156f742d3a9424febfee0","unresolved":false,"context_lines":[{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    if need_refresh:"},{"line_number":651,"context_line":"        d_info \u003d node.driver_info"},{"line_number":652,"context_line":"        d_info[\u0027redfish_address\u0027] \u003d parsed_info[\u0027irmc_address\u0027]"},{"line_number":653,"context_line":"        d_info[\u0027redfish_username\u0027] \u003d parsed_info[\u0027irmc_username\u0027]"},{"line_number":654,"context_line":"        d_info[\u0027redfish_password\u0027] \u003d parsed_info[\u0027irmc_password\u0027]"},{"line_number":655,"context_line":"        d_info[\u0027redfish_verify_ca\u0027] \u003d parsed_info[\u0027irmc_verify_ca\u0027]"},{"line_number":656,"context_line":"        d_info[\u0027redfish_auth_type\u0027] \u003d parsed_info[\u0027irmc_auth_method\u0027]"},{"line_number":657,"context_line":"        node.driver_info \u003d d_info"},{"line_number":658,"context_line":"        node.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"94d4308c_9f55ac05","line":656,"range":{"start_line":652,"start_character":1,"end_line":656,"end_character":69},"in_reply_to":"f91250d3_0b359d38","updated":"2022-12-05 09:08:24.000000000","message":"I decided to let user set \u0027redfish_*\u0027 parameters. I\u0027ll modify doc to notify user to set \u0027redfish_*\u0027 if user use Fujitsu server with iRMC S6 2.00 and later.\nIf user doesn\u0027t set \u0027redfish_*\u0027 params in \u0027driver_info\u0027, user will be told to set them through error in \u0027verifying\u0027.","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"}],"ironic/drivers/modules/irmc/inspect.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"468296eb15154a2a8b6264e1b99c15f6b0327b7a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"from ironic import objects"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"scci \u003d importutils.try_import(\u0027scciclient.irmc.scci\u0027)"},{"line_number":36,"context_line":"irmc \u003d importutils.try_import(\u0027scciclient.irmc\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa8a93d9_336733cd","line":36,"updated":"2022-11-21 23:15:43.000000000","message":"maybe just import irmc, and then create scci separately?","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"53ffa30e0103125e75c156f742d3a9424febfee0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from ironic import objects"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"scci \u003d importutils.try_import(\u0027scciclient.irmc.scci\u0027)"},{"line_number":36,"context_line":"irmc \u003d importutils.try_import(\u0027scciclient.irmc\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a3bf3313_ea870cd4","line":36,"in_reply_to":"fa8a93d9_336733cd","updated":"2022-12-05 09:08:24.000000000","message":"Done","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"53ffa30e0103125e75c156f742d3a9424febfee0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            if c \u003d\u003d NODE_CLASS_OID_VALUE[\u0027primary\u0027]]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _inspect_hardware(node, existing_traits\u003dNone, **kwargs):"},{"line_number":127,"context_line":"    \"\"\"Inspect the node and get hardware information."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: node object."}],"source_content_type":"text/x-python","patch_set":1,"id":"f11c9d81_56d4fd27","line":126,"in_reply_to":"cfd28fe7_e1a793a9","updated":"2022-12-05 09:08:24.000000000","message":"Done","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"468296eb15154a2a8b6264e1b99c15f6b0327b7a","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            if c \u003d\u003d NODE_CLASS_OID_VALUE[\u0027primary\u0027]]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _inspect_hardware(node, existing_traits\u003dNone, **kwargs):"},{"line_number":127,"context_line":"    \"\"\"Inspect the node and get hardware information."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: node object."}],"source_content_type":"text/x-python","patch_set":1,"id":"cfd28fe7_e1a793a9","line":126,"in_reply_to":"d09f6a38_1d9eb926","updated":"2022-11-21 23:15:43.000000000","message":"\u003e pep8: C901 \u0027_inspect_hardware\u0027 is too complex (20)\n\nPlease fix.","commit_id":"6e1f174b44bfea06e62dd0b6c192daaabaf8243c"}],"ironic/drivers/modules/irmc/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":576,"context_line":"        else:"},{"line_number":577,"context_line":"            return super(ipmitool.IPMIManagement, self).detect_vendor(task)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    def get_mac_addresses(self, task):"},{"line_number":580,"context_line":"        \"\"\"Get MAC address information for the node."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        IRMCManagement class doesn\u0027t support this method"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":585,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":588,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027get_mac_addresses\u0027)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    @base.verify_step(priority\u003d10)"},{"line_number":591,"context_line":"    def verify_http_https_connection_and_fw_version(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6001982_85e03611","line":588,"range":{"start_line":579,"start_character":0,"end_line":588,"end_character":67},"updated":"2022-12-07 20:55:27.000000000","message":"As an aside, for what it is worth, if you can support this somehow, as a feature outside of this patch, it would be a good idea as this can be used to enable identification/discovery of the node when deployed in say an edge hardware cabinet for a remote central office.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        else:"},{"line_number":577,"context_line":"            return super(ipmitool.IPMIManagement, self).detect_vendor(task)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    def get_mac_addresses(self, task):"},{"line_number":580,"context_line":"        \"\"\"Get MAC address information for the node."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        IRMCManagement class doesn\u0027t support this method"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":585,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":588,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027get_mac_addresses\u0027)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    @base.verify_step(priority\u003d10)"},{"line_number":591,"context_line":"    def verify_http_https_connection_and_fw_version(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"031c2728_645c8f13","line":588,"range":{"start_line":579,"start_character":0,"end_line":588,"end_character":67},"in_reply_to":"a6001982_85e03611","updated":"2022-12-08 07:43:35.000000000","message":"iRMC driver hasn\u0027t supported this. So for now, I disable this.\nIn transition to Redfish API (this means creation of new driver for Fujitsu server using Redfish), I will test if Fujitsu server\u0027s Redfish API can support this.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8ffa362c71f8afa760a632fc1be58330862778af","unresolved":true,"context_lines":[{"line_number":300,"context_line":"            data2 \u003d _BOOTPARAM5_DATA2[device]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            cmd8 \u003d bootparam5 % (data1, data2)"},{"line_number":303,"context_line":"            ipmitool.send_raw(task, cmd8, num_tries\u003d1)"},{"line_number":304,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":305,"context_line":"                exception.MissingParameterValue,"},{"line_number":306,"context_line":"                exception.IPMIFailure):"}],"source_content_type":"text/x-python","patch_set":10,"id":"97c5a3a3_b7c6e7b7","line":303,"range":{"start_line":303,"start_character":42,"end_line":303,"end_character":54},"updated":"2023-01-10 16:17:51.000000000","message":"It seems like what the prior patch is trying to do is explicitly disable internal retries here, but also not on line 282.\n\nI guess it would be helpful to understand why, but also I think calling it num_tries in the prior patch is misleading. What your trying to articulate is \"don\u0027t retry automatically\", which I think can be better encoded as an option to break the loop if set and a failure occurs.","commit_id":"56fc82176e36ce5db554c7ea6106397f1c6c2db3"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"ff15079806e8c37cc62a98300ea724f0acf7d01e","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            data2 \u003d _BOOTPARAM5_DATA2[device]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            cmd8 \u003d bootparam5 % (data1, data2)"},{"line_number":303,"context_line":"            ipmitool.send_raw(task, cmd8, num_tries\u003d1)"},{"line_number":304,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":305,"context_line":"                exception.MissingParameterValue,"},{"line_number":306,"context_line":"                exception.IPMIFailure):"}],"source_content_type":"text/x-python","patch_set":10,"id":"29b8dae4_c9d812fd","line":303,"range":{"start_line":303,"start_character":42,"end_line":303,"end_character":54},"in_reply_to":"97c5a3a3_b7c6e7b7","updated":"2023-01-13 02:56:22.000000000","message":"Thanks for review. The reason I add prior patch (867808) is, if I adopt try-fallback approach in this patch, every IPMI try takes 60seconds then fallback to Redfish. In iRMC driver, IPMI operation has been used in many places. So every 60s delay in IPMI try makes iRMC driver slow.\nYour advice on prior patch, \"don\u0027t retry automatically\" should be done on prior patch, is helpful","commit_id":"56fc82176e36ce5db554c7ea6106397f1c6c2db3"}],"ironic/drivers/modules/irmc/power.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        irmc_boot.attach_boot_iso_if_needed(task)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    try:"},{"line_number":181,"context_line":"        irmc_client(STATES_MAP[target_state])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    except KeyError:"},{"line_number":184,"context_line":"        msg \u003d _(\"_set_power_state called with invalid power state \""}],"source_content_type":"text/x-python","patch_set":4,"id":"e13eba5a_be938bbd","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":45},"updated":"2022-12-07 20:55:27.000000000","message":"Ahh, I see.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        irmc_boot.attach_boot_iso_if_needed(task)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    try:"},{"line_number":181,"context_line":"        irmc_client(STATES_MAP[target_state])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    except KeyError:"},{"line_number":184,"context_line":"        msg \u003d _(\"_set_power_state called with invalid power state \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7cde52e5_bbea5e4b","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":45},"in_reply_to":"e13eba5a_be938bbd","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":270,"context_line":"            ipmi_power \u003d ipmitool.IPMIPower()"},{"line_number":271,"context_line":"            return ipmi_power.get_power_state(task)"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            return super(IRMCPower, self).get_power_state(task)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @METRICS.timer(\u0027IRMCPower.set_power_state\u0027)"},{"line_number":276,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0abafb_0731d41b","line":273,"updated":"2022-12-07 20:55:27.000000000","message":"so Effectively, for only getting the power state, this uses the ipmi driver, or falls back to redfish... \n\nI guess this is something we might have expected in python-scciclient to just handle and understand, but the prior code was using the base interface, and as such I guess this kind of makes sense.\n\nBut I guess a question comes to mind overall, why ipmi at all?","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            ipmi_power \u003d ipmitool.IPMIPower()"},{"line_number":271,"context_line":"            return ipmi_power.get_power_state(task)"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            return super(IRMCPower, self).get_power_state(task)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @METRICS.timer(\u0027IRMCPower.set_power_state\u0027)"},{"line_number":276,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"99c89983_9a9a24db","line":273,"in_reply_to":"9a0abafb_0731d41b","updated":"2022-12-08 07:43:35.000000000","message":"\u003e But I guess a question comes to mind overall, why ipmi at all?\nThe reason is when iRMC driver was developed, there is no way to get power state in SCCI. Still now, SCCI cannot get power state but be able to set power state.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":286,"context_line":"          is missing on the node"},{"line_number":287,"context_line":"        :raises: IRMCOperationError if failed to set the power state."},{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":"        _set_power_state(task, power_state, timeout\u003dtimeout)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @METRICS.timer(\u0027IRMCPower.reboot\u0027)"},{"line_number":292,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"54812895_1558ccfd","line":289,"range":{"start_line":289,"start_character":1,"end_line":289,"end_character":60},"updated":"2022-12-07 20:55:27.000000000","message":"what about compatability for setting the power state?\n\nEdit: I see, that always invokes scciclient.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":286,"context_line":"          is missing on the node"},{"line_number":287,"context_line":"        :raises: IRMCOperationError if failed to set the power state."},{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":"        _set_power_state(task, power_state, timeout\u003dtimeout)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @METRICS.timer(\u0027IRMCPower.reboot\u0027)"},{"line_number":292,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"b1b86373_f81ce5a4","line":289,"range":{"start_line":289,"start_character":1,"end_line":289,"end_character":60},"in_reply_to":"54812895_1558ccfd","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"}],"releasenotes/notes/fix-irmc-s6-2.00-ipmi-incompatibility-118484a424df02b1.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7725c30b_4c5cea8b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2022-12-07 20:55:27.000000000","message":"So, depending on one\u0027s point of view, this can also be looked at as a feature. Other vendors have taken entirely different paths on this.\n\nI think this may just be okay, but I think we\u0027re going to need to be more specific with the release note.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a76169f5_af177103","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"7725c30b_4c5cea8b","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8927984f_7d323de8","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":67},"updated":"2022-12-07 20:55:27.000000000","message":"2.00 is the version, correct?","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f7f5da2a_a305c40e","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":9},"updated":"2022-12-07 20:55:27.000000000","message":"Whenever you fix a thing, please start it with \"Fixes an issue\" or \"Fixes support for\". Just from a consistency standpoint.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8e3fcfeb_aa11f5ce","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":67},"in_reply_to":"8927984f_7d323de8","updated":"2022-12-08 07:43:35.000000000","message":"yes","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6091f9e7_0acbd2ee","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":9},"in_reply_to":"f7f5da2a_a305c40e","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0ae164ce_0ce1671d","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":72},"updated":"2022-12-07 20:55:27.000000000","message":"s/with default iRMC configuration./by default./","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bd6e121c_a7392767","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":72},"in_reply_to":"0ae164ce_0ce1671d","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7e3fa714_0d0678cd","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":54},"updated":"2022-12-07 20:55:27.000000000","message":"This is an incomplete sentence. Also, who in this case is \"User\"\n\nI think what you mean is \"The Administrator/Operator must set redfish parameters in the ``driver_info`` so this fix can operate properly.\"","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deals with firmware incompatible behavior in which iRMC S6 2.00 and"},{"line_number":5,"context_line":"    later doesn\u0027t support IPMI over LAN with default iRMC configuration."},{"line_number":6,"context_line":"    User need to set Redfish parameters in driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"098c0e3c_290497b4","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":54},"in_reply_to":"7e3fa714_0d0678cd","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d2399bb3a8bfc6e77e685cdf43dc9ab1a2d28de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbafbe90_098f9594","line":7,"updated":"2022-12-07 20:55:27.000000000","message":"Also, You should add an Upgrade release note, indicating that users who are upgrading and utilize iRMC S6 hardware with a version of 2.0.0 are advised to set driver_info parameters for redfish driver usage moving forward.","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"e34d4a0eef6eff504c867b50b329ce2930e9e8a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca6196df_018ba971","line":7,"in_reply_to":"bbafbe90_098f9594","updated":"2022-12-08 07:43:35.000000000","message":"Ack","commit_id":"7c76588ff780dac4b55267a5c37a23eb6084394e"}]}