)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8794479ac064c69df95837c42845ead268a8a75f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"a ceilometer, ironic-prometheus-exporter, or other consumer of"},{"line_number":13,"context_line":"metrics event data on to the message bus."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This functionality is not presently supported on dedicated API services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change requires ironic-lib 5.4.0 to collect and ship metrics via"},{"line_number":18,"context_line":"the message bus."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"099896f0_892342a5","line":15,"updated":"2023-02-13 20:18:47.000000000","message":"What does this mean? We won\u0027t send metrics for ironic-api?","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f4950b37f2d4361d3e38fb62b40b949871d15a9","unresolved":true,"context_lines":[{"line_number":12,"context_line":"a ceilometer, ironic-prometheus-exporter, or other consumer of"},{"line_number":13,"context_line":"metrics event data on to the message bus."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This functionality is not presently supported on dedicated API services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change requires ironic-lib 5.4.0 to collect and ship metrics via"},{"line_number":18,"context_line":"the message bus."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2487f700_284ae350","line":15,"in_reply_to":"099896f0_892342a5","updated":"2023-02-13 20:38:40.000000000","message":"That is correct, we have no periodic to trigger the data to be collected, packaged, and shipped to the message bus.","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"476c4bb308fcbac4b0b966e3319d50c6442bebcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"322b1480_2f1a0675","updated":"2023-02-23 01:34:08.000000000","message":"One nit, and one bikeshed invitation","commit_id":"580297da2045122430c1fc2f2a10dba8ca3825e8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ce13c8228945a13c2147d9769031c11385cdb79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1cb370f3_a87f6040","updated":"2023-02-27 11:02:03.000000000","message":"recheck","commit_id":"82b8ec7a392516ec8fd292df8788784da7b319ad"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b1d6c2e695b5ad19734fcc8657aa39209a21f9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"22b0121b_63ea04d9","updated":"2023-02-27 13:56:38.000000000","message":"recheck mirror connection issues","commit_id":"82b8ec7a392516ec8fd292df8788784da7b319ad"}],"doc/source/admin/metrics.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8794479ac064c69df95837c42845ead268a8a75f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"and ironic-python-agent. By default, none of the services will emit metrics."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"It is important to stress that not only statsd is supported for metrics"},{"line_number":21,"context_line":"collection and transmission. This is covered later on in our documentation."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Configuring the Bare Metal Service to Enable Metrics with Statsd"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e948c264_6d6161e2","line":21,"updated":"2023-02-13 20:18:47.000000000","message":"Perhaps more here? About how we have a setup guide for prometheus?","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f4950b37f2d4361d3e38fb62b40b949871d15a9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"and ironic-python-agent. By default, none of the services will emit metrics."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"It is important to stress that not only statsd is supported for metrics"},{"line_number":21,"context_line":"collection and transmission. This is covered later on in our documentation."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Configuring the Bare Metal Service to Enable Metrics with Statsd"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fffb6235_534cdcbd","line":21,"in_reply_to":"e948c264_6d6161e2","updated":"2023-02-13 20:38:40.000000000","message":"I think that should be better suited by just pointing to the exporter docs, at least until we can polish things more. The key functionality behind this is  \"I can send it to the notifier.\"\n\nBesides, an independent change will be needed for i-p-e to decode/translate the new data stream.","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8794479ac064c69df95837c42845ead268a8a75f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"Transmission to the Message Bus Notifier"},{"line_number":73,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Regardless if your using Ceilometer,"},{"line_number":76,"context_line":"`ironic-prometheus-exporter \u003chttps://docs.openstack.org/ironic-prometheus-exporter/latest/\u003e`_,"},{"line_number":77,"context_line":"or some scripting you wrote to consume the message bus notifications,"},{"line_number":78,"context_line":"metrics data can be sent to the message bus notifier from the timer methods"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ac44901_95432402","line":75,"updated":"2023-02-13 20:18:47.000000000","message":"you\u0027re","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Transmission to the Message Bus Notifier"},{"line_number":73,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Regardless if your using Ceilometer,"},{"line_number":76,"context_line":"`ironic-prometheus-exporter \u003chttps://docs.openstack.org/ironic-prometheus-exporter/latest/\u003e`_,"},{"line_number":77,"context_line":"or some scripting you wrote to consume the message bus notifications,"},{"line_number":78,"context_line":"metrics data can be sent to the message bus notifier from the timer methods"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a854c2b7_ea6217cc","line":75,"in_reply_to":"9ac44901_95432402","updated":"2023-02-20 16:48:41.000000000","message":"Done","commit_id":"c761aa8497001a6bb26aae9e1b3764a39ffae706"}],"ironic/conductor/manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cfddb0fbe3170f95bf16029ce627e0583d3eff5b","unresolved":true,"context_lines":[{"line_number":2638,"context_line":"        try:"},{"line_number":2639,"context_line":"            ev_type \u003d \u0027ironic.metrics\u0027"},{"line_number":2640,"context_line":"            message[\u0027event_type\u0027] \u003d ev_type + \u0027.update\u0027"},{"line_number":2641,"context_line":"            sensors_data \u003d METRICS.get_metric_data()"},{"line_number":2642,"context_line":"        except AttributeError:"},{"line_number":2643,"context_line":"            LOG.warning("},{"line_number":2644,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"83c32377_026313ee","line":2641,"range":{"start_line":2641,"start_character":35,"end_line":2641,"end_character":50},"updated":"2023-01-05 18:11:04.000000000","message":"get_metrics_data","commit_id":"b679704fac013f68f0de8c3d86b53a1669f69231"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f4950b37f2d4361d3e38fb62b40b949871d15a9","unresolved":false,"context_lines":[{"line_number":2638,"context_line":"        try:"},{"line_number":2639,"context_line":"            ev_type \u003d \u0027ironic.metrics\u0027"},{"line_number":2640,"context_line":"            message[\u0027event_type\u0027] \u003d ev_type + \u0027.update\u0027"},{"line_number":2641,"context_line":"            sensors_data \u003d METRICS.get_metric_data()"},{"line_number":2642,"context_line":"        except AttributeError:"},{"line_number":2643,"context_line":"            LOG.warning("},{"line_number":2644,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"96d9e45a_6bb8e3b8","line":2641,"range":{"start_line":2641,"start_character":35,"end_line":2641,"end_character":50},"in_reply_to":"83c32377_026313ee","updated":"2023-02-13 20:38:40.000000000","message":"Done","commit_id":"b679704fac013f68f0de8c3d86b53a1669f69231"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cfddb0fbe3170f95bf16029ce627e0583d3eff5b","unresolved":true,"context_lines":[{"line_number":2642,"context_line":"        except AttributeError:"},{"line_number":2643,"context_line":"            LOG.warning("},{"line_number":2644,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"},{"line_number":2645,"context_line":"                \u0027conductor metris, however the installed ironic-lib \u0027"},{"line_number":2646,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2647,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2648,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca24456f_130120ad","line":2645,"range":{"start_line":2645,"start_character":27,"end_line":2645,"end_character":33},"updated":"2023-01-05 18:11:04.000000000","message":"metrics","commit_id":"b679704fac013f68f0de8c3d86b53a1669f69231"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f4950b37f2d4361d3e38fb62b40b949871d15a9","unresolved":false,"context_lines":[{"line_number":2642,"context_line":"        except AttributeError:"},{"line_number":2643,"context_line":"            LOG.warning("},{"line_number":2644,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"},{"line_number":2645,"context_line":"                \u0027conductor metris, however the installed ironic-lib \u0027"},{"line_number":2646,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2647,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2648,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9d766bba_442e994e","line":2645,"range":{"start_line":2645,"start_character":27,"end_line":2645,"end_character":33},"in_reply_to":"ca24456f_130120ad","updated":"2023-02-13 20:38:40.000000000","message":"Done","commit_id":"b679704fac013f68f0de8c3d86b53a1669f69231"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"        # report a count of the nodes"},{"line_number":1438,"context_line":"        METRICS.send_gauge("},{"line_number":1439,"context_line":"            \u0027ConductorManager.PowerSyncNodesCount\u0027,"},{"line_number":1440,"context_line":"            len(nodes))"},{"line_number":1441,"context_line":""},{"line_number":1442,"context_line":"    def _sync_power_state_nodes_task(self, context, nodes):"}],"source_content_type":"text/x-python","patch_set":7,"id":"2cd46921_ff8581ec","line":1439,"updated":"2023-02-20 14:06:13.000000000","message":"\u003c3","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":2649,"context_line":""},{"line_number":2650,"context_line":"        try:"},{"line_number":2651,"context_line":"            ev_type \u003d \u0027ironic.metrics\u0027"},{"line_number":2652,"context_line":"            message[\u0027event_type\u0027] \u003d ev_type + \u0027.update\u0027"},{"line_number":2653,"context_line":"            sensors_data \u003d METRICS.get_metrics_data()"},{"line_number":2654,"context_line":"        except AttributeError:"},{"line_number":2655,"context_line":"            LOG.warning("}],"source_content_type":"text/x-python","patch_set":7,"id":"2349ecb7_3f2c7824","line":2652,"updated":"2023-02-20 14:06:13.000000000","message":"nit: f\u0027{ev_type}.update\"\n\n(yes, I\u0027m seriously nit-picking on this! :)","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":2656,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"},{"line_number":2657,"context_line":"                \u0027conductor metrics, however the installed ironic-lib \u0027"},{"line_number":2658,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2659,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2660,"context_line":"        except Exception as e:"},{"line_number":2661,"context_line":"            LOG.warning("},{"line_number":2662,"context_line":"                \"An unknown error occured while attempting to collect \""}],"source_content_type":"text/x-python","patch_set":7,"id":"f6a887f6_b8eeb375","line":2659,"updated":"2023-02-20 14:06:13.000000000","message":"Do we have strong reasons not to update our requirements?","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":2656,"context_line":"                \u0027get_sensors_data has been configured to collect \u0027"},{"line_number":2657,"context_line":"                \u0027conductor metrics, however the installed ironic-lib \u0027"},{"line_number":2658,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2659,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2660,"context_line":"        except Exception as e:"},{"line_number":2661,"context_line":"            LOG.warning("},{"line_number":2662,"context_line":"                \"An unknown error occured while attempting to collect \""}],"source_content_type":"text/x-python","patch_set":7,"id":"ed45a472_7aa2b1c9","line":2659,"in_reply_to":"f6a887f6_b8eeb375","updated":"2023-02-20 16:48:41.000000000","message":"The code decouples the need for it, but the patch hadn\u0027t merged last I looked into the upper level repo. :( \u003cinsert sadness here\u003e","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":2658,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2659,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2660,"context_line":"        except Exception as e:"},{"line_number":2661,"context_line":"            LOG.warning("},{"line_number":2662,"context_line":"                \"An unknown error occured while attempting to collect \""},{"line_number":2663,"context_line":"                \"sensor data from within the conductor. Error: %(error)s\","},{"line_number":2664,"context_line":"                {\u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"a15bc1b3_b1ff5e6b","line":2661,"updated":"2023-02-20 14:06:13.000000000","message":"s/warning/exception/ maybe or at least log the traceback?","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":2658,"context_line":"                \u0027library lacks the functionality. Please consider \u0027"},{"line_number":2659,"context_line":"                \u0027upgrading ironic-lib.\u0027)"},{"line_number":2660,"context_line":"        except Exception as e:"},{"line_number":2661,"context_line":"            LOG.warning("},{"line_number":2662,"context_line":"                \"An unknown error occured while attempting to collect \""},{"line_number":2663,"context_line":"                \"sensor data from within the conductor. Error: %(error)s\","},{"line_number":2664,"context_line":"                {\u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"147b7c2b_9e1a2637","line":2661,"in_reply_to":"a15bc1b3_b1ff5e6b","updated":"2023-02-20 16:48:41.000000000","message":"Done. Makes more sense to be exception, I likely would have saved myself some headache when doing the initial testing.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"476c4bb308fcbac4b0b966e3319d50c6442bebcd","unresolved":true,"context_lines":[{"line_number":2666,"context_line":"        # or other data consumer"},{"line_number":2667,"context_line":"        message \u003d {\u0027message_id\u0027: uuidutils.generate_uuid(),"},{"line_number":2668,"context_line":"                   \u0027timestamp\u0027: datetime.datetime.utcnow(),"},{"line_number":2669,"context_line":"                   \u0027hostname\u0027: CONF.host}"},{"line_number":2670,"context_line":""},{"line_number":2671,"context_line":"        try:"},{"line_number":2672,"context_line":"            ev_type \u003d \u0027ironic.metrics\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"b0a2889a_cfe0e3d9","line":2669,"updated":"2023-02-23 01:34:08.000000000","message":"self.host might be more appropriate here?","commit_id":"580297da2045122430c1fc2f2a10dba8ca3825e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d66a4823f825132723359781d4a6035682ea860b","unresolved":true,"context_lines":[{"line_number":2666,"context_line":"        # or other data consumer"},{"line_number":2667,"context_line":"        message \u003d {\u0027message_id\u0027: uuidutils.generate_uuid(),"},{"line_number":2668,"context_line":"                   \u0027timestamp\u0027: datetime.datetime.utcnow(),"},{"line_number":2669,"context_line":"                   \u0027hostname\u0027: CONF.host}"},{"line_number":2670,"context_line":""},{"line_number":2671,"context_line":"        try:"},{"line_number":2672,"context_line":"            ev_type \u003d \u0027ironic.metrics\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"667c0032_975adef9","line":2669,"in_reply_to":"b0a2889a_cfe0e3d9","updated":"2023-02-24 16:41:22.000000000","message":"hmm... yes. It would be.","commit_id":"580297da2045122430c1fc2f2a10dba8ca3825e8"}],"ironic/conductor/periodics.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iteration to determine the limit."},{"line_number":89,"context_line":"    :param shared_task: if ``True``, the task will have a shared lock. It is"},{"line_number":90,"context_line":"        recommended to start with a shared lock and upgrade it only if needed."},{"line_number":91,"context_line":"    :param node_count_metric_name: A string value to identify if a metric"},{"line_number":92,"context_line":"        representing the count of matching nodes is to be recorded upon the"},{"line_number":93,"context_line":"        completion of the periodic."},{"line_number":94,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"46137f66_b45fe0c2","line":91,"updated":"2023-02-20 14:06:13.000000000","message":"nit: The \"if\" part sounds like it was a boolean.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iteration to determine the limit."},{"line_number":89,"context_line":"    :param shared_task: if ``True``, the task will have a shared lock. It is"},{"line_number":90,"context_line":"        recommended to start with a shared lock and upgrade it only if needed."},{"line_number":91,"context_line":"    :param node_count_metric_name: A string value to identify if a metric"},{"line_number":92,"context_line":"        representing the count of matching nodes is to be recorded upon the"},{"line_number":93,"context_line":"        completion of the periodic."},{"line_number":94,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"a6d49c20_41cd302a","line":91,"in_reply_to":"46137f66_b45fe0c2","updated":"2023-02-20 16:48:41.000000000","message":"Revised, yeah, that that is a bit confusing. Should be better now.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"}],"ironic/conf/conductor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                       \u0027data which allows operators to gather instance \u0027"},{"line_number":146,"context_line":"                       \u0027counts of actions and states to better manage \u0027"},{"line_number":147,"context_line":"                       \u0027the deployment.\u0027)),"},{"line_number":148,"context_line":"    cfg.BoolOpt(\u0027send_sensor_data_for_nodes\u0027,"},{"line_number":149,"context_line":"                default\u003dTrue,"},{"line_number":150,"context_line":"                help\u003d_(\u0027If to transmit any sensor data for any nodes under \u0027"},{"line_number":151,"context_line":"                       \u0027this conductor\\\u0027s management. This option superceeds \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"40663375_fc94f635","line":148,"updated":"2023-02-20 14:06:13.000000000","message":"These are the 4th and the 5th option with the same prefix. Time for [sensor_data]?","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                       \u0027data which allows operators to gather instance \u0027"},{"line_number":146,"context_line":"                       \u0027counts of actions and states to better manage \u0027"},{"line_number":147,"context_line":"                       \u0027the deployment.\u0027)),"},{"line_number":148,"context_line":"    cfg.BoolOpt(\u0027send_sensor_data_for_nodes\u0027,"},{"line_number":149,"context_line":"                default\u003dTrue,"},{"line_number":150,"context_line":"                help\u003d_(\u0027If to transmit any sensor data for any nodes under \u0027"},{"line_number":151,"context_line":"                       \u0027this conductor\\\u0027s management. This option superceeds \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"14b67407_51f77042","line":148,"in_reply_to":"40663375_fc94f635","updated":"2023-02-20 16:48:41.000000000","message":"Yeah, makes sense. Moving.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"}],"ironic/conf/sensor_data.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b40900b7df8f226ba0fdd008a71594697675a233","unresolved":false,"context_lines":[{"line_number":18,"context_line":"opts \u003d ["},{"line_number":19,"context_line":"    cfg.BoolOpt(\u0027send_sensor_data\u0027,"},{"line_number":20,"context_line":"                default\u003dFalse,"},{"line_number":21,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":22,"context_line":"                help\u003d_(\u0027Enable sending sensor data message via the \u0027"},{"line_number":23,"context_line":"                       \u0027notification bus.\u0027)),"},{"line_number":24,"context_line":"    cfg.IntOpt(\u0027send_sensor_data_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"d2c94733_b4ecb160","line":21,"updated":"2023-02-23 10:00:26.000000000","message":"I agree, this was my intention when I requested the new section.\n\nOn top of what Steve suggested, I\u0027d rename \"send\" to \"enabled\", and then have \"enable_for_conductor\", etc. Probably not types, but data_types.\n\nYeah, we\u0027re officially bikeshedding :)","commit_id":"580297da2045122430c1fc2f2a10dba8ca3825e8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"476c4bb308fcbac4b0b966e3319d50c6442bebcd","unresolved":true,"context_lines":[{"line_number":18,"context_line":"opts \u003d ["},{"line_number":19,"context_line":"    cfg.BoolOpt(\u0027send_sensor_data\u0027,"},{"line_number":20,"context_line":"                default\u003dFalse,"},{"line_number":21,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":22,"context_line":"                help\u003d_(\u0027Enable sending sensor data message via the \u0027"},{"line_number":23,"context_line":"                       \u0027notification bus.\u0027)),"},{"line_number":24,"context_line":"    cfg.IntOpt(\u0027send_sensor_data_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"05cc39dd_feacdbdb","line":21,"updated":"2023-02-23 01:34:08.000000000","message":"These config option names are very long, and all share the send_sensor prefix which is more redundant now there is a [sensor_data] section. There is also a deprecated_name argument, which presumably can be used along with deprecated_group to map to the old long name.\n\nHow about a radical enshortening of these names? Something like:\n- send (this one could remain send_sensor_data)\n- interval\n- workers\n- wait_timeout\n- types\n- for_undeployed_nodes\n- for_conductor\n- for_nodes","commit_id":"580297da2045122430c1fc2f2a10dba8ca3825e8"}],"releasenotes/notes/conductor-metric-collector-support-1b8b8c71f9f59da4.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for Ironic to ship conductor metrics data via the"},{"line_number":5,"context_line":"    message bus notifier utiling ``[metrics]backend`` option when set to"},{"line_number":6,"context_line":"    ``collector``. This data was previously only available through the use"},{"line_number":7,"context_line":"    of statsd. This requires ``ironic-lib`` version ``5.4.0`` or newer."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b74e75ae_4fed6561","line":4,"updated":"2023-02-20 14:06:13.000000000","message":"nit: s/ship/send/ for simpler language?","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for Ironic to ship conductor metrics data via the"},{"line_number":5,"context_line":"    message bus notifier utiling ``[metrics]backend`` option when set to"},{"line_number":6,"context_line":"    ``collector``. This data was previously only available through the use"},{"line_number":7,"context_line":"    of statsd. This requires ``ironic-lib`` version ``5.4.0`` or newer."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f684d005_b057f417","line":4,"in_reply_to":"b74e75ae_4fed6561","updated":"2023-02-20 16:48:41.000000000","message":"done.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for Ironic to ship conductor metrics data via the"},{"line_number":5,"context_line":"    message bus notifier utiling ``[metrics]backend`` option when set to"},{"line_number":6,"context_line":"    ``collector``. This data was previously only available through the use"},{"line_number":7,"context_line":"    of statsd. This requires ``ironic-lib`` version ``5.4.0`` or newer."},{"line_number":8,"context_line":"    This capability can be disabled using the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ac6070c7_9de6f4d1","line":5,"updated":"2023-02-20 14:06:13.000000000","message":"nit: I cannot quite parse this, sorry.. \"when the ``...`` option is set to `collector`\"?","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f687aa54f4ae1570a0a01f3c2c113e7105b85cd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for Ironic to ship conductor metrics data via the"},{"line_number":5,"context_line":"    message bus notifier utiling ``[metrics]backend`` option when set to"},{"line_number":6,"context_line":"    ``collector``. This data was previously only available through the use"},{"line_number":7,"context_line":"    of statsd. This requires ``ironic-lib`` version ``5.4.0`` or newer."},{"line_number":8,"context_line":"    This capability can be disabled using the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d2441951_edd40d7a","line":5,"in_reply_to":"ac6070c7_9de6f4d1","updated":"2023-02-20 16:48:41.000000000","message":"hopefully easier to parse now.","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21165fa85ce1f3e8075f2741796382214fdcf627","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``collector``. This data was previously only available through the use"},{"line_number":7,"context_line":"    of statsd. This requires ``ironic-lib`` version ``5.4.0`` or newer."},{"line_number":8,"context_line":"    This capability can be disabled using the"},{"line_number":9,"context_line":"    ``[conductor]send_sensor_data_for_collector`` option if set to False."},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Adds a ``[conductor]send_sensor_data_for_nodes`` configuration option"},{"line_number":12,"context_line":"    to allow operators to disable shipment of node metric data via the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"413a2755_a7142b44","line":9,"updated":"2023-02-20 14:06:13.000000000","message":"s/collector/conductor/","commit_id":"a01a666a4d3e1652e1e3eb918e596c9539e82d16"}]}