)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7712cffda08a07ff9b8a2014b1f1bc3f626e28d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc838d72_73ac4bbf","updated":"2023-01-23 16:18:55.000000000","message":"Thanks Julia! Am wondering if we should fix the typo in the release notes. (Would someone copy/paste that value?)","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"258cf1056e033800ad829d5a5e1a4d17e565b956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6ca4c071_fd9b7da7","updated":"2023-01-27 18:42:21.000000000","message":"recheck okay, the release notes fix actually finally did merge","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a160b30d26157d50dca12fd4ff67c71af7470ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fc78a12_85636c78","updated":"2023-01-27 16:44:00.000000000","message":"recheck release notes fix fixed","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5f24b60d4242dd95f7a0812171f862346d3b02c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e75fa735_052d8b3e","updated":"2023-01-27 10:08:33.000000000","message":"recheck should be fixed by now","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"}],"ironic/conf/default.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14ad139c4feb3cbba091db898b7b24b4d2e43cdc","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                    \u0027common/isolinux_config.template\u0027),"},{"line_number":217,"context_line":"               help\u003d_(\u0027Template file for isolinux configuration file.\u0027)),"},{"line_number":218,"context_line":"    cfg.StrOpt(\u0027grub_config_path\u0027,"},{"line_number":219,"context_line":"               default\u003d\u0027EFI/BOOT/grub.cfg\u0027,"},{"line_number":220,"context_line":"               help\u003d_(\u0027GRUB2 configuration file location on the UEFI ISO \u0027"},{"line_number":221,"context_line":"                      \u0027images produced by ironic. The default value is \u0027"},{"line_number":222,"context_line":"                      \u0027usually incorrect and should not be relied on. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7df2993_5a313e34","line":219,"updated":"2023-01-07 14:53:03.000000000","message":"No objections, but IIRC it\u0027s not the real path either - see the explanation just below","commit_id":"c233bed5086eb694f1376432c08dd78ded35a4e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94ef13c4d476e8eab085621ac108c396de6a734f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                    \u0027common/isolinux_config.template\u0027),"},{"line_number":217,"context_line":"               help\u003d_(\u0027Template file for isolinux configuration file.\u0027)),"},{"line_number":218,"context_line":"    cfg.StrOpt(\u0027grub_config_path\u0027,"},{"line_number":219,"context_line":"               default\u003d\u0027EFI/BOOT/grub.cfg\u0027,"},{"line_number":220,"context_line":"               help\u003d_(\u0027GRUB2 configuration file location on the UEFI ISO \u0027"},{"line_number":221,"context_line":"                      \u0027images produced by ironic. The default value is \u0027"},{"line_number":222,"context_line":"                      \u0027usually incorrect and should not be relied on. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b815816_f8ecd5dd","line":219,"in_reply_to":"b7df2993_5a313e34","updated":"2023-01-10 14:34:41.000000000","message":"... Yeah, this fixes a bug I encountered...  It is the target location of where to write the file inside the target virtual media.\n\nI  mean, I could add \"may need\" to the note about distribution specific values.","commit_id":"c233bed5086eb694f1376432c08dd78ded35a4e3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7712cffda08a07ff9b8a2014b1f1bc3f626e28d7","unresolved":true,"context_lines":[{"line_number":219,"context_line":"               default\u003d\u0027EFI/BOOT/grub.cfg\u0027,"},{"line_number":220,"context_line":"               help\u003d_(\u0027GRUB2 configuration file location on the UEFI ISO \u0027"},{"line_number":221,"context_line":"                      \u0027images produced by ironic. The default value is \u0027"},{"line_number":222,"context_line":"                      \u0027usually incorrect and should not be relied on. \u0027"},{"line_number":223,"context_line":"                      \u0027If you use a GRUB2 image from a certain distribution, \u0027"},{"line_number":224,"context_line":"                      \u0027use a distribution-specific path here, e.g. \u0027"},{"line_number":225,"context_line":"                      \u0027EFI/ubuntu/grub.cfg\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"4079e33a_7ea5d4df","line":222,"updated":"2023-01-23 16:18:55.000000000","message":"makes me wonder if we shouldn\u0027t even put a default value, to force the operator to figure out what it should be... (just wondering, not suggesting that we should change.)","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"}],"releasenotes/notes/fix-grub2-uefi-config-path-f1b4c5083cc97ee5.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c0edfd0ddee8db2fdbb5dd0284653740d2c3228d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the default value for the ``[DEFAULT]\\grub_config_path`` variable to"},{"line_number":5,"context_line":"    be the default path for UEFI bootloader configurations, where as the"},{"line_number":6,"context_line":"    default was previously the BIOS grub2 configuration path."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b9160114_72052388","line":4,"updated":"2023-01-10 23:24:32.000000000","message":"When we change a config default; shouldn\u0027t we have something in \"upgrade\" section here, since an operator may be expecting different behavior?","commit_id":"c233bed5086eb694f1376432c08dd78ded35a4e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4810befb0bdb17ccb1d8e60acea27d2e3eb98027","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the default value for the ``[DEFAULT]\\grub_config_path`` variable to"},{"line_number":5,"context_line":"    be the default path for UEFI bootloader configurations, where as the"},{"line_number":6,"context_line":"    default was previously the BIOS grub2 configuration path."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"20538c1a_29b3cf70","line":4,"in_reply_to":"b9160114_72052388","updated":"2023-01-11 14:55:32.000000000","message":"I kind of skipped past it since every example I came across, someone was overriding it, but good point, will revise.","commit_id":"c233bed5086eb694f1376432c08dd78ded35a4e3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7712cffda08a07ff9b8a2014b1f1bc3f626e28d7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the default value for the ``[DEFAULT]grub_config_path`` variable to"},{"line_number":5,"context_line":"    be the default path for UEFI bootloader configurations, where as the"},{"line_number":6,"context_line":"    default was previously the BIOS grub2 configuration path."},{"line_number":7,"context_line":"upgrades:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dedadd3b_e97ae22c","line":5,"updated":"2023-01-23 16:18:55.000000000","message":"i wonder if we should mention what that new value is. (In case someone wants more details.)","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7712cffda08a07ff9b8a2014b1f1bc3f626e28d7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"upgrades:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The default configuration value for ``[DEFAULT]grub_config_path`` has"},{"line_number":10,"context_line":"    been changed from ``/boot/grub/grub.conf`` to ``EFI/BOOT/grub.efi`` as"},{"line_number":11,"context_line":"    the configuration parameter was for UEFI boot configuration, and the"},{"line_number":12,"context_line":"    ``/boot/grub/grub2.conf`` path is for BIOS booting. This was verified"},{"line_number":13,"context_line":"    by referencing several working UEFI virtual media examples where this"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f38155cc_b4ea033a","line":10,"updated":"2023-01-23 16:18:55.000000000","message":"it was \"/boot/grub/grub.cfg\"","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7712cffda08a07ff9b8a2014b1f1bc3f626e28d7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    The default configuration value for ``[DEFAULT]grub_config_path`` has"},{"line_number":10,"context_line":"    been changed from ``/boot/grub/grub.conf`` to ``EFI/BOOT/grub.efi`` as"},{"line_number":11,"context_line":"    the configuration parameter was for UEFI boot configuration, and the"},{"line_number":12,"context_line":"    ``/boot/grub/grub2.conf`` path is for BIOS booting. This was verified"},{"line_number":13,"context_line":"    by referencing several working UEFI virtual media examples where this"},{"line_number":14,"context_line":"    value was overridden to the new configuration value."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"541a4e73_119a1069","line":12,"updated":"2023-01-23 16:18:55.000000000","message":"it was \"/boot/grub/grub.cfg\"","commit_id":"2f4a156d2995387f944942bd769d17eca623d36a"}]}