)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5cdb3ee15569c0823033534f71d48e5ac32583b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84bb32f9_a3c838dd","updated":"2023-03-16 22:49:23.000000000","message":"Question about the redfish docs: did the old location ever work or did it change across CentOS releases? It\u0027s unclear to me, and if it changed across releases we should probably include both.","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"}],"doc/source/admin/drivers/redfish.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14a6f21945b5638461a837197788e518a6fd336a","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":".. note::"},{"line_number":333,"context_line":"   The grub path configuration variable can be overriden on a node"},{"line_number":334,"context_line":"   level using the ``driver_info\\grub_esp_config_path`` option."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. _redfish-virtual-media-ramdisk:"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6a81072a_f1437726","line":334,"updated":"2023-02-20 14:12:05.000000000","message":"I don\u0027t think we\u0027ve ever used a backslash for this?","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fe222a636acd0e751da15f4439f5ad564d42d8d1","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":".. note::"},{"line_number":333,"context_line":"   The grub path configuration variable can be overriden on a node"},{"line_number":334,"context_line":"   level using the ``driver_info\\grub_esp_config_path`` option."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. _redfish-virtual-media-ramdisk:"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d48b57b2_d2cfabe6","line":334,"in_reply_to":"6a81072a_f1437726","updated":"2023-03-13 19:18:27.000000000","message":"doh! Fixed","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5cdb3ee15569c0823033534f71d48e5ac32583b2","unresolved":true,"context_lines":[{"line_number":312,"context_line":"image. In most cases this path will depend on your distribution, more"},{"line_number":313,"context_line":"precisely, the distribution you took the GRUB2 image from. For example:"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"CentOS:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":".. code-block:: ini"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"12b9ab26_65f5660b","line":315,"updated":"2023-03-16 22:49:23.000000000","message":"Might be nice to version this, especially since you\u0027re changing something? Did we change something that, e.g. worked in Stream 8 to something that only works in Stream 9?\n\nJust right now, I\u0027d be afraid of doc-rot reading this as an operator (even though obviously in this context it\u0027s up to date).","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2dac72e4d7eb6432efce1c864768164a506f9904","unresolved":true,"context_lines":[{"line_number":312,"context_line":"image. In most cases this path will depend on your distribution, more"},{"line_number":313,"context_line":"precisely, the distribution you took the GRUB2 image from. For example:"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"CentOS:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":".. code-block:: ini"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"65faabad_1291b9f6","line":315,"in_reply_to":"12b9ab26_65f5660b","updated":"2024-01-03 23:09:28.000000000","message":"It was *always* wrong. Unfortunately. It was a failure to understand bios boot mode and behavior versus UEFI boot mode behavior which is distinctly different.","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4c71bb69f44f0a65b445566a2ec19752459cff35","unresolved":true,"context_lines":[{"line_number":312,"context_line":"image. In most cases this path will depend on your distribution, more"},{"line_number":313,"context_line":"precisely, the distribution you took the GRUB2 image from. For example:"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"CentOS:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":".. code-block:: ini"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"238aa68d_cdf279df","line":315,"in_reply_to":"65faabad_1291b9f6","updated":"2024-01-03 23:24:16.000000000","message":"Ugh, it also depends on what your doing. On fedora, it is no the EFI subfolder, but the distribution folder, so I\u0027m dropping the next change in docs.","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"}],"ironic/common/images.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cf0e64cb271b828f9dfc0e192a424a42b53d0058","unresolved":true,"context_lines":[{"line_number":305,"context_line":"                    grub_rel_path \u003d CONF.grub_config_path.lstrip(\u0027 \u0027 + os.sep)"},{"line_number":306,"context_line":"                else:"},{"line_number":307,"context_line":"                    grub_rel_path \u003d str(esp_boot_config_path).lstrip("},{"line_number":308,"context_line":"                        \u0027 \u0027 + os.sep)"},{"line_number":309,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"                # Create an empty grub config file by copying /dev/null."}],"source_content_type":"text/x-python","patch_set":3,"id":"c2d69b83_8048a73e","line":308,"updated":"2023-03-20 01:37:01.000000000","message":"There is a risk this could be used to exfiltrate arbitrary files off conductor nodes. It might be necessary to create a new configuration option which points to a directory, and validating that the requested file is inside that directory","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2dac72e4d7eb6432efce1c864768164a506f9904","unresolved":true,"context_lines":[{"line_number":305,"context_line":"                    grub_rel_path \u003d CONF.grub_config_path.lstrip(\u0027 \u0027 + os.sep)"},{"line_number":306,"context_line":"                else:"},{"line_number":307,"context_line":"                    grub_rel_path \u003d str(esp_boot_config_path).lstrip("},{"line_number":308,"context_line":"                        \u0027 \u0027 + os.sep)"},{"line_number":309,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"                # Create an empty grub config file by copying /dev/null."}],"source_content_type":"text/x-python","patch_set":3,"id":"c93fd26b_34e350c3","line":308,"in_reply_to":"c2d69b83_8048a73e","updated":"2024-01-03 23:09:28.000000000","message":"This is a very good point. I think at this point, since there is no explicit call for the need, might as well just abandon this.","commit_id":"f5dcfee3bc137a0b9a9f87ea301c5ae24526d16d"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14a6f21945b5638461a837197788e518a6fd336a","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                        (\u0027%s\u003d%s\u0027 % kv) if kv[1] is not None else kv[0]"},{"line_number":514,"context_line":"                        for kv in params.items())))"},{"line_number":515,"context_line":"            esp_boot_config_path \u003d task.node.driver_info.get("},{"line_number":516,"context_line":"                \u0027grub_esp_config_path\u0027, None)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            LOG.debug("},{"line_number":519,"context_line":"                \"Trying to create %(boot_mode)s ISO image for node %(node)s \""}],"source_content_type":"text/x-python","patch_set":2,"id":"4df31ddb_791dcdcd","line":516,"updated":"2023-02-20 14:12:05.000000000","message":"nit: the 2nd parameter is redundant","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fe222a636acd0e751da15f4439f5ad564d42d8d1","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                        (\u0027%s\u003d%s\u0027 % kv) if kv[1] is not None else kv[0]"},{"line_number":514,"context_line":"                        for kv in params.items())))"},{"line_number":515,"context_line":"            esp_boot_config_path \u003d task.node.driver_info.get("},{"line_number":516,"context_line":"                \u0027grub_esp_config_path\u0027, None)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            LOG.debug("},{"line_number":519,"context_line":"                \"Trying to create %(boot_mode)s ISO image for node %(node)s \""}],"source_content_type":"text/x-python","patch_set":2,"id":"92ade730_2b2eb270","line":516,"in_reply_to":"4df31ddb_791dcdcd","updated":"2023-03-13 19:18:27.000000000","message":"Done","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"}],"releasenotes/notes/add-esp-boot-path-option-to-driver-info-712412f7f1a48305.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14a6f21945b5638461a837197788e518a6fd336a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provides a path forward in mixed OS environments where different conductor"},{"line_number":5,"context_line":"    ``[DEFAULT]\\grub_config_path`` parameters by adding a"},{"line_number":6,"context_line":"    ``driver_info\\grub_esp_config_path`` parameter to node objects which can"},{"line_number":7,"context_line":"    allow operators to override the default on a per-node level."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"908137ba_a91ea9f8","line":5,"updated":"2023-02-20 14:12:05.000000000","message":"same re backslash (I really read \\g as an unknown to me escape sequence every time :)","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14a6f21945b5638461a837197788e518a6fd336a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Provides a path forward in mixed OS environments where different conductor"},{"line_number":5,"context_line":"    ``[DEFAULT]\\grub_config_path`` parameters by adding a"},{"line_number":6,"context_line":"    ``driver_info\\grub_esp_config_path`` parameter to node objects which can"},{"line_number":7,"context_line":"    allow operators to override the default on a per-node level."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"214ab275_99cdcabb","line":6,"updated":"2023-02-20 14:12:05.000000000","message":"same","commit_id":"03dce2f1d16397d15b805e156aa713e8aa0a6c4a"}]}