)]}'
{"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94a1939c4a48dae86d7b82e89f2ac054119e9c8d","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        validate_mock \u003d self._patch_object(self.driver.power, \u0027validate\u0027)"},{"line_number":152,"context_line":"        save_mock \u003d self._patch_object(node, \u0027save\u0027)"},{"line_number":153,"context_line":"        npa_mock \u003d self._patch_object(conductor_utils, \u0027node_power_action\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if fail_validate:"},{"line_number":156,"context_line":"            validate_mock.side_effect \u003d exception.InvalidParameterValue("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Fe20%3D","line":153,"updated":"2014-04-14 10:27:51.000000000","message":"Please don\u0027t convert things back to addCleanup(), decorator and context managers are preferred ways of using mocks.","commit_id":"c86492b449cd44ddfbe74b5edc35acaf068f4d23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94a1939c4a48dae86d7b82e89f2ac054119e9c8d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                exp_calls \u003d [mock.call(task, node)"},{"line_number":170,"context_line":"                    for x in range(len(new_power_states))]"},{"line_number":171,"context_line":"                self.assertEqual(exp_calls, get_power_mock.call_args_list)"},{"line_number":172,"context_line":"        return task, validate_mock, save_mock, npa_mock"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test__do_sync_power_state_state_unchanged(self):"},{"line_number":175,"context_line":"        (task, validate_mock, save_mock,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Fe1c%3D","line":172,"updated":"2014-04-14 10:27:51.000000000","message":"My overall suggestion to this patch is to make this tests a separate test case. This is because to me this helper actually contains setUp for some test case (i.e. testing power states). To avoid returning a lot of values you can set mocks as attributes on `self` then.","commit_id":"c86492b449cd44ddfbe74b5edc35acaf068f4d23"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a544ab3a06b3617339771fd9f41f344f951e8c2","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        self.assertFalse(self.power.validate.called)"},{"line_number":1206,"context_line":"        self.power.get_power_state.assert_called_once_with(self.task,"},{"line_number":1207,"context_line":"                                                           self.node)"},{"line_number":1208,"context_line":"        self.assertEqual(self.node.power_state, \u0027fake-power\u0027)"},{"line_number":1209,"context_line":"        self.assertFalse(self.node.save.called)"},{"line_number":1210,"context_line":"        self.assertFalse(node_power_action.called)"},{"line_number":1211,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2F8WU%3D","line":1208,"updated":"2014-04-16 11:09:18.000000000","message":"Time to time we have patches fixing the assertion order[1], mind fixing the order for the methods you moved/added here?\n\nself.assertEqual(\u003cexpected\u003e, \u003cobserver\u003e)\n\n[1] https://review.openstack.org/#/c/87035/","commit_id":"c1ca8e3866f5838be4a6350732ddc0b76849f7d7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a544ab3a06b3617339771fd9f41f344f951e8c2","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"        self.assertFalse(self.node.save.called)"},{"line_number":1280,"context_line":"        node_power_action.assert_called_once_with(self.task, self.node,"},{"line_number":1281,"context_line":"                                                  states.POWER_ON)"},{"line_number":1282,"context_line":"        self.assertEqual(self.node.power_state, states.POWER_ON)"},{"line_number":1283,"context_line":"        self.assertEqual(1,"},{"line_number":1284,"context_line":"                         self.service.power_state_sync_count[self.node.uuid])"},{"line_number":1285,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2F8Ww%3D","line":1282,"updated":"2014-04-16 11:09:18.000000000","message":"ditto","commit_id":"c1ca8e3866f5838be4a6350732ddc0b76849f7d7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a544ab3a06b3617339771fd9f41f344f951e8c2","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        self.node.save.assert_called_once_with(self.context)"},{"line_number":1298,"context_line":"        node_power_action.assert_called_once_with(self.task, self.node,"},{"line_number":1299,"context_line":"                                                  states.POWER_ON)"},{"line_number":1300,"context_line":"        self.assertEqual(self.node.power_state, states.POWER_OFF)"},{"line_number":1301,"context_line":"        self.assertEqual(1,"},{"line_number":1302,"context_line":"                         self.service.power_state_sync_count[self.node.uuid])"},{"line_number":1303,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2F8W0%3D","line":1300,"updated":"2014-04-16 11:09:18.000000000","message":"ditto","commit_id":"c1ca8e3866f5838be4a6350732ddc0b76849f7d7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a544ab3a06b3617339771fd9f41f344f951e8c2","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"        npa_exp_calls \u003d [mock.call(self.task, self.node,"},{"line_number":1318,"context_line":"                                   states.POWER_ON)] * 2"},{"line_number":1319,"context_line":"        self.assertEqual(npa_exp_calls, node_power_action.call_args_list)"},{"line_number":1320,"context_line":"        self.assertEqual(self.node.power_state, states.POWER_OFF)"},{"line_number":1321,"context_line":"        self.assertEqual(2,"},{"line_number":1322,"context_line":"                         self.service.power_state_sync_count[self.node.uuid])"},{"line_number":1323,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2F8UU%3D","line":1320,"updated":"2014-04-16 11:09:18.000000000","message":"ditto","commit_id":"c1ca8e3866f5838be4a6350732ddc0b76849f7d7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a544ab3a06b3617339771fd9f41f344f951e8c2","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"        npa_exp_calls \u003d [mock.call(self.task, self.node,"},{"line_number":1338,"context_line":"                                   states.POWER_ON)] * 2"},{"line_number":1339,"context_line":"        self.assertEqual(npa_exp_calls, node_power_action.call_args_list)"},{"line_number":1340,"context_line":"        self.assertEqual(self.node.power_state, states.POWER_ON)"},{"line_number":1341,"context_line":"        self.assertNotIn(self.node.uuid, self.service.power_state_sync_count)"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2F8W4%3D","line":1340,"updated":"2014-04-16 11:09:18.000000000","message":"ditto","commit_id":"c1ca8e3866f5838be4a6350732ddc0b76849f7d7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e1d09fb6bdc7b2ef167e49360d049ee0459dc3b9","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"        # 2nd node: Not mapped to this conductor"},{"line_number":1512,"context_line":"        # 3rd node: In DEPLOYWAIT provision_state"},{"line_number":1513,"context_line":"        # 4th node: Disappears after getting nodeinfo list."},{"line_number":1514,"context_line":"        # 5th node: task_manger.acquire() fails due to lock"},{"line_number":1515,"context_line":"        # 6th node: Should acquire and try to sync"},{"line_number":1516,"context_line":"        nodes \u003d []"},{"line_number":1517,"context_line":"        get_node_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F3MM%3D","line":1514,"updated":"2014-04-16 21:12:20.000000000","message":"typo: task_manager. (Only consider fixing if you need to do another patch.)","commit_id":"a010d540da3f30ecb5d542ae12088b8b154c5cd2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"a98c4ab331e89839a68cdff76b596eb0857470b7","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"        # 2nd node: Not mapped to this conductor"},{"line_number":1512,"context_line":"        # 3rd node: In DEPLOYWAIT provision_state"},{"line_number":1513,"context_line":"        # 4th node: Disappears after getting nodeinfo list."},{"line_number":1514,"context_line":"        # 5th node: task_manger.acquire() fails due to lock"},{"line_number":1515,"context_line":"        # 6th node: Should acquire and try to sync"},{"line_number":1516,"context_line":"        nodes \u003d []"},{"line_number":1517,"context_line":"        get_node_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F0s4%3D","line":1514,"in_reply_to":"AAAAXH%2F%2F3MM%3D","updated":"2014-04-17 06:44:45.000000000","message":"ah, nice catch.  yeah, i\u0027ll fix it if I have to spin another patch set... otherwise I\u0027ll hit it in a follow up.","commit_id":"a010d540da3f30ecb5d542ae12088b8b154c5cd2"}]}
