)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"22eb29ef39ef50ddaa53770b0446694a637dc21b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6fcfd9a_edfbd761","updated":"2023-02-20 13:45:53.000000000","message":"Are we sure these SIGALRM/SIGKILL things are happening *by default*? Restarting the conductor is a common way to handle nodes stuck in DEPLOYING etc.","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54b5a8895d729b5acf989e05e4878250b034338b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1944478_69e9f110","updated":"2023-02-15 17:07:13.000000000","message":"Please add a release note.","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"be357422294cb80fb92b91c3333af462679c1afc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0bfe0f3_1fecad13","in_reply_to":"c6fcfd9a_edfbd761","updated":"2023-02-22 02:00:40.000000000","message":"I just replaced the while expression with while True:, then I manually did a kill -TERM to see what would happen. I expected a SIGALRM to result in the process exiting but that never happened.\n\nI trust systemd/kubernetes to do a SIGKILL, but I\u0027ll also add time checks to stop looping after graceful_shutdown_timeout.","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"985e73006bcef4ad6800f35fc1f4cc3f3bc67a1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ee82e61_1f7afcca","in_reply_to":"d0bfe0f3_1fecad13","updated":"2023-02-22 02:35:07.000000000","message":"Done","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"985e73006bcef4ad6800f35fc1f4cc3f3bc67a1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c15de07_b163af31","in_reply_to":"f1944478_69e9f110","updated":"2023-02-22 02:35:07.000000000","message":"Done","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dc98e2808338db74c31e1f72bc8feb4d7649a047","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9d6d51e2_bc78e064","updated":"2023-02-23 00:57:48.000000000","message":"recheck grenade is working now due to cirros revert","commit_id":"0c141e8f3a8f239b0b40aba7b2a8091dc05b8c63"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"02cbb33fd926c9a7442ada99376c2d4dd51bd483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"228a19c8_92be069d","updated":"2023-03-14 17:42:37.000000000","message":"I think we need this to go back to 2023.1?","commit_id":"6a9e319fbeb0851c51bb14b9c4c3c5fa4685b14d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d65aacc0195082592fb6d6e010ba0c5701d1af54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87736a69_cf8820f1","updated":"2023-02-27 20:09:06.000000000","message":"recheck ci is green","commit_id":"6a9e319fbeb0851c51bb14b9c4c3c5fa4685b14d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0965aae0657dae4b77b68fa2ac00276197462e15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"787760a6_75f629ab","updated":"2023-03-14 01:04:02.000000000","message":"recheck metalsmith legacy job","commit_id":"6a9e319fbeb0851c51bb14b9c4c3c5fa4685b14d"}],"ironic/tests/unit/common/test_rpc_service.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54b5a8895d729b5acf989e05e4878250b034338b","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        dbapi \u003d mock.Mock()"},{"line_number":172,"context_line":"        # 3 calls to manager has_reserved until all reservation locks"},{"line_number":173,"context_line":"        # are released"},{"line_number":174,"context_line":"        dbapi.get_nodeinfo_list.side_effect \u003d [[\u0027a\u0027, \u0027b\u0027], [\u0027a\u0027], []]"},{"line_number":175,"context_line":"        self.rpc_svc.manager.dbapi \u003d dbapi"},{"line_number":176,"context_line":"        self.rpc_svc.stop()"},{"line_number":177,"context_line":"        # wait the remaining 10 seconds, then wait until has_reserved"}],"source_content_type":"text/x-python","patch_set":2,"id":"09a3f7ee_1e17c377","line":174,"updated":"2023-02-15 17:07:13.000000000","message":"Perfect, thanks!","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"985e73006bcef4ad6800f35fc1f4cc3f3bc67a1b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        dbapi \u003d mock.Mock()"},{"line_number":172,"context_line":"        # 3 calls to manager has_reserved until all reservation locks"},{"line_number":173,"context_line":"        # are released"},{"line_number":174,"context_line":"        dbapi.get_nodeinfo_list.side_effect \u003d [[\u0027a\u0027, \u0027b\u0027], [\u0027a\u0027], []]"},{"line_number":175,"context_line":"        self.rpc_svc.manager.dbapi \u003d dbapi"},{"line_number":176,"context_line":"        self.rpc_svc.stop()"},{"line_number":177,"context_line":"        # wait the remaining 10 seconds, then wait until has_reserved"}],"source_content_type":"text/x-python","patch_set":2,"id":"080cd8d7_8fd61fb6","line":174,"in_reply_to":"09a3f7ee_1e17c377","updated":"2023-02-22 02:35:07.000000000","message":"Done","commit_id":"f44189aac985f4a2b3923a5d61fa3f49e36c582d"}]}