)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"95445d9d7aab238a772d33f9c1dfa553a775704e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_ephemeral_format\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027ext4\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Default file system format for ephemeral partition, \u0027"},{"line_number":57,"context_line":"                    \u0027if one is created.\u0027),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027IP address of Ironic compute node\\\u0027s tftp server.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FX2Y%3D","line":57,"updated":"2014-04-15 03:34:48.000000000","message":"I\u0027m sure I saw this previously - this shouldn\u0027t be in Ironic - its already defined in nova - the nova API should just request the specific format desired.","commit_id":"d07d855717d6e001358acc6c0c08e5a66b2d0473"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ceb00ac02729c35024b6d41c137bc713c74e8341","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_ephemeral_format\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027ext4\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Default file system format for ephemeral partition, \u0027"},{"line_number":57,"context_line":"                    \u0027if one is created.\u0027),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027IP address of Ironic compute node\\\u0027s tftp server.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FXkI%3D","line":57,"in_reply_to":"AAAAW3%2F%2FX2Y%3D","updated":"2014-04-15 05:24:52.000000000","message":"This patch adds a hook in ironic_driver_fields:\n\n   patch.append({\u0027path\u0027: \u0027/driver_info/pxe_default_format\u0027,\n106\t                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: CONF.default_ephemeral_format})\n\nEven so, I felt that it would be less useful to error out, should something cause Nova to not send that value at all, than to have a sane default in Ironic.\n\nIf you really object to that, I can remove this option.","commit_id":"d07d855717d6e001358acc6c0c08e5a66b2d0473"}],"ironic/nova/virt/ironic/patcher.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"1571440237a393625cdd1a36ffd50ec8979cb600","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_gb\u0027,"},{"line_number":101,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: str(instance[\u0027ephemeral_gb\u0027])})"},{"line_number":102,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_format\u0027,"},{"line_number":103,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: CONF.default_ephemeral_format})"},{"line_number":104,"context_line":"        return patch"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_cleanup_patch(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXH%2F%2FoD4%3D","line":103,"updated":"2014-04-18 18:03:29.000000000","message":"This should be: CONF.pxe.default_ephemeral_format","commit_id":"9dbf3db8b359276f2582a6c5ca83e8e87ae38473"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"df5485a5992358e09ca87b5b668a12ce091db78a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_gb\u0027,"},{"line_number":101,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: str(instance[\u0027ephemeral_gb\u0027])})"},{"line_number":102,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_format\u0027,"},{"line_number":103,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: CONF.default_ephemeral_format})"},{"line_number":104,"context_line":"        return patch"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_cleanup_patch(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXH%2F%2Fmts%3D","line":103,"in_reply_to":"AAAAXH%2F%2Fm5I%3D","updated":"2014-04-18 21:36:50.000000000","message":"Ah, so there is a problem here.\n\nIf the CONF option is not set, this is creating a bad patch of the format {\u0027op\u0027: \u0027add\u0027, \u0027value\u0027: None}\n\nFixing...","commit_id":"9dbf3db8b359276f2582a6c5ca83e8e87ae38473"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"27a4ee82bbba6624ecb5a56f1cd56b9c87142538","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_gb\u0027,"},{"line_number":101,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: str(instance[\u0027ephemeral_gb\u0027])})"},{"line_number":102,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_format\u0027,"},{"line_number":103,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: CONF.default_ephemeral_format})"},{"line_number":104,"context_line":"        return patch"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_cleanup_patch(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXH%2F%2Fm5I%3D","line":103,"in_reply_to":"AAAAXH%2F%2FoD4%3D","updated":"2014-04-18 20:57:43.000000000","message":"Nope. This is correct. See\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/driver.py#n39","commit_id":"9dbf3db8b359276f2582a6c5ca83e8e87ae38473"}]}