)]}'
{"ironic/drivers/modules/inspect_utils.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"22d2f938e3e62abceb9a386eb9fef3b03b83e260","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from ironic.objects import node_inventory"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"_OBJECT_NAME_PREFIX \u003d \u0027inspector_data\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def create_ports_if_not_exist(task, macs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"247dbfe1_92e4e642","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":37},"updated":"2023-03-14 15:53:42.000000000","message":"should we change this to \"inspection_data\u0027 as well?","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"445db6f3cd9d5bfc0f0e0bc82222850f7078e72a","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from ironic.objects import node_inventory"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"_OBJECT_NAME_PREFIX \u003d \u0027inspector_data\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def create_ports_if_not_exist(task, macs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac548511_5b7a6f85","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":37},"in_reply_to":"247dbfe1_92e4e642","updated":"2023-03-14 17:14:55.000000000","message":"This is, unfortunately, a compatibility break.","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"379b5aa7912a71062319b32daf50fa2e93ea1858","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from ironic.objects import node_inventory"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"_OBJECT_NAME_PREFIX \u003d \u0027inspector_data\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def create_ports_if_not_exist(task, macs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbd73c11_cff5b327","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":37},"in_reply_to":"ac548511_5b7a6f85","updated":"2023-03-14 21:25:58.000000000","message":"Ack","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"}],"ironic/drivers/modules/inspector/interface.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"22d2f938e3e62abceb9a386eb9fef3b03b83e260","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        _clean_up(task)"},{"line_number":302,"context_line":"        store_data \u003d CONF.inventory.data_backend"},{"line_number":303,"context_line":"        if store_data \u003d\u003d \u0027none\u0027:"},{"line_number":304,"context_line":"            LOG.debug(\u0027Introspection data storage is disabled, the data will \u0027"},{"line_number":305,"context_line":"                      \u0027not be saved for node %(node)s\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":306,"context_line":"            return"},{"line_number":307,"context_line":"        introspection_data \u003d inspector_client.get_introspection_data("}],"source_content_type":"text/x-python","patch_set":1,"id":"1cb56507_7417b399","line":304,"range":{"start_line":304,"start_character":23,"end_line":304,"end_character":36},"updated":"2023-03-14 15:53:42.000000000","message":"rename?","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"445db6f3cd9d5bfc0f0e0bc82222850f7078e72a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        _clean_up(task)"},{"line_number":302,"context_line":"        store_data \u003d CONF.inventory.data_backend"},{"line_number":303,"context_line":"        if store_data \u003d\u003d \u0027none\u0027:"},{"line_number":304,"context_line":"            LOG.debug(\u0027Introspection data storage is disabled, the data will \u0027"},{"line_number":305,"context_line":"                      \u0027not be saved for node %(node)s\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":306,"context_line":"            return"},{"line_number":307,"context_line":"        introspection_data \u003d inspector_client.get_introspection_data("}],"source_content_type":"text/x-python","patch_set":1,"id":"d64fc6d1_a8daa7b2","line":304,"range":{"start_line":304,"start_character":23,"end_line":304,"end_character":36},"in_reply_to":"1cb56507_7417b399","updated":"2023-03-14 17:14:55.000000000","message":"Done","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"22d2f938e3e62abceb9a386eb9fef3b03b83e260","unresolved":true,"context_lines":[{"line_number":304,"context_line":"            LOG.debug(\u0027Introspection data storage is disabled, the data will \u0027"},{"line_number":305,"context_line":"                      \u0027not be saved for node %(node)s\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":306,"context_line":"            return"},{"line_number":307,"context_line":"        introspection_data \u003d inspector_client.get_introspection_data("},{"line_number":308,"context_line":"            node.uuid, processed\u003dTrue)"},{"line_number":309,"context_line":"        # TODO(dtantsur): having no inventory is an abnormal state, handle it."},{"line_number":310,"context_line":"        inventory \u003d introspection_data.pop(\u0027inventory\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"53f9ae06_7ae18330","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":26},"updated":"2023-03-14 15:53:42.000000000","message":"should we rename the var?","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"445db6f3cd9d5bfc0f0e0bc82222850f7078e72a","unresolved":true,"context_lines":[{"line_number":304,"context_line":"            LOG.debug(\u0027Introspection data storage is disabled, the data will \u0027"},{"line_number":305,"context_line":"                      \u0027not be saved for node %(node)s\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":306,"context_line":"            return"},{"line_number":307,"context_line":"        introspection_data \u003d inspector_client.get_introspection_data("},{"line_number":308,"context_line":"            node.uuid, processed\u003dTrue)"},{"line_number":309,"context_line":"        # TODO(dtantsur): having no inventory is an abnormal state, handle it."},{"line_number":310,"context_line":"        inventory \u003d introspection_data.pop(\u0027inventory\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcb67df3_a627f210","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":26},"in_reply_to":"53f9ae06_7ae18330","updated":"2023-03-14 17:14:55.000000000","message":"Well, this is coming from inspector, so the old name is appropriate, I think.","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"379b5aa7912a71062319b32daf50fa2e93ea1858","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            LOG.debug(\u0027Introspection data storage is disabled, the data will \u0027"},{"line_number":305,"context_line":"                      \u0027not be saved for node %(node)s\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":306,"context_line":"            return"},{"line_number":307,"context_line":"        introspection_data \u003d inspector_client.get_introspection_data("},{"line_number":308,"context_line":"            node.uuid, processed\u003dTrue)"},{"line_number":309,"context_line":"        # TODO(dtantsur): having no inventory is an abnormal state, handle it."},{"line_number":310,"context_line":"        inventory \u003d introspection_data.pop(\u0027inventory\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"369cc98b_6df05516","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":26},"in_reply_to":"dcb67df3_a627f210","updated":"2023-03-14 21:25:58.000000000","message":"Ack","commit_id":"525883fbe7a153487a84430f7ac48da5b2ff623e"}]}