)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4da8a88e6b81cabc5dcac573442d6243e0dad004","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to keep backward compatibility with how inspection worked before managed"},{"line_number":13,"context_line":"boot was introduced."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With in-band inspection migrating to Ironic proper, this \"unmanaged\""},{"line_number":16,"context_line":"mode becomes a more exotic case since it requires additional PXE"},{"line_number":17,"context_line":"infrastructure. Additionally, the popularity of Redfish is rapidly"},{"line_number":18,"context_line":"growing, and we support pre-populating ports when Redfish is used."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"88ff31d7_6de681d0","line":16,"range":{"start_line":15,"start_character":51,"end_line":16,"end_character":4},"updated":"2023-03-16 16:37:16.000000000","message":"Just dropping a thought here, I\u0027ve been pondering a bit on the pxe_filter/unmanged/discovery.\n\nWe have a \"dnsmasq\" dhcp driver in ironic now. In neutron serving \"wildcard\"/\"any client\" is not possible. But with the dnsmasq driver we can have a \"wildcard/unknown_hosts\" hosts file which we flip between:\n\n *:*:*:*:*:*,ignore         \u003c- default state when discover is disabled.\n *:*:*:*:*:*,set:inspection \u003c- default state when discovery is enabled.\n\nWe can then have an opts file using pattern `tag:inspection,%INSPECTION_OPTS%`\n\nIf we could support loading multiple DHCP drivers, an ordered list i.e `neutron,dnsmasq`. When no port exist, pick the first driver that returns true to a `supports_wildcard_host()` check, i.e dnsmasq driver.\n\nI think also when port exist and all driver\u0027s skipped or not used because of \"lower priority\" is used, all following drivers (at least the dnsmasq driver) would have to get a `clean_dhcp_opts()` call to ensure it ignores (does not serve requests) from the nodes mac addresses.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd48dcbb2726351b0e53c28c6e9b6d129cdfeb49","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to keep backward compatibility with how inspection worked before managed"},{"line_number":13,"context_line":"boot was introduced."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With in-band inspection migrating to Ironic proper, this \"unmanaged\""},{"line_number":16,"context_line":"mode becomes a more exotic case since it requires additional PXE"},{"line_number":17,"context_line":"infrastructure. Additionally, the popularity of Redfish is rapidly"},{"line_number":18,"context_line":"growing, and we support pre-populating ports when Redfish is used."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5407db23_19e0b2b0","line":16,"range":{"start_line":15,"start_character":51,"end_line":16,"end_character":4},"in_reply_to":"6e4442e1_0a0403fe","updated":"2023-03-17 09:49:40.000000000","message":"I also really like the idea, but I also think we should do this change to avoid implicit behavior that may or may not work depending on your setup. What you describe is also quite a lot of work, I doubt I can pick it up in the near future (especially since metal3 does not use a DHCP driver).","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f0bbc20ada6e64c0878eb3b515bdb64a9eb1c9d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to keep backward compatibility with how inspection worked before managed"},{"line_number":13,"context_line":"boot was introduced."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With in-band inspection migrating to Ironic proper, this \"unmanaged\""},{"line_number":16,"context_line":"mode becomes a more exotic case since it requires additional PXE"},{"line_number":17,"context_line":"infrastructure. Additionally, the popularity of Redfish is rapidly"},{"line_number":18,"context_line":"growing, and we support pre-populating ports when Redfish is used."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6e4442e1_0a0403fe","line":16,"range":{"start_line":15,"start_character":51,"end_line":16,"end_character":4},"in_reply_to":"88ff31d7_6de681d0","updated":"2023-03-16 22:31:25.000000000","message":"This is a cool idea, but it still seems like changing the default here is useful.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f0bbc20ada6e64c0878eb3b515bdb64a9eb1c9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a3bfd5c_47b2b464","updated":"2023-03-16 22:31:25.000000000","message":"A question I\u0027d like answered before I go full +2; but admittedly I\u0027m low on context on inspector change.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4da8a88e6b81cabc5dcac573442d6243e0dad004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37960d7e_11cb36a8","updated":"2023-03-16 16:37:16.000000000","message":"LGTM, I made comment in the commit message, it\u0027s not strictly about this change but wanted to float the idea as it is related.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"142c4108898ce687065ca6fe4a8cf750100cf08d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae87fec6_362074d7","updated":"2023-06-02 13:00:22.000000000","message":"recheck","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"}],"ironic/conf/inspector.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f0bbc20ada6e64c0878eb3b515bdb64a9eb1c9d2","unresolved":true,"context_lines":[{"line_number":34,"context_line":"               help\u003d_(\u0027endpoint to use as a callback for posting back \u0027"},{"line_number":35,"context_line":"                      \u0027introspection data when boot is managed by ironic. \u0027"},{"line_number":36,"context_line":"                      \u0027Standard keystoneauth options are used by default.\u0027)),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027require_managed_boot\u0027, default\u003dNone,"},{"line_number":38,"context_line":"                help\u003d_(\u0027require that the in-band inspection boot is fully \u0027"},{"line_number":39,"context_line":"                       \u0027managed by the node\\\u0027s boot interface. Set this to \u0027"},{"line_number":40,"context_line":"                       \u0027True if your installation does not have a separate \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a43a5000_b26a961f","line":37,"updated":"2023-03-16 22:31:25.000000000","message":"None as the default for a boolopt seems really strange; almost like a ternary? Is this OK? Is there an example of us doing this elsewhere?","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d4f7dbc7cfba549ba7c3ce31dc3037aa2a7b6ee","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d_(\u0027endpoint to use as a callback for posting back \u0027"},{"line_number":35,"context_line":"                      \u0027introspection data when boot is managed by ironic. \u0027"},{"line_number":36,"context_line":"                      \u0027Standard keystoneauth options are used by default.\u0027)),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027require_managed_boot\u0027, default\u003dNone,"},{"line_number":38,"context_line":"                help\u003d_(\u0027require that the in-band inspection boot is fully \u0027"},{"line_number":39,"context_line":"                       \u0027managed by the node\\\u0027s boot interface. Set this to \u0027"},{"line_number":40,"context_line":"                       \u0027True if your installation does not have a separate \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3c5eb80_bb0500d6","line":37,"in_reply_to":"a43a5000_b26a961f","updated":"2023-03-17 09:50:35.000000000","message":"I think we did that with default_boot_mode when transitioning from legacy to uefi. I\u0027m not sure how else to avoid issuing the warning when the operators sets False explicitly.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9031c6bcf79cf1af5b91572baaafd13a0c183a88","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d_(\u0027endpoint to use as a callback for posting back \u0027"},{"line_number":35,"context_line":"                      \u0027introspection data when boot is managed by ironic. \u0027"},{"line_number":36,"context_line":"                      \u0027Standard keystoneauth options are used by default.\u0027)),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027require_managed_boot\u0027, default\u003dNone,"},{"line_number":38,"context_line":"                help\u003d_(\u0027require that the in-band inspection boot is fully \u0027"},{"line_number":39,"context_line":"                       \u0027managed by the node\\\u0027s boot interface. Set this to \u0027"},{"line_number":40,"context_line":"                       \u0027True if your installation does not have a separate \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"181e81e7_cde41fd8","line":37,"in_reply_to":"d3c5eb80_bb0500d6","updated":"2023-03-17 14:20:31.000000000","message":"... I *think* you can do that but yeah, it does seem weird. (and yes, it feels like we have done this before but I think it was as a StrOpt with a list of explicit options.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9031c6bcf79cf1af5b91572baaafd13a0c183a88","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                       \u0027True if your installation does not have a separate \u0027"},{"line_number":41,"context_line":"                       \u0027(i)PXE boot environment for node discovery. Set \u0027"},{"line_number":42,"context_line":"                       \u0027to False if you need to inspect nodes that are not \u0027"},{"line_number":43,"context_line":"                       \u0027supported by boot interfaces (e.g. because they \u0027"},{"line_number":44,"context_line":"                       \u0027don\\\u0027t have ports).\u0027)),"},{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cbe29ce9_2869ba18","line":44,"range":{"start_line":43,"start_character":53,"end_line":44,"end_character":47},"updated":"2023-03-17 14:20:31.000000000","message":"This is, in part, why some operators do inband inspection, swap over to out of band to get the rest of the details. :\\","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51c1d05e013ab40c7da018981c9acc0a94c631d1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                       \u0027True if your installation does not have a separate \u0027"},{"line_number":41,"context_line":"                       \u0027(i)PXE boot environment for node discovery. Set \u0027"},{"line_number":42,"context_line":"                       \u0027to False if you need to inspect nodes that are not \u0027"},{"line_number":43,"context_line":"                       \u0027supported by boot interfaces (e.g. because they \u0027"},{"line_number":44,"context_line":"                       \u0027don\\\u0027t have ports).\u0027)),"},{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4c78a7b7_823ea526","line":44,"range":{"start_line":43,"start_character":53,"end_line":44,"end_character":47},"in_reply_to":"cbe29ce9_2869ba18","updated":"2023-03-17 14:22:31.000000000","message":"Yeah, my point is not that we should drop this feature. We\u0027re just moving from \"if you have inspector, unmanaged inspection probably works\" to \"you have in-band inspection in ironic, but do you have everything set for unmanaged inspection\"? I.e. a different option becomes explicit.","commit_id":"58388212bc881074d13a9ae5a41c855816bd2d45"}]}